Hi "Matthew, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on next-20210629] [cannot apply to hnaz-linux-mm/master tip/perf/core cgroup/for-next v5.13] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/Folio-conversion-of-memcg/20210630-121408 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 007b350a58754a93ca9fe50c498cc27780171153 config: arm64-randconfig-c024-20210630 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/c7ce93681b922cb2b709109c21e8206ef623e0be git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Folio-conversion-of-memcg/20210630-121408 git checkout c7ce93681b922cb2b709109c21e8206ef623e0be # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from arch/arm64/kernel/asm-offsets.c:12: include/linux/mm.h:1382:42: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1382 | static inline int folio_nid(const struct folio *folio) | ^~~~~ include/linux/mm.h: In function 'folio_nid': include/linux/mm.h:1384:27: error: dereferencing pointer to incomplete type 'const struct folio' 1384 | return page_to_nid(&folio->page); | ^~ In file included from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/arm64/kernel/asm-offsets.c:16: include/linux/memcontrol.h: At top level: include/linux/memcontrol.h:1138:44: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1138 | static inline bool folio_memcg_kmem(struct folio *folio) | ^~~~~ include/linux/memcontrol.h:1190:44: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1190 | static inline int mem_cgroup_charge(struct folio *folio, | ^~~~~ include/linux/memcontrol.h:1206:47: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1206 | static inline void mem_cgroup_uncharge(struct folio *folio) | ^~~~~ include/linux/memcontrol.h:1214:46: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1214 | static inline void mem_cgroup_migrate(struct folio *old, struct folio *new) | ^~~~~ include/linux/memcontrol.h:1224:61: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1224 | static inline struct lruvec *mem_cgroup_folio_lruvec(struct folio *folio) | ^~~~~ include/linux/memcontrol.h: In function 'mem_cgroup_folio_lruvec': include/linux/memcontrol.h:1226:30: error: implicit declaration of function 'folio_pgdat'; did you mean 'folio_nid'? [-Werror=implicit-function-declaration] 1226 | struct pglist_data *pgdat = folio_pgdat(folio); | ^~~~~~~~~~~ | folio_nid >> include/linux/memcontrol.h:1226:30: warning: initialization of 'struct pglist_data *' from 'int' makes pointer from integer without a cast [-Wint-conversion] include/linux/memcontrol.h: At top level: include/linux/memcontrol.h:1366:44: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1366 | static inline void folio_memcg_lock(struct folio *folio) | ^~~~~ include/linux/memcontrol.h:1370:46: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1370 | static inline void folio_memcg_unlock(struct folio *folio) | ^~~~~ include/linux/memcontrol.h: In function 'mem_cgroup_page_lruvec': include/linux/memcontrol.h:1488:33: error: implicit declaration of function 'page_folio' [-Werror=implicit-function-declaration] 1488 | return mem_cgroup_folio_lruvec(page_folio(page)); | ^~~~~~~~~~ include/linux/memcontrol.h:1488:33: warning: passing argument 1 of 'mem_cgroup_folio_lruvec' makes pointer from integer without a cast [-Wint-conversion] 1488 | return mem_cgroup_folio_lruvec(page_folio(page)); | ^~~~~~~~~~~~~~~~ | | | int include/linux/memcontrol.h:1224:68: note: expected 'struct folio *' but argument is of type 'int' 1224 | static inline struct lruvec *mem_cgroup_folio_lruvec(struct folio *folio) | ~~~~~~~~~~~~~~^~~~~ cc1: some warnings being treated as errors -- In file included from arch/arm64/kernel/asm-offsets.c:12: include/linux/mm.h:1382:42: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1382 | static inline int folio_nid(const struct folio *folio) | ^~~~~ include/linux/mm.h: In function 'folio_nid': include/linux/mm.h:1384:27: error: dereferencing pointer to incomplete type 'const struct folio' 1384 | return page_to_nid(&folio->page); | ^~ In file included from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/arm64/kernel/asm-offsets.c:16: include/linux/memcontrol.h: At top level: include/linux/memcontrol.h:1138:44: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1138 | static inline bool folio_memcg_kmem(struct folio *folio) | ^~~~~ include/linux/memcontrol.h:1190:44: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1190 | static inline int mem_cgroup_charge(struct folio *folio, | ^~~~~ include/linux/memcontrol.h:1206:47: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1206 | static inline void mem_cgroup_uncharge(struct folio *folio) | ^~~~~ include/linux/memcontrol.h:1214:46: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1214 | static inline void mem_cgroup_migrate(struct folio *old, struct folio *new) | ^~~~~ include/linux/memcontrol.h:1224:61: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1224 | static inline struct lruvec *mem_cgroup_folio_lruvec(struct folio *folio) | ^~~~~ include/linux/memcontrol.h: In function 'mem_cgroup_folio_lruvec': include/linux/memcontrol.h:1226:30: error: implicit declaration of function 'folio_pgdat'; did you mean 'folio_nid'? [-Werror=implicit-function-declaration] 1226 | struct pglist_data *pgdat = folio_pgdat(folio); | ^~~~~~~~~~~ | folio_nid >> include/linux/memcontrol.h:1226:30: warning: initialization of 'struct pglist_data *' from 'int' makes pointer from integer without a cast [-Wint-conversion] include/linux/memcontrol.h: At top level: include/linux/memcontrol.h:1366:44: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1366 | static inline void folio_memcg_lock(struct folio *folio) | ^~~~~ include/linux/memcontrol.h:1370:46: warning: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration 1370 | static inline void folio_memcg_unlock(struct folio *folio) | ^~~~~ include/linux/memcontrol.h: In function 'mem_cgroup_page_lruvec': include/linux/memcontrol.h:1488:33: error: implicit declaration of function 'page_folio' [-Werror=implicit-function-declaration] 1488 | return mem_cgroup_folio_lruvec(page_folio(page)); | ^~~~~~~~~~ include/linux/memcontrol.h:1488:33: warning: passing argument 1 of 'mem_cgroup_folio_lruvec' makes pointer from integer without a cast [-Wint-conversion] 1488 | return mem_cgroup_folio_lruvec(page_folio(page)); | ^~~~~~~~~~~~~~~~ | | | int include/linux/memcontrol.h:1224:68: note: expected 'struct folio *' but argument is of type 'int' 1224 | static inline struct lruvec *mem_cgroup_folio_lruvec(struct folio *folio) | ~~~~~~~~~~~~~~^~~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:117: arch/arm64/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1235: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:215: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +1226 include/linux/memcontrol.h 1223 1224 static inline struct lruvec *mem_cgroup_folio_lruvec(struct folio *folio) 1225 { > 1226 struct pglist_data *pgdat = folio_pgdat(folio); 1227 return &pgdat->__lruvec; 1228 } 1229 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org