All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Alistair Francis <alistair.francis@wdc.com>
Subject: [PATCH v2 20/28] target/riscv: Use translator_use_goto_tb
Date: Wed, 30 Jun 2021 11:32:18 -0700	[thread overview]
Message-ID: <20210630183226.3290849-21-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210630183226.3290849-1-richard.henderson@linaro.org>

Just use translator_use_goto_tb directly at the one call site,
rather than maintaining a local wrapper.

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/riscv/translate.c | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index 62a7d7e4c7..deda0c8a44 100644
--- a/target/riscv/translate.c
+++ b/target/riscv/translate.c
@@ -168,29 +168,11 @@ static void gen_exception_inst_addr_mis(DisasContext *ctx)
     generate_exception_mtval(ctx, RISCV_EXCP_INST_ADDR_MIS);
 }
 
-static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest)
-{
-    if (unlikely(ctx->base.singlestep_enabled)) {
-        return false;
-    }
-
-#ifndef CONFIG_USER_ONLY
-    return (ctx->base.tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK);
-#else
-    return true;
-#endif
-}
-
 static void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest)
 {
-    if (use_goto_tb(ctx, dest)) {
-        /* chaining is only allowed when the jump is to the same page */
+    if (translator_use_goto_tb(&ctx->base, dest)) {
         tcg_gen_goto_tb(n);
         tcg_gen_movi_tl(cpu_pc, dest);
-
-        /* No need to check for single stepping here as use_goto_tb() will
-         * return false in case of single stepping.
-         */
         tcg_gen_exit_tb(ctx->base.tb, n);
     } else {
         tcg_gen_movi_tl(cpu_pc, dest);
-- 
2.25.1



  parent reply	other threads:[~2021-06-30 19:04 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 18:31 [PATCH v2 00/28] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
2021-06-30 18:31 ` [PATCH v2 01/28] " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 02/28] target/alpha: Remove use_exit_tb Richard Henderson
2021-07-08 12:34   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 03/28] target/alpha: Remove in_superpage Richard Henderson
2021-07-08 12:35   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 04/28] target/alpha: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:29   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB Richard Henderson
2021-07-08 12:05   ` Peter Maydell
2021-07-08 16:04     ` Richard Henderson
2021-07-08 16:11       ` Peter Maydell
2021-07-08 16:17         ` Richard Henderson
2021-07-08 17:47           ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 06/28] target/arm: Use translator_use_goto_tb for aarch64 Richard Henderson
2021-07-08 12:08   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 07/28] target/arm: Use translator_use_goto_tb for aarch32 Richard Henderson
2021-07-08 12:14   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 08/28] target/avr: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:28   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 09/28] target/avr: Mark some helpers noreturn Richard Henderson
2021-06-30 18:32 ` [PATCH v2 10/28] target/cris: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:27   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 11/28] target/hppa: " Richard Henderson
2021-07-08 12:26   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 12/28] target/i386: " Richard Henderson
2021-07-08 12:26   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 13/28] target/m68k: " Richard Henderson
2021-07-08 12:22   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 14/28] target/microblaze: " Richard Henderson
2021-07-08 12:21   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 15/28] target/mips: " Richard Henderson
2021-07-08 12:18   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 16/28] target/mips: Fix missing else in gen_goto_tb Richard Henderson
2021-06-30 18:32 ` [PATCH v2 17/28] target/nios2: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:17   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 18/28] target/openrisc: " Richard Henderson
2021-07-07 20:59   ` Stafford Horne
2021-06-30 18:32 ` [PATCH v2 19/28] target/ppc: " Richard Henderson
2021-06-30 18:32 ` Richard Henderson [this message]
2021-06-30 18:32 ` [PATCH v2 21/28] target/rx: " Richard Henderson
2021-07-08 12:17   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 22/28] target/s390x: " Richard Henderson
2021-07-01  7:42   ` David Hildenbrand
2021-06-30 18:32 ` [PATCH v2 23/28] target/s390x: Remove use_exit_tb Richard Henderson
2021-07-01  7:44   ` David Hildenbrand
2021-06-30 18:32 ` [PATCH v2 24/28] target/sh4: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:16   ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 25/28] target/sparc: " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 26/28] target/tricore: " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 27/28] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2021-06-30 18:32 ` [PATCH v2 28/28] target/xtensa: Use translator_use_goto_tb Richard Henderson
2021-07-07 21:41 ` [PATCH v2 00/28] accel/tcg: Introduce translator_use_goto_tb Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210630183226.3290849-21-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.