From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FE1BC11F65 for ; Wed, 30 Jun 2021 18:45:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B25B61285 for ; Wed, 30 Jun 2021 18:45:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B25B61285 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyfDg-0008Tl-1Z for qemu-devel@archiver.kernel.org; Wed, 30 Jun 2021 14:45:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyf0k-00055w-3e for qemu-devel@nongnu.org; Wed, 30 Jun 2021 14:32:34 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:40455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyf0i-0001yp-6y for qemu-devel@nongnu.org; Wed, 30 Jun 2021 14:32:33 -0400 Received: by mail-pf1-x42a.google.com with SMTP id j199so2860730pfd.7 for ; Wed, 30 Jun 2021 11:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dZ0tLrfANOVxMWpkjlBjlY0SUk5qXlMLl88Ghw1NubI=; b=RwZsGG2QOkBMwGuAF4pYiDvR00hb7nSQlTyO5J0n0/xrlu9I26UWxigbt00OV7pP8g NZYOWJEACf3gdSQxeQ48qT4o0uh0yCaK+WOY9EO9A7yNIwqtWQZ5g0G2HBxDqh+nNPx+ F98eg+fWFFCPGyL5fzwZk0kZFhSOl0YluRKi7eWHmOS6lMwdRQSsrqxjojLtxF1R2q5L nHxJtF5PAn3rd0ZVvVW+3VoqJRe86XqzekLa3XNsEPgfB5PJ23Vv7qjuduK8uAHET1yb sZWZH+NGoYCJFX/u+/kJ5opJp7A3qXx6pLdSuVBLJh5eV0SI4K4cGbGrWhGcGnpwH+f6 0yaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dZ0tLrfANOVxMWpkjlBjlY0SUk5qXlMLl88Ghw1NubI=; b=FgEHZYEc3ti408lZ2BoKW0xWoLUzFY9XM2VO/QYfARqGmL6D5yRcQ52xmAyvUKoDoP LieKY46Krlk4rcBzEq00gKLa5aQmeWYtGowVs0L9VxCK5oy3FGONrZEygdUPzHLs4FqK 4W3Y40bNj+W13hiDndCGiK2YUPQT5HSN9c5X9NjLl2sB9yo5elcrLb53eGg7BiLeVLw+ VPuDeopiu7k0C+yzru6WcUJNXlkmHF16nl249pH7OxOmms6bmGpTcnQW8ZcWnxagaZH/ y64uGmkaSD424WmtsUuwCKMES0dBIWTmyMksct43WrD5SVsKJ84+PebHuhrV24kZutX2 dTow== X-Gm-Message-State: AOAM532oFoi4TLdN26QLL9F8jYX1WlAmiduuc7acJzlSIuRyU7xssv6I N0jS8562Bcu4qYsLidBypXIKUiYfUovxXA== X-Google-Smtp-Source: ABdhPJxEr4KGH9s7GuAfKZEcLUER01Vqy1LpFOR1Mn7Zw/ZgjkKYU/NSLAoXkD+I54b/CYYFoi6pqA== X-Received: by 2002:a62:3344:0:b029:24c:735c:4546 with SMTP id z65-20020a6233440000b029024c735c4546mr37827189pfz.1.1625077950953; Wed, 30 Jun 2021 11:32:30 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id m18sm23909517pff.88.2021.06.30.11.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 11:32:30 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB Date: Wed, 30 Jun 2021 11:32:03 -0700 Message-Id: <20210630183226.3290849-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210630183226.3290849-1-richard.henderson@linaro.org> References: <20210630183226.3290849-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Using gen_goto_tb directly misses the single-step check. Cc: qemu-arm@nongnu.org Signed-off-by: Richard Henderson --- target/arm/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index a0c6cfa902..8cd31feeaa 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -8582,7 +8582,7 @@ static bool trans_ISB(DisasContext *s, arg_ISB *a) * self-modifying code correctly and also to take * any pending interrupts immediately. */ - gen_goto_tb(s, 0, s->base.pc_next); + gen_jmp(s, s->base.pc_next); return true; } @@ -8596,7 +8596,7 @@ static bool trans_SB(DisasContext *s, arg_SB *a) * for TCG; MB and end the TB instead. */ tcg_gen_mb(TCG_MO_ALL | TCG_BAR_SC); - gen_goto_tb(s, 0, s->base.pc_next); + gen_jmp(s, s->base.pc_next); return true; } -- 2.25.1