From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 0/3] btrfs: commit the transaction unconditionally for ensopc
Date: Wed, 30 Jun 2021 20:57:41 +0200 [thread overview]
Message-ID: <20210630185741.GS2610@twin.jikos.cz> (raw)
In-Reply-To: <cover.1623421213.git.josef@toxicpanda.com>
On Fri, Jun 11, 2021 at 10:23:07AM -0400, Josef Bacik wrote:
> Hello,
>
> While debugging early ENOSPC issues in the Facebook fleet I hit a case where we
> weren't committing the transaction because of some patch that I hadn't
> backported to our kernel.
>
> This made me think really hard about why we have may_commit_transaction, and
> realized that it doesn't make sense in it's current form anymore. By-in-large
> it just exists to have bugs in it and cause us pain. It served a purpose in the
> pre-ticketing days, but now just exists to be a giant pain in the ass.
>
> So rip it out. Just commit the transaction. This also allows us to drop the
> logic for ->total_bytes_pinned, which Nikolay noticed a problem with earlier
> this week again. Thanks,
>
> Josef Bacik (3):
> btrfs: rip out may_commit_transaction
> btrfs: rip the first_ticket_bytes logic from fail_all_tickets
> btrfs: rip out ->total_bytes_pinned
For the record, this has been picked before merge and is now in 5.14-rc.
prev parent reply other threads:[~2021-06-30 19:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 14:23 [PATCH 0/3] btrfs: commit the transaction unconditionally for ensopc Josef Bacik
2021-06-11 14:23 ` [PATCH 1/3] btrfs: rip out may_commit_transaction Josef Bacik
2021-06-14 12:17 ` Nikolay Borisov
2021-06-14 18:26 ` Josef Bacik
2021-06-11 14:23 ` [PATCH 2/3] btrfs: rip the first_ticket_bytes logic from fail_all_tickets Josef Bacik
2021-06-11 14:23 ` [PATCH 3/3] btrfs: rip out ->total_bytes_pinned Josef Bacik
2021-06-14 13:22 ` [PATCH 0/3] btrfs: commit the transaction unconditionally for ensopc Nikolay Borisov
2021-06-30 18:57 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630185741.GS2610@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.