From: Joao Marcos Costa <jmcosta944@gmail.com>
To: u-boot@lists.denx.de
Cc: thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com,
richard.genoud@posteo.net, sjg@chromium.org,
Joao Marcos Costa <jmcosta944@gmail.com>
Subject: [PATCH v3 0/3] test/py: Rewrite SquashFS commands test suite
Date: Wed, 30 Jun 2021 19:45:02 -0300 [thread overview]
Message-ID: <20210630224505.104648-1-jmcosta944@gmail.com> (raw)
Hello,
This patch series fixes the following issues:
- poor strategy to check if files were properly loaded
- wrong quoting style for strings
- tests failing at the second run because of a wrong clean-up strategy
Finally, it improves:
- code overall documentation level, with more comments and better
naming for functions and variables
- code readability by adding more helper functions
- completeness: more test cases were added for both sqfsls and sqfsload
commands
The sqfsload new test suite may fail when testing images with fragmented
files if the patch I previously sent (fs/squashfs: fix reading of
fragmented files) is not applied, so this patch series depends on it.
Changes since V2:
- Add check_mksquashfs_version function to raise an exception if
mksquashfs version is too old. I chose to set the required version as
4.4, since it seems to be the most recent one.
Changes since V1:
- Leave the copyright year as it was (2020) instead of changing it to
2021
- Remove spurious comments and print statements
- Fix the style issues pointed by pylint3
Best regards,
Joao
Joao Marcos Costa (3):
test/py: rewrite common tools for SquashFS tests
test/py: rewrite sqfsload command test suite
test/py: rewrite sqfsls command test suite
.../test_fs/test_squashfs/sqfs_common.py | 257 +++++++++++++-----
.../test_fs/test_squashfs/test_sqfs_load.py | 168 ++++++++++--
.../test_fs/test_squashfs/test_sqfs_ls.py | 140 ++++++++--
3 files changed, 452 insertions(+), 113 deletions(-)
--
2.25.1
next reply other threads:[~2021-06-30 22:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 22:45 Joao Marcos Costa [this message]
2021-06-30 22:45 ` [PATCH v3 1/3] test/py: rewrite common tools for SquashFS tests Joao Marcos Costa
2021-07-05 15:29 ` Simon Glass
2021-07-06 0:59 ` Tom Rini
2021-06-30 22:45 ` [PATCH v3 2/3] test/py: rewrite sqfsload command test suite Joao Marcos Costa
2021-07-05 15:29 ` Simon Glass
2021-07-06 0:59 ` Tom Rini
2021-06-30 22:45 ` [PATCH v3 3/3] test/py: rewrite sqfsls " Joao Marcos Costa
2021-07-05 15:29 ` Simon Glass
2021-07-06 0:59 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630224505.104648-1-jmcosta944@gmail.com \
--to=jmcosta944@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard.genoud@posteo.net \
--cc=sjg@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.