From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7037770 for ; Wed, 30 Jun 2021 23:25:33 +0000 (UTC) Received: by mail-pg1-f178.google.com with SMTP id v7so4159258pgl.2 for ; Wed, 30 Jun 2021 16:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yDF6eIHYx4lHuUbnt6LeNa9ic07VE8wVLsInf5Lm3v4=; b=mzdMGpAm6raA+Ilfd/q3Lm9o4IC5cFgtB+eiGiZq/Qie4h4inL+mPTOn4BIMTU3Rj7 4cuPR9g0Nvf7LC0DNKI6/wUiDmRB7ez9yP8HRd3ddDY+GkTVgmE+CtNcp785qr1Ah+lN 165ZpJpUOn8TxGpsgW+OWuEz623u9Bf5ITB53YXhKylhayDgZR+oU5y8ZSND87uxmnjc 9pg0JfP6zUZ1flPC0YKRRKOMzUyAgA6FtuTm3AIj4EqK9/yu34xIsdVnFWKlDkGOMtEP HcUmpIPJQSWY6l7Sob5AcpBpzUE4js3N0ZQfXTC7wdtyteMv4lxoFD92kLoL67v6DSIp 2ucA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yDF6eIHYx4lHuUbnt6LeNa9ic07VE8wVLsInf5Lm3v4=; b=h4coZSw+Bqf6D0IJWrCnAHLH/wOlYqVfSwj4Tc/os6Z8dblDpUMgh7S+kwmywUSMsS ZBevZKprWRCXIafpMM43QtIaB3odDpyws1lyCCEJNvOeatWksnpA3ja/8uSoHkKDko9I WYZ2ozWkLnuwJcZdNbvrleqNE2mx2Y3jiW6YalXVcPcP+qPKV++/cwgRrNEyGJfQrYwW N0isT33Z+27kFDB4uiMcKEI1zp14txf7iNy9hyjMwRKTkAPAHPNNGgvPzCGOVEDmiyAT WM35EmMd9CY3uCpUBT+o8HvmAJUq6Gcj8g8tX8PKbHk7xWJbXNpvqix9xVrfIFpZS5Ur 0uyQ== X-Gm-Message-State: AOAM532Xng2Y+hhD5OfqIS623i2PIIdcdOwzXiH5EwYANgHUR8L8zs9t ocnGJyoWYo6s78B4fwRQWtA= X-Google-Smtp-Source: ABdhPJwpbvjG6ISQ62Gx1WauLZDhTJ+HP2fPc575a/6kC6mOk201hah2ghg4/MGOXEX8ubIcZga8ag== X-Received: by 2002:a63:e114:: with SMTP id z20mr36045534pgh.207.1625095533023; Wed, 30 Jun 2021 16:25:33 -0700 (PDT) Received: from localhost ([160.16.113.140]) by smtp.gmail.com with ESMTPSA id y3sm24461324pga.72.2021.06.30.16.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 16:25:32 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 1 Jul 2021 07:19:49 +0800 To: Dan Carpenter Cc: linux-staging@lists.linux.dev, netdev@vger.kernel.org, Benjamin Poirier , Shung-Hsi Yu , Manish Chopra , "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , Greg Kroah-Hartman , open list Subject: Re: [RFC 16/19] staging: qlge: remove deadcode in qlge_build_rx_skb Message-ID: <20210630231949.gpmk433lrztp6iau@Rk> References: <20210621134902.83587-1-coiby.xu@gmail.com> <20210621134902.83587-17-coiby.xu@gmail.com> <20210622072939.GL1861@kadam> <20210624112500.rhtqp7j3odq6b6bq@Rk> <20210624124926.GI1983@kadam> <20210627105349.pflw2r2b4qus64kf@Rk> <20210628064645.GK2040@kadam> <20210629133541.2n3rr7vzglcoy56x@Rk> <20210629142201.GQ2040@kadam> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210629142201.GQ2040@kadam> On Tue, Jun 29, 2021 at 05:22:02PM +0300, Dan Carpenter wrote: >*sigh* > >You're right. Sorry. > >I misread IB_MAC_IOCB_RSP_HV as IB_MAC_IOCB_RSP_HS. In my defense, it's >a five word name and only one letter is different. It's like trying to >find Waldo. That's fine. Thanks for reviewing the patch and prompting me to write a more comprehensible commit message! > >regards, >dan carpenter > -- Best regards, Coiby From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85867C11F68 for ; Wed, 30 Jun 2021 23:25:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6358661241 for ; Wed, 30 Jun 2021 23:25:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237659AbhF3X2E (ORCPT ); Wed, 30 Jun 2021 19:28:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236227AbhF3X2D (ORCPT ); Wed, 30 Jun 2021 19:28:03 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 866A6C061756; Wed, 30 Jun 2021 16:25:33 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id a127so4101702pfa.10; Wed, 30 Jun 2021 16:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yDF6eIHYx4lHuUbnt6LeNa9ic07VE8wVLsInf5Lm3v4=; b=mzdMGpAm6raA+Ilfd/q3Lm9o4IC5cFgtB+eiGiZq/Qie4h4inL+mPTOn4BIMTU3Rj7 4cuPR9g0Nvf7LC0DNKI6/wUiDmRB7ez9yP8HRd3ddDY+GkTVgmE+CtNcp785qr1Ah+lN 165ZpJpUOn8TxGpsgW+OWuEz623u9Bf5ITB53YXhKylhayDgZR+oU5y8ZSND87uxmnjc 9pg0JfP6zUZ1flPC0YKRRKOMzUyAgA6FtuTm3AIj4EqK9/yu34xIsdVnFWKlDkGOMtEP HcUmpIPJQSWY6l7Sob5AcpBpzUE4js3N0ZQfXTC7wdtyteMv4lxoFD92kLoL67v6DSIp 2ucA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yDF6eIHYx4lHuUbnt6LeNa9ic07VE8wVLsInf5Lm3v4=; b=E566VjI0pGjD/B3Nhub0DluTIg6g35/eDSKTgOPgBODt99QxOCPAT2NY2h53YvxKlE JcsSHFFr8RWt5o1WfPbM/HGyZKtuc/86ekaQh7OLKWTQW6OK2sJzMdCgVhwa8aST4aBR X5gEB+ue1EWE5Zch0xglVfRIZqhmMVab4Pac6D9BP2aGIw5kE0yJY5GbX+dZC16hlSgy ix6IwcXOOnNgu4+wuruu9UC5bU3A56R16dACd7EmOPybZkuBA96f908tacQW+puitGzt 3tN4ekTsdzyDgEtGKZQDCnEPTkBI7CdxrgvNQYHa/lqJ4JtG2gg7kRxsu5FpFElDPWLT P1Bw== X-Gm-Message-State: AOAM532WbjTeGuszNKI6eCxKgIsOrFrkSsYE9xqYIGjWJKZLOLMf4Zw8 SRldf0Qf39qbWFr1CHKLfpQ= X-Google-Smtp-Source: ABdhPJwpbvjG6ISQ62Gx1WauLZDhTJ+HP2fPc575a/6kC6mOk201hah2ghg4/MGOXEX8ubIcZga8ag== X-Received: by 2002:a63:e114:: with SMTP id z20mr36045534pgh.207.1625095533023; Wed, 30 Jun 2021 16:25:33 -0700 (PDT) Received: from localhost ([160.16.113.140]) by smtp.gmail.com with ESMTPSA id y3sm24461324pga.72.2021.06.30.16.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 16:25:32 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 1 Jul 2021 07:19:49 +0800 To: Dan Carpenter Cc: linux-staging@lists.linux.dev, netdev@vger.kernel.org, Benjamin Poirier , Shung-Hsi Yu , Manish Chopra , "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" , Greg Kroah-Hartman , open list Subject: Re: [RFC 16/19] staging: qlge: remove deadcode in qlge_build_rx_skb Message-ID: <20210630231949.gpmk433lrztp6iau@Rk> References: <20210621134902.83587-1-coiby.xu@gmail.com> <20210621134902.83587-17-coiby.xu@gmail.com> <20210622072939.GL1861@kadam> <20210624112500.rhtqp7j3odq6b6bq@Rk> <20210624124926.GI1983@kadam> <20210627105349.pflw2r2b4qus64kf@Rk> <20210628064645.GK2040@kadam> <20210629133541.2n3rr7vzglcoy56x@Rk> <20210629142201.GQ2040@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210629142201.GQ2040@kadam> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 29, 2021 at 05:22:02PM +0300, Dan Carpenter wrote: >*sigh* > >You're right. Sorry. > >I misread IB_MAC_IOCB_RSP_HV as IB_MAC_IOCB_RSP_HS. In my defense, it's >a five word name and only one letter is different. It's like trying to >find Waldo. That's fine. Thanks for reviewing the patch and prompting me to write a more comprehensible commit message! > >regards, >dan carpenter > -- Best regards, Coiby