All of lore.kernel.org
 help / color / mirror / Atom feed
From: venkata.sai.patnana@intel.com
To: igt-dev@lists.freedesktop.org
Cc: "Juha-Pekka Heikkilä" <juha-pekka.heikkila@intel.com>
Subject: [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_rotation_crc: Skip 90/270 rotation for ADL-P
Date: Thu,  1 Jul 2021 09:31:14 +0530	[thread overview]
Message-ID: <20210701040115.20186-1-venkata.sai.patnana@intel.com> (raw)
In-Reply-To: <20210630152841.10527-1-venkata.sai.patnana@intel.com>

From: Patnana Venkata Sai <venkata.sai.patnana@intel.com>

ADL-P platform doesn't support 90/270 rotation. Let's skip to test
with these rotations.

Cc: Juha-Pekka Heikkilä <juha-pekka.heikkila@intel.com>
Cc: Karthik B S <karthik.b.s@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
Signed-off-by: Patnana Venkata Sai <venkata.sai.patnana@intel.com>
---
 tests/kms_rotation_crc.c | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 20556c825a..811f295e9c 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -737,6 +737,14 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
 						     (planeconfigs[j].rotation & (IGT_ROTATION_90 | IGT_ROTATION_270))
 						     && intel_display_ver(data->devid) < 11)
 							continue;
+
+						if ((planeconfigs[i].rotation & (IGT_ROTATION_90 | IGT_ROTATION_270))
+						    && intel_display_ver(data->devid) >= 13)
+							continue;
+
+						if ((planeconfigs[j].rotation & (IGT_ROTATION_90 | IGT_ROTATION_270))
+						    && intel_display_ver(data->devid) >= 13)
+							continue;
 						/*
 						 * if using packed formats crc's will be
 						 * same and can store them so there's
@@ -1042,8 +1050,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 			      rot_test_str(subtest->rot)) {
 			if (is_i915_device(data.gfx_fd)) {
 				igt_require(!(subtest->rot &
-					    (IGT_ROTATION_90 | IGT_ROTATION_270)) ||
-					    gen >= 9);
+                                            (IGT_ROTATION_90 | IGT_ROTATION_270)) ||
+                                            (gen >= 9 && gen < 13));
 			} else if (is_amdgpu_device(data.gfx_fd)) {
 				data.override_fmt = DRM_FORMAT_XRGB8888;
 				if (subtest->rot & (IGT_ROTATION_90 | IGT_ROTATION_270))
@@ -1060,7 +1068,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 
 	igt_describe("Rotation test with 90 degree for a plane of gen9+ with given position");
 	igt_subtest_f("sprite-rotation-90-pos-100-0") {
-		igt_require(gen >= 9);
+		igt_require(gen >=9 && gen < 13);
 		data.rotation = IGT_ROTATION_90;
 		data.pos_x = 100,
 		data.pos_y = 0;
@@ -1075,7 +1083,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		  * so apart from this, any other gen11+ pixel format
 		  * can be used which doesn't support 90/270 degree
 		  * rotation */
-		igt_require(gen >= 9);
+		igt_require(gen >=9 && gen < 13);
 		data.rotation = IGT_ROTATION_90;
 		data.override_fmt = gen < 11 ? DRM_FORMAT_RGB565 : DRM_FORMAT_Y212;
 		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, true);
@@ -1084,7 +1092,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 
 	igt_describe("Checking unsupported tiling for gen9+ with 90 degree of rotation");
 	igt_subtest_f("bad-tiling") {
-		igt_require(gen >= 9);
+		igt_require(gen >=9 && gen < 13);
 		data.rotation = IGT_ROTATION_90;
 		data.override_tiling = LOCAL_I915_FORMAT_MOD_X_TILED;
 		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, true);
@@ -1100,6 +1108,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 				    (IS_CHERRYVIEW(data.devid) && reflect_x->rot == IGT_ROTATION_0
 				     && reflect_x->tiling == LOCAL_I915_FORMAT_MOD_X_TILED));
 			data.rotation = (IGT_REFLECT_X | reflect_x->rot);
+			igt_require(!(gen >= 13 && (data.rotation &
+						    (IGT_ROTATION_90 |
+						     IGT_ROTATION_270))));
 			data.override_tiling = reflect_x->tiling;
 			test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, false);
 		}
@@ -1155,7 +1166,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		enum pipe pipe;
 		igt_output_t *output;
 
-		igt_require(gen >= 9);
+		igt_require(gen >= 9 && gen < 13);
 		igt_display_require_output(&data.display);
 
 		for_each_pipe_with_valid_output(&data.display, pipe, output) {
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-07-01  4:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 15:28 [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: Skip 90/270 rotation for xelpd venkata.sai.patnana
2021-06-30 15:45 ` [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: Skip 90/270 rotation for ADL-P venkata.sai.patnana
2021-07-01  4:07   ` Karthik B S
2021-06-30 16:36 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_rotation_crc: Skip 90/270 rotation for xelpd (rev2) Patchwork
2021-07-01  4:01 ` venkata.sai.patnana [this message]
2021-07-01  4:01   ` [igt-dev] [PATCH i-g-t 2/2] HAX remove kms_rotatation_crc from premerge blacklistHAX remove kms_rotatation_crc from premerge blacklist venkata.sai.patnana
2021-07-01  5:08     ` [igt-dev] [PATCH i-g-t v2 2/2] HAX " venkata.sai.patnana
2021-07-01  4:53 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_rotation_crc: Skip 90/270 rotation for xelpd (rev3) Patchwork
2021-07-01  5:39 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2021-07-01  5:59 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_rotation_crc: Skip 90/270 rotation for xelpd (rev4) Patchwork
2021-07-01  7:49 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_rotation_crc: Skip 90/270 rotation for xelpd (rev3) Patchwork
2021-07-01  8:39 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_rotation_crc: Skip 90/270 rotation for xelpd (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210701040115.20186-1-venkata.sai.patnana@intel.com \
    --to=venkata.sai.patnana@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juha-pekka.heikkila@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.