From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBBEC11F64 for ; Thu, 1 Jul 2021 17:18:18 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id EB0D761406 for ; Thu, 1 Jul 2021 17:18:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB0D761406 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09F0541329; Thu, 1 Jul 2021 19:18:17 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 3CD5D41325 for ; Thu, 1 Jul 2021 19:18:16 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id v7so6740442pgl.2 for ; Thu, 01 Jul 2021 10:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KQd85NxzyCFlLSZ/pPLleIK8FXeq1n5FxN1UlVMBWnA=; b=Td8rc20ZPZnron33NqLaNejzZqibQu1WsPWF2yuDMwhlYzkeP/PCx3rz9ONXILd2HY 1aJ47m+l44f+G4ZapHLGQgEdP2LZoKMMmFcFdYHjmYr8jTtjL3XTKVwEdT0yYl2RSZH0 E83gctVYP3JtAaH9ly53rgpuHcuztfaOZ75xHUy8JuB3nc+3vFA1gdKVzS8zqfegwwa4 IeMqj/ixmJW/F+V7uGC80as1N6VIyBbwYUSO17QBEoTH3aZCm4j30OPSotowOqiIFqBU IMz2Xv0e6pMGAZe1KnDJuUUoczo7KlvPI7mDX73MW64WQVbyRSJ6avz8hArFfQTFmiUD ix0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KQd85NxzyCFlLSZ/pPLleIK8FXeq1n5FxN1UlVMBWnA=; b=ohN1bL6r2EmHREb8qqxlqfxFOqzcMKN2I+WfjUtlhCen2J7N6X6AlB58uDr6WwUbXl FUzmGLzy7KrhoViT1VSr61k02qsJtXvBq4BFIqvHs3kHplLsg6U3WTifJNGfNcFAJqWW O+bkiWyeHckqexuWO+5VZTVgidZVi/nXGmXKxeNV+4m5t3PHRsZR0Bw9bREFfy6vk/Nf 05ua6k5HuMLS919jPnD+pX8OT6I1PHUGN7oIeYX0+IPegTC5MQ2MyIPz23qYxOBUA6Ov BaN19lCtJtGQQpoVuOlHqzPukK0N+peQjYqiT1TNgGbygwHMxkfd8ap9txmOYmIInGDf uzJg== X-Gm-Message-State: AOAM530+LCpJz6/gKqmQrXzso81X+Fo/c6uzj/WuNMdLH0XEsZox5Pw/ Wcjg3wysm62+112j/pxDeH6d8w== X-Google-Smtp-Source: ABdhPJyNkdunpBdt10z0L3Wt9wxpy6/OiZFIKqArId6wKyoD0LPg82Jnxt7CiwxGRmdcoVu905pVtQ== X-Received: by 2002:a63:6f02:: with SMTP id k2mr610372pgc.321.1625159895279; Thu, 01 Jul 2021 10:18:15 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id h18sm398390pgl.87.2021.07.01.10.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 10:18:15 -0700 (PDT) Date: Thu, 1 Jul 2021 10:18:12 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: Keith Wiles , dev@dpdk.org Message-ID: <20210701101812.5a380b36@hermes.local> In-Reply-To: <9f02b218-62e4-f40e-f8ce-c77395164a89@oktetlabs.ru> References: <20210616041528.4229-1-stephen@networkplumber.org> <20210616041528.4229-2-stephen@networkplumber.org> <9f02b218-62e4-f40e-f8ce-c77395164a89@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 1 Jul 2021 17:16:21 +0300 Andrew Rybchenko wrote: > On 6/16/21 7:15 AM, Stephen Hemminger wrote: > > Since these always return 0, they were doing nothing useful. > >=20 > > Signed-off-by: Stephen Hemminger =20 >=20 > I have no strong opinion on the patch, but sometimes even > empty functions with comments add value. So, I see no point > to touch it. So, I'll wait for maintainer reply. There are always many ways to write more obscure and technically correct code. It is best if the code is the smallest correct way. =E2=80=9CI apologize for such a long letter - I didn't have time to write a= short one.=E2=80=9D =E2=80=95 Mark Twain