From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79A50C11F64 for ; Thu, 1 Jul 2021 13:36:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C2FC6141A for ; Thu, 1 Jul 2021 13:36:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C2FC6141A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GOgTfAyvHxlcqqxzSahlQQq/Pl6GmqnaOBIvIUUVTrc=; b=fw0s6yJtn6rl2o MCJ2S2Dlt0q4/5GcyC569fkM8aL7xcI44qUWdhbmoB7He+7TGLEohj+vjo2m3Tk6TzsMqyWLrc5Bf G782F1gIdJygqDsBU/xOcynWVFbR+k19qPyDCRBB2LVgkKhfPg2aYLvZ9lqElVqd+RCWz8GbUuY8k IaVP1u2A1WpECM657eFVgy0moAv0J/p/HBKSkwrQ2zZKWkbq3EUtkvH9EhuKACXCogJkWWcLht/yc dsnNzbxrnUSIpHDoEXK78NGw07kGOiLJwkbLg6d/dMB5/i8q1UnokkT403CMuWtgRQea0h3Ae4e8S 5MT7gHc0AQEhInGf+a4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lywrN-00HUhL-5Y; Thu, 01 Jul 2021 13:36:05 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lywrK-00HUfZ-Qn for linux-nvme@lists.infradead.org; Thu, 01 Jul 2021 13:36:04 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id DF4C367357; Thu, 1 Jul 2021 15:36:00 +0200 (CEST) Date: Thu, 1 Jul 2021 15:36:00 +0200 From: Christoph Hellwig To: Prabhakar Kushwaha Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, axboe@fb.com, kbusch@kernel.org, davem@davemloft.net, kuba@kernel.org, smalin@marvell.com, aelior@marvell.com, mkalderon@marvell.com, okulkarni@marvell.com, prabhakar.pkin@gmail.com, malin1024@gmail.com, Dean Balandin Subject: Re: [PATCH v4 04/20] nvme-tcp-offload: Add device scan implementation Message-ID: <20210701133600.GD18548@lst.de> References: <20210629124743.6898-1-pkushwaha@marvell.com> <20210629124743.6898-5-pkushwaha@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210629124743.6898-5-pkushwaha@marvell.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210701_063603_111442_0049A2DE X-CRM114-Status: UNSURE ( 9.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > + mutex_lock(&nvme_tcp_ofld_devices_mutex); > + list_for_each_entry(dev, &nvme_tcp_ofld_devices, entry) { > + /* ctrl includes the destination ip, source ip (if provided) and > + * network interface (if provided). > + */ This is not the normal kernel comment style, and also incorrectly indented. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme