From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE825C11F64 for ; Thu, 1 Jul 2021 18:41:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C98856140E for ; Thu, 1 Jul 2021 18:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbhGASoB (ORCPT ); Thu, 1 Jul 2021 14:44:01 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:39879 "EHLO mail-wr1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232274AbhGASoB (ORCPT ); Thu, 1 Jul 2021 14:44:01 -0400 Received: by mail-wr1-f49.google.com with SMTP id f14so9086139wrs.6 for ; Thu, 01 Jul 2021 11:41:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3A0WFDmPSkEnA9X/4ve6FTVtpahIWIf1L85Qsi8H7qs=; b=SMFMtrhdq7DmkaBLDHp+PCsUj7KQu4CAIsypqsvvcDLeIhdhty1AMVOqseAuiw5Z2N uTFFkctnZTqTo2pss3dtiU4CLxztD4QzRrBNRc0nGyHvol3PtEhPYeqhiyg1/Dcb7Ev1 RN7EeqiGh8l0JXf/VaN/6om7hT7QDukultpg+Wk8SKCdiheqHtYh21upswmSycKIKQ5y NqUyDr0payeAT3kQz7KUzs19Vh0SjzZI5bIOcjb0gjj9OIBDQ+vBnSLc72hulyv1obVl tYWm5rl/tXt0LRg/RKyBzjDZMPy7qfrvdJAOrbWbFM9KBkkKUeS58czF/bNwWSlruz8r 4Etg== X-Gm-Message-State: AOAM533eBEhUoCjQXqCA6rQ49XRp5erxWb7MllwVhIFAoHh7NyhR6OVu irOQqRHBFLhfc61KDhK5ehI= X-Google-Smtp-Source: ABdhPJwD91OWvD3s99/HLidGAYhcr2TNAObtdeVVAPw/mlpVQdYQT5Kr8USe6LFUimK56/wpzyhT9w== X-Received: by 2002:a5d:688c:: with SMTP id h12mr1237342wru.11.1625164888877; Thu, 01 Jul 2021 11:41:28 -0700 (PDT) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id s1sm10195488wmj.8.2021.07.01.11.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 11:41:28 -0700 (PDT) Date: Thu, 1 Jul 2021 20:41:27 +0200 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Bjorn Helgaas Cc: Bjorn Helgaas , Scott Murray , linux-pci@vger.kernel.org Subject: Re: [PATCH] PCI: cpcihp: Move declaration of cpci_debug to the header file Message-ID: <20210701184127.GA297254@rocinante> References: <20210510024529.3221347-1-kw@linux.com> <20210701175639.GA73684@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210701175639.GA73684@bjorn-Precision-5520> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Bjorn, [...] > > --- a/drivers/pci/hotplug/cpci_hotplug_core.c > > +++ b/drivers/pci/hotplug/cpci_hotplug_core.c > > @@ -44,7 +44,6 @@ static DECLARE_RWSEM(list_rwsem); > > static LIST_HEAD(slot_list); > > static int slots; > > static atomic_t extracting; > > -int cpci_debug; > > We can add a declaration, but we still need a *definition* somewhere, > right? This is my bad! Sincere apologies. I will send a v2 that drops this hunk. This should have never been removed. Krzysztof