From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19DCC11F68 for ; Fri, 2 Jul 2021 12:18:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D71DB61427 for ; Fri, 2 Jul 2021 12:18:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232129AbhGBMUe (ORCPT ); Fri, 2 Jul 2021 08:20:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232111AbhGBMUZ (ORCPT ); Fri, 2 Jul 2021 08:20:25 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6F6DC061764 for ; Fri, 2 Jul 2021 05:17:53 -0700 (PDT) Date: Fri, 2 Jul 2021 14:17:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1625228271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GayRj68MxYlhLq1b72BYBOzpVTzkn6ZlV4tZ2wvOh7w=; b=Cw4KZ3DbM3XM9/ouqvqzAGiIhwYUuKq7vRGFxLVCC4rkOq5FsdkbVQvcNrJAiDRNmvzSsx C3EkL8+242kyNQcjdbKkYjjHcV02KYDavb2LIImrvfGznL28qXzkU0T3uiF+xJV3YF33NH pDrc2MY4w4olSuPBi1YS49DRnGDz8yE7Pha1+WzUzmaWoiR/aRKxSIndWzZ/X9EodY+97V qH3NvNga5USmwE2UNVeGAS3gco6AE5Nv2pJn4WvTZI50C0UnT/rg509YBRnnjnentFnJZG dj4r9ywKiH+UyrA+4r9xQmnprnTXUs+R4Hio/flljWXOo28e2102HqUcYLCEqQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1625228271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GayRj68MxYlhLq1b72BYBOzpVTzkn6ZlV4tZ2wvOh7w=; b=rflAF7uIIPZLISkwTB0wCO+VkyX7Cp4wKoawbaMXO9umI0hjececP3AtZm42aWNpDQHE/5 v+7iaxDNOgGn8yCg== From: Sebastian Andrzej Siewior To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Peter Zijlstra , Jann Horn Subject: Re: [RFC v2 31/34] mm, slub: optionally save/restore irqs in slab_[un]lock()/ Message-ID: <20210702121749.edrkrwf6uaxwoiyp@linutronix.de> References: <20210609113903.1421-1-vbabka@suse.cz> <20210609113903.1421-32-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210609113903.1421-32-vbabka@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-06-09 13:39:00 [+0200], Vlastimil Babka wrote: > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -353,18 +353,35 @@ static inline unsigned int oo_objects(struct kmem_cache_order_objects x) > /* > * Per slab locking using the pagelock > */ > -static __always_inline void slab_lock(struct page *page) > +static __always_inline void > +__slab_lock(struct page *page, unsigned long *flags, bool disable_irqs) > { > VM_BUG_ON_PAGE(PageTail(page), page); > + if (disable_irqs) > + local_irq_save(*flags); > bit_spin_lock(PG_locked, &page->flags); > } > > -static __always_inline void slab_unlock(struct page *page) > +static __always_inline void > +__slab_unlock(struct page *page, unsigned long *flags, bool disable_irqs) > { > VM_BUG_ON_PAGE(PageTail(page), page); > + if (disable_irqs) > + local_irq_restore(*flags); > __bit_spin_unlock(PG_locked, &page->flags); > } You should first unlock then enable IRQs. Sebastian