All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Alyssa Rosenzweig <alyssa@collabora.com>
Cc: Jason Ekstrand <jason@jlekstrand.net>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	dri-devel@lists.freedesktop.org,
	Steven Price <steven.price@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v2 4/7] drm/panfrost: Add the ability to create submit queues
Date: Fri, 2 Jul 2021 16:09:21 +0200	[thread overview]
Message-ID: <20210702160921.31fbe935@collabora.com> (raw)
In-Reply-To: <YN8bbhHA74joPggh@maud>

On Fri, 2 Jul 2021 09:58:06 -0400
Alyssa Rosenzweig <alyssa@collabora.com> wrote:

> > > My Vulkan knowledge is limited so I'm not sure whether this is the right
> > > approach or not. In particular is it correct that an application can
> > > create a high priority queue which could affect other (normal priority)
> > > applications?  
> > 
> > That's what msm does (with no extra CAPS check AFAICT), and the
> > freedreno driver can already create high priority queues if
> > PIPE_CONTEXT_HIGH_PRIORITY is passed. Not saying that's okay to allow
> > userspace to tweak the priority, but if that's a problem, other drivers
> > are in trouble too ;-).  
> 
> Speaking of, how will PIPE_CONTEXT_HIGH_PRIORITY be implemented with the
> new ioctl()? I envisioned something much simpler (for the old ioctl),
> just adding a "high priority?" flag to the submit and internally
> creating the two queues of normal/high priority for drm_sched to work
> out. Is this juggling now moved to userspace?

That's what freedreno does. I guess we could create 2 default queues
(one normal and one high prio) and extend the old submit ioctl() to do
what you suggest if you see a good reason to not switch to the new
ioctl() directly. I mean, we'll have to keep support for both anyway,
but switching to the new ioctl()) shouldn't be that hard (I can prepare
a MR transitioning the gallium driver to BATCH_SUBMIT if you want).

  reply	other threads:[~2021-07-02 14:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  9:12 [PATCH v2 0/7] drm/panfrost: drm/panfrost: Add a new submit ioctl Boris Brezillon
2021-07-01  9:12 ` [PATCH v2 1/7] drm/panfrost: Pass a job to panfrost_{acquire, attach_object_fences}() Boris Brezillon
2021-07-02  9:42   ` [PATCH v2 1/7] drm/panfrost: Pass a job to panfrost_{acquire,attach_object_fences}() Steven Price
2021-07-01  9:12 ` [PATCH v2 2/7] drm/panfrost: Move the mappings collection out of panfrost_lookup_bos() Boris Brezillon
2021-07-02  9:43   ` Steven Price
2021-07-01  9:12 ` [PATCH v2 3/7] drm/panfrost: Add BO access flags to relax dependencies between jobs Boris Brezillon
2021-07-02  9:45   ` Steven Price
2021-07-01  9:12 ` [PATCH v2 4/7] drm/panfrost: Add the ability to create submit queues Boris Brezillon
2021-07-02  9:56   ` Steven Price
2021-07-02 10:43     ` Boris Brezillon
2021-07-02 10:55       ` Steven Price
2021-07-02 11:02         ` Daniel Stone
2021-07-02 13:58       ` Alyssa Rosenzweig
2021-07-02 14:09         ` Boris Brezillon [this message]
2021-07-02 10:08   ` Steven Price
2021-07-02 10:52     ` Boris Brezillon
2021-07-02 10:58       ` Steven Price
2021-07-02 11:01         ` Boris Brezillon
2021-07-01  9:12 ` [PATCH v2 5/7] drm/panfrost: Add a new ioctl to submit batches Boris Brezillon
2021-07-02 10:08   ` Steven Price
2021-07-01  9:12 ` [PATCH v2 6/7] drm/panfrost: Advertise the SYNCOBJ_TIMELINE feature Boris Brezillon
2021-07-02 10:08   ` Steven Price
2021-07-01  9:12 ` [PATCH v2 7/7] drm/panfrost: Bump minor version to reflect the feature additions Boris Brezillon
2021-07-02 10:08   ` Steven Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210702160921.31fbe935@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=alyssa.rosenzweig@collabora.com \
    --cc=alyssa@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason@jlekstrand.net \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=steven.price@arm.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.