From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F2CC11F6A for ; Fri, 2 Jul 2021 16:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F421161427 for ; Fri, 2 Jul 2021 16:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230048AbhGBQdK (ORCPT ); Fri, 2 Jul 2021 12:33:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:44246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230036AbhGBQdK (ORCPT ); Fri, 2 Jul 2021 12:33:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BEDC261420; Fri, 2 Jul 2021 16:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625243437; bh=4dgTWLvBLZECreNmiOGo3p0spBZAJ1eEHQkFp7GpR+M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HPi7fFrMXN297XEApnQuvbP4NEnT1y8p+yphiF4JP5+LAigOk4oaD0bbtb3zkcxC+ 59+NzI8lKDAqZrpyqCTlZfc2ZiI3XMwVz7fak4LWwVPjrCfvvJRdouv/YxXP6UqW/d o7eZJhtYIxgErlwB7r3sBPNtIRAE1i9Jf/oYXzx3Dw2kIFLkb64t8iMlhhDA4szLFR t75/1xEPDrDtyH/lgnYKZuGZniIQ+H9BUGwNIuOzQ0+/9goENo+sytiLeGrMikrhM2 UpenQ/lZ/9M1KjrDhMwR425t/LfwkcIkrbMvnH9SIHWzq2OARhP2MUk+90vF7b9uJU zHwTp4/86O5kg== Received: by pali.im (Postfix) id 5540967D; Fri, 2 Jul 2021 18:30:35 +0200 (CEST) Date: Fri, 2 Jul 2021 18:30:35 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Jason Hung , Ken Ma , Victor Gu , Konstantin Porotchkin , Nadav Haklai Cc: Marek =?utf-8?B?QmVow7pu?= , Viresh Kumar , Gregory CLEMENT , Robert Marko , Tomasz Maciej Nowak , Anders Trier Olesen , Philip Soares , linux-pm@vger.kernel.org, Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, nnet Subject: Re: [PATCH v2] cpufreq: armada-37xx: forbid cpufreq for 1.2 GHz variant Message-ID: <20210702163035.nmb5pniwpqtmaz4b@pali> References: <20210630135942.29730-1-kabel@kernel.org> <20210630225601.6372-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210630225601.6372-1-kabel@kernel.org> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org +Jason from GlobalScale as this issue affects GlobalScale Espressobin Ultra and V7 1.2 GHz boards. On Thursday 01 July 2021 00:56:01 Marek Behún wrote: > The 1.2 GHz variant of the Armada 3720 SOC is unstable with DVFS: when > the SOC boots, the WTMI firmware sets clocks and AVS values that work > correctly with 1.2 GHz CPU frequency, but random crashes occur once > cpufreq driver starts scaling. > > We do not know currently what is the reason: > - it may be that the voltage value for L0 for 1.2 GHz variant provided > by the vendor in the OTP is simply incorrect when scaling is used, > - it may be that some delay is needed somewhere, > - it may be something else. > > The most sane solution now seems to be to simply forbid the cpufreq > driver on 1.2 GHz variant. > > Signed-off-by: Marek Behún > Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx") > --- > If someone from Marvell could look into this, it would be great since > basically 1.2 GHz variant cannot scale, which is a feature that was > claimed to be supported by the SOC. > > Ken Ma / Victor Gu, you have worked on commit > https://github.com/MarvellEmbeddedProcessors/linux-marvell/commit/d6719fdc2b3cac58064f41b531f86993c919aa9a > in linux-marvell. > Your patch takes away the 1202 mV constant for 1.2 GHz base CPU > frequency and instead adds code that computes the voltages from the > voltage found in L0 AVS register (which is filled in by WTMI firmware). > > Do you know why the code does not work correctly for some 1.2 GHz > boards? Do we need to force the L0 voltage to 1202 mV if it is lower, > or something? > --- > drivers/cpufreq/armada-37xx-cpufreq.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c > index 3fc98a3ffd91..c10fc33b29b1 100644 > --- a/drivers/cpufreq/armada-37xx-cpufreq.c > +++ b/drivers/cpufreq/armada-37xx-cpufreq.c > @@ -104,7 +104,11 @@ struct armada_37xx_dvfs { > }; > > static struct armada_37xx_dvfs armada_37xx_dvfs[] = { > - {.cpu_freq_max = 1200*1000*1000, .divider = {1, 2, 4, 6} }, > + /* > + * The cpufreq scaling for 1.2 GHz variant of the SOC is currently > + * unstable because we do not know how to configure it properly. > + */ > + /* {.cpu_freq_max = 1200*1000*1000, .divider = {1, 2, 4, 6} }, */ > {.cpu_freq_max = 1000*1000*1000, .divider = {1, 2, 4, 5} }, > {.cpu_freq_max = 800*1000*1000, .divider = {1, 2, 3, 4} }, > {.cpu_freq_max = 600*1000*1000, .divider = {2, 4, 5, 6} }, > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEAD0C11F68 for ; Fri, 2 Jul 2021 16:32:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6D7261410 for ; Fri, 2 Jul 2021 16:32:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6D7261410 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PcTzW4aQ2Bt9YSDPki+CfC3bbIa3bNRTS8L+PyBO9nc=; b=TcI7zRUBnnoDSg OnSND8bmnmh3Js2161YqJwRajAKhIFNw3N2Axb1+v7DP5WtykgzQyE7PXD2JfdUGVRy2itStEfzh8 2H223MKKSPB8Ozq8KkBoLp/vCb1ehZnVKz98zsUuAzOGQpp1p3kgi9xegVbJ/Q/74UWMEuzsXsE+R 5Bf+/vz/xt5ca5OvcBtVqO4tC3rq6dNtLJ9XT/wK5o9DJ8NZsDoajpKncCAQPJ1irgg+BVopE0WzQ y5sVlflYyTxFbt87wl5tCLjDIQflGIro3UVbqJo4qGesFG1EfrijxYN6kI6+yUmbOsxIrSXz3B50Y lvMzVpJZo3O2w4c8L4cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lzM3u-003Wyr-Qz; Fri, 02 Jul 2021 16:30:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lzM3q-003WyA-RG for linux-arm-kernel@lists.infradead.org; Fri, 02 Jul 2021 16:30:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BEDC261420; Fri, 2 Jul 2021 16:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625243437; bh=4dgTWLvBLZECreNmiOGo3p0spBZAJ1eEHQkFp7GpR+M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HPi7fFrMXN297XEApnQuvbP4NEnT1y8p+yphiF4JP5+LAigOk4oaD0bbtb3zkcxC+ 59+NzI8lKDAqZrpyqCTlZfc2ZiI3XMwVz7fak4LWwVPjrCfvvJRdouv/YxXP6UqW/d o7eZJhtYIxgErlwB7r3sBPNtIRAE1i9Jf/oYXzx3Dw2kIFLkb64t8iMlhhDA4szLFR t75/1xEPDrDtyH/lgnYKZuGZniIQ+H9BUGwNIuOzQ0+/9goENo+sytiLeGrMikrhM2 UpenQ/lZ/9M1KjrDhMwR425t/LfwkcIkrbMvnH9SIHWzq2OARhP2MUk+90vF7b9uJU zHwTp4/86O5kg== Received: by pali.im (Postfix) id 5540967D; Fri, 2 Jul 2021 18:30:35 +0200 (CEST) Date: Fri, 2 Jul 2021 18:30:35 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Jason Hung , Ken Ma , Victor Gu , Konstantin Porotchkin , Nadav Haklai Cc: Marek =?utf-8?B?QmVow7pu?= , Viresh Kumar , Gregory CLEMENT , Robert Marko , Tomasz Maciej Nowak , Anders Trier Olesen , Philip Soares , linux-pm@vger.kernel.org, Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, nnet Subject: Re: [PATCH v2] cpufreq: armada-37xx: forbid cpufreq for 1.2 GHz variant Message-ID: <20210702163035.nmb5pniwpqtmaz4b@pali> References: <20210630135942.29730-1-kabel@kernel.org> <20210630225601.6372-1-kabel@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210630225601.6372-1-kabel@kernel.org> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210702_093038_967186_06B33033 X-CRM114-Status: GOOD ( 30.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org K0phc29uIGZyb20gR2xvYmFsU2NhbGUgYXMgdGhpcyBpc3N1ZSBhZmZlY3RzIEdsb2JhbFNjYWxl IEVzcHJlc3NvYmluIFVsdHJhIGFuZCBWNyAxLjIgR0h6IGJvYXJkcy4KCk9uIFRodXJzZGF5IDAx IEp1bHkgMjAyMSAwMDo1NjowMSBNYXJlayBCZWjDum4gd3JvdGU6Cj4gVGhlIDEuMiBHSHogdmFy aWFudCBvZiB0aGUgQXJtYWRhIDM3MjAgU09DIGlzIHVuc3RhYmxlIHdpdGggRFZGUzogd2hlbgo+ IHRoZSBTT0MgYm9vdHMsIHRoZSBXVE1JIGZpcm13YXJlIHNldHMgY2xvY2tzIGFuZCBBVlMgdmFs dWVzIHRoYXQgd29yawo+IGNvcnJlY3RseSB3aXRoIDEuMiBHSHogQ1BVIGZyZXF1ZW5jeSwgYnV0 IHJhbmRvbSBjcmFzaGVzIG9jY3VyIG9uY2UKPiBjcHVmcmVxIGRyaXZlciBzdGFydHMgc2NhbGlu Zy4KPiAKPiBXZSBkbyBub3Qga25vdyBjdXJyZW50bHkgd2hhdCBpcyB0aGUgcmVhc29uOgo+IC0g aXQgbWF5IGJlIHRoYXQgdGhlIHZvbHRhZ2UgdmFsdWUgZm9yIEwwIGZvciAxLjIgR0h6IHZhcmlh bnQgcHJvdmlkZWQKPiAgIGJ5IHRoZSB2ZW5kb3IgaW4gdGhlIE9UUCBpcyBzaW1wbHkgaW5jb3Jy ZWN0IHdoZW4gc2NhbGluZyBpcyB1c2VkLAo+IC0gaXQgbWF5IGJlIHRoYXQgc29tZSBkZWxheSBp cyBuZWVkZWQgc29tZXdoZXJlLAo+IC0gaXQgbWF5IGJlIHNvbWV0aGluZyBlbHNlLgo+IAo+IFRo ZSBtb3N0IHNhbmUgc29sdXRpb24gbm93IHNlZW1zIHRvIGJlIHRvIHNpbXBseSBmb3JiaWQgdGhl IGNwdWZyZXEKPiBkcml2ZXIgb24gMS4yIEdIeiB2YXJpYW50Lgo+IAo+IFNpZ25lZC1vZmYtYnk6 IE1hcmVrIEJlaMO6biA8a2FiZWxAa2VybmVsLm9yZz4KPiBGaXhlczogOTJjZTQ1ZmI4NzVkICgi Y3B1ZnJlcTogQWRkIERWRlMgc3VwcG9ydCBmb3IgQXJtYWRhIDM3eHgiKQo+IC0tLQo+IElmIHNv bWVvbmUgZnJvbSBNYXJ2ZWxsIGNvdWxkIGxvb2sgaW50byB0aGlzLCBpdCB3b3VsZCBiZSBncmVh dCBzaW5jZQo+IGJhc2ljYWxseSAxLjIgR0h6IHZhcmlhbnQgY2Fubm90IHNjYWxlLCB3aGljaCBp cyBhIGZlYXR1cmUgdGhhdCB3YXMKPiBjbGFpbWVkIHRvIGJlIHN1cHBvcnRlZCBieSB0aGUgU09D Lgo+IAo+IEtlbiBNYSAvIFZpY3RvciBHdSwgeW91IGhhdmUgd29ya2VkIG9uIGNvbW1pdAo+IGh0 dHBzOi8vZ2l0aHViLmNvbS9NYXJ2ZWxsRW1iZWRkZWRQcm9jZXNzb3JzL2xpbnV4LW1hcnZlbGwv Y29tbWl0L2Q2NzE5ZmRjMmIzY2FjNTgwNjRmNDFiNTMxZjg2OTkzYzkxOWFhOWEKPiBpbiBsaW51 eC1tYXJ2ZWxsLgo+IFlvdXIgcGF0Y2ggdGFrZXMgYXdheSB0aGUgMTIwMiBtViBjb25zdGFudCBm b3IgMS4yIEdIeiBiYXNlIENQVQo+IGZyZXF1ZW5jeSBhbmQgaW5zdGVhZCBhZGRzIGNvZGUgdGhh dCBjb21wdXRlcyB0aGUgdm9sdGFnZXMgZnJvbSB0aGUKPiB2b2x0YWdlIGZvdW5kIGluIEwwIEFW UyByZWdpc3RlciAod2hpY2ggaXMgZmlsbGVkIGluIGJ5IFdUTUkgZmlybXdhcmUpLgo+IAo+IERv IHlvdSBrbm93IHdoeSB0aGUgY29kZSBkb2VzIG5vdCB3b3JrIGNvcnJlY3RseSBmb3Igc29tZSAx LjIgR0h6Cj4gYm9hcmRzPyBEbyB3ZSBuZWVkIHRvIGZvcmNlIHRoZSBMMCB2b2x0YWdlIHRvIDEy MDIgbVYgaWYgaXQgaXMgbG93ZXIsCj4gb3Igc29tZXRoaW5nPwo+IC0tLQo+ICBkcml2ZXJzL2Nw dWZyZXEvYXJtYWRhLTM3eHgtY3B1ZnJlcS5jIHwgNiArKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQs IDUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2NwdWZyZXEvYXJtYWRhLTM3eHgtY3B1ZnJlcS5jIGIvZHJpdmVycy9jcHVmcmVxL2FybWFkYS0z N3h4LWNwdWZyZXEuYwo+IGluZGV4IDNmYzk4YTNmZmQ5MS4uYzEwZmMzM2IyOWIxIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvY3B1ZnJlcS9hcm1hZGEtMzd4eC1jcHVmcmVxLmMKPiArKysgYi9kcml2 ZXJzL2NwdWZyZXEvYXJtYWRhLTM3eHgtY3B1ZnJlcS5jCj4gQEAgLTEwNCw3ICsxMDQsMTEgQEAg c3RydWN0IGFybWFkYV8zN3h4X2R2ZnMgewo+ICB9Owo+ICAKPiAgc3RhdGljIHN0cnVjdCBhcm1h ZGFfMzd4eF9kdmZzIGFybWFkYV8zN3h4X2R2ZnNbXSA9IHsKPiAtCXsuY3B1X2ZyZXFfbWF4ID0g MTIwMCoxMDAwKjEwMDAsIC5kaXZpZGVyID0gezEsIDIsIDQsIDZ9IH0sCj4gKwkvKgo+ICsJICog VGhlIGNwdWZyZXEgc2NhbGluZyBmb3IgMS4yIEdIeiB2YXJpYW50IG9mIHRoZSBTT0MgaXMgY3Vy cmVudGx5Cj4gKwkgKiB1bnN0YWJsZSBiZWNhdXNlIHdlIGRvIG5vdCBrbm93IGhvdyB0byBjb25m aWd1cmUgaXQgcHJvcGVybHkuCj4gKwkgKi8KPiArCS8qIHsuY3B1X2ZyZXFfbWF4ID0gMTIwMCox MDAwKjEwMDAsIC5kaXZpZGVyID0gezEsIDIsIDQsIDZ9IH0sICovCj4gIAl7LmNwdV9mcmVxX21h eCA9IDEwMDAqMTAwMCoxMDAwLCAuZGl2aWRlciA9IHsxLCAyLCA0LCA1fSB9LAo+ICAJey5jcHVf ZnJlcV9tYXggPSA4MDAqMTAwMCoxMDAwLCAgLmRpdmlkZXIgPSB7MSwgMiwgMywgNH0gfSwKPiAg CXsuY3B1X2ZyZXFfbWF4ID0gNjAwKjEwMDAqMTAwMCwgIC5kaXZpZGVyID0gezIsIDQsIDUsIDZ9 IH0sCj4gLS0gCj4gMi4zMS4xCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==