From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
Olaf Hering <olaf@aepfle.de>
Subject: [PATCH] tools/libxenguest: Fix migration's debug option
Date: Fri, 2 Jul 2021 20:03:42 +0100 [thread overview]
Message-ID: <20210702190342.31319-1-andrew.cooper3@citrix.com> (raw)
The code has gone through many refactors, but the first refactor was the one
which broke it by inverting the check with respect to checkpointed streams.
Fixes: 7449fb36c6c8 ("migration/save: pass checkpointed_stream from libxl to libxc")
Reported-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Ian Jackson <iwj@xenproject.org>
CC: Wei Liu <wl@xen.org>
CC: Olaf Hering <olaf@aepfle.de>
`xl migrate --debug` might not be perfect, but this at least brings it back to
mostly working.
I don't think dropping it is a sensible move. In particular, it is invaluable
for testing the logdirty infrastructure when migrating a memtest VM.
If anyone has a clever idea to fix the grant problem, then we can. It is
after all a debug option, without any specific prescribed behaviour.
---
tools/libs/guest/xg_sr_save.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libs/guest/xg_sr_save.c b/tools/libs/guest/xg_sr_save.c
index 2ba7c3200cd5..f0e2bd048d37 100644
--- a/tools/libs/guest/xg_sr_save.c
+++ b/tools/libs/guest/xg_sr_save.c
@@ -752,7 +752,7 @@ static int send_domain_memory_live(struct xc_sr_context *ctx)
if ( rc )
goto out;
- if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN )
+ if ( ctx->save.debug && ctx->stream_type == XC_STREAM_PLAIN )
{
rc = verify_frames(ctx);
if ( rc )
--
2.11.0
next reply other threads:[~2021-07-02 19:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 19:03 Andrew Cooper [this message]
2021-07-05 7:53 ` [PATCH] tools/libxenguest: Fix migration's debug option Olaf Hering
2021-07-05 7:57 ` Jan Beulich
2021-07-05 8:02 ` Olaf Hering
2021-07-05 8:23 ` Jan Beulich
2021-07-05 8:32 ` Olaf Hering
2021-07-05 9:19 ` Jan Beulich
2021-07-05 9:25 ` Olaf Hering
2021-07-05 9:31 ` Jan Beulich
2021-07-05 10:06 ` Andrew Cooper
2021-07-05 10:36 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702190342.31319-1-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=iwj@xenproject.org \
--cc=olaf@aepfle.de \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.