From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF9D5C07E95 for ; Fri, 2 Jul 2021 23:10:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B50361416 for ; Fri, 2 Jul 2021 23:10:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B50361416 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E48AF81D48; Sat, 3 Jul 2021 01:10:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="lhF9u3e1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5D27D82959; Sat, 3 Jul 2021 01:10:33 +0200 (CEST) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8020D814A4 for ; Sat, 3 Jul 2021 01:10:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id g12so7848501qtb.2 for ; Fri, 02 Jul 2021 16:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qqdiLdsmcP1cXb0l3HYTp6m6xxCUz04RpVCpoviKTFI=; b=lhF9u3e17i/J31LHI5R9pw2gXbcaIqZitvhKpuZ0I8mLiqwA5s6UQIAwdFUyakx5EL xeXyeV2yVyVdnVoAqV5UCldG9azOBeUWrOmKBUu30nAMvynpEYkguWOzTFa3ny9osCpW VDMLA4FIEWFCLmrTZyscxPEQtCg/6UYDo6wrA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qqdiLdsmcP1cXb0l3HYTp6m6xxCUz04RpVCpoviKTFI=; b=C7A5v5GWRhYxwXbPAsVTdK93AjjKXPZevwiHt90N8Sjbmkhb3crl8F8eQpURHo0/lT B/l5YvnJUwP9hPF6/GBzsTaC4rzg93PRe/G0dkBPw/ZDKRmc0o2A1r5kgeebIdjh9lEu aqlBOEWgqrgNykofFowUVBkU/Qzi7B/pf+hOtJwaD/sO5EpXGEpfrxm8Ww3p1EAeHAiI 0D/ZN8wtu4X1qUmJbzy/DnJLlAVGMuqfr08jZsH++mNSErHKcxkVVyzytrpIA3Ui0Mk8 xmQGqWrLR6sBEVclaR6BKY3SvcUfmfIxehIdk9Tq6UWQMZeutuoIx4TAJfH1cah1OJow 7efA== X-Gm-Message-State: AOAM530zAHSQMhjgqX0srsOQJDXEqi/Uhj/5hrzwbpbaIlMspSj0AB0j s6GJEl/9W1GJGJ5hxEK/Ga7TXg== X-Google-Smtp-Source: ABdhPJxm2ZUbTwquWdg8wgFszQB3tp6nz7SbOBZ20W+T4dQO5xnDybunkgz1tOHbQ0EKkJMfBuEuXw== X-Received: by 2002:ac8:108a:: with SMTP id a10mr2157461qtj.14.1625267429210; Fri, 02 Jul 2021 16:10:29 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-447a-194c-2139-e81a.res6.spectrum.com. [2603:6081:7b01:cbda:447a:194c:2139:e81a]) by smtp.gmail.com with ESMTPSA id 7sm1769077qtx.33.2021.07.02.16.10.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Jul 2021 16:10:28 -0700 (PDT) Date: Fri, 2 Jul 2021 19:10:26 -0400 From: Tom Rini To: Marek Vasut Cc: Neil Armstrong , Da Xue , U-Boot Mailing List , u-boot-amlogic@groups.io, Patrick DELAUNAY Subject: Re: [PATCH] configs: libretech: set SPI mode to 0 Message-ID: <20210702231026.GJ9516@bill-the-cat> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4CMzttJgPrTcc+bX" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --4CMzttJgPrTcc+bX Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 03, 2021 at 12:26:51AM +0200, Marek Vasut wrote: > On 7/3/21 12:01 AM, Neil Armstrong wrote: >=20 > [...] >=20 > > > diff --git a/configs/libretech-s912-pc_defconfig b/configs/libretech-= s912-pc_defconfig > > > index e2faea6242..669f000f7f 100644 > > > --- a/configs/libretech-s912-pc_defconfig > > > +++ b/configs/libretech-s912-pc_defconfig > > > @@ -35,6 +35,7 @@ CONFIG_SARADC_MESON=3Dy > > > =A0CONFIG_MMC_MESON_GX=3Dy > > > =A0CONFIG_MTD=3Dy > > > =A0CONFIG_DM_SPI_FLASH=3Dy > > > +CONFIG_SF_DEFAULT_MODE=3D0x0 > > > =A0CONFIG_SPI_FLASH_GIGADEVICE=3Dy > > > =A0CONFIG_PHY_REALTEK=3Dy > > > =A0CONFIG_DM_ETH=3Dy > > > --=20 > > > 2.30.2 > > >=20 > > >=20 > >=20 > > Thanks, > > Applying to u-boot-amlogic & sending PR to have it in this release >=20 > I have a feeling the real fix would be to revisit >=20 > 14453fbfad ("Convert CONFIG_SF_DEFAULT_* to Kconfig") >=20 > change the default mode to 0 in Kconfig and fix up the few boards which u= se > SPI mode 3 . >=20 > But that can wait after the release, since I think most of the board conf= igs > did get updated with SF_DEFAULT_MODE=3D0 config. CCing Patrick. So, lets do a little forensic work. Stepping back to 14453fbfad and none of the broken but fixed here boards existed. So, picking on configs/libretech-cc_v2_defconfig for a minute, ade0100a9162 introduced that board and.. it wasn't setting SF_DEFAULT_MODE anywhere. Digging around a bit more right now, I don't see meson platforms setting that value anywhere, ever (and aside, I see a few config.h files that need a kick right now, sigh). That means it was getting the default of SPI_MODE_3. Which means, are there other platforms that were using the default before, but needed to really be using something else and e2e95e5e2542 should have waited? I'm not sure. Does that also mean that other amlogic platforms need a change here? Not sure if my le potato would show the problem off-hand. --=20 Tom --4CMzttJgPrTcc+bX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDfnNgACgkQFHw5/5Y0 tywQIwv9GCyjUsHqq/cOoHneEDrKR+vho/8Gpj/w1pTk/S/f6FV/dnIATzyJQ6gg Cx1qU1w+9GPq74FGUaOShBZ79TRJG/SdJ4dUXnxdwtUhkCxRfuVs40U599TbKL47 6600z06rQpzXeLAk2li2NDX8tCW7J2/bS8hohv+32WT0Qzwy6dstXzM4Dvn50WkT YAqqAQxSg7NYfCfbN82nCNpsBWy0hPlST4hDiaWdbaFixhBCVyjC6vjbwz1GKGBf mW5bNlpOLOjBH36HawRl5woNoBgKva418eoC3ESZsGOH9wx0r+0lU4t58Kp6YcPK v+jvZpYDC9cdqFvQa2FfG7JbELoZAVRhalVXKyJ85dxEG0soJvE7pdce1cpKGHUv KRm+7nilIo6q4sKx3B2rFblxdVWBPZhf5PJtccyWVO6LPJN7ciDYPKo6JzPDmGhn lHJGNFUuYIOKTMfEOYFPWhLDfxZ2G0GNnaMXVjRYTjuZFlK1YESdBo21L7uzubbe cu6fTx1u =/pMP -----END PGP SIGNATURE----- --4CMzttJgPrTcc+bX--