[PATCH] update-rc.d: Fix enable/disable command

[PATCH] update-rc.d: Fix enable/disable command

[Einar Gunnarsson]

$[] is a bashism and does not work on POSIX shells.

enable/disable on links numbered 08 and 09 gave the error:
'bash: 100-08: value too great for base (error token is "08")'
Links numbered 91-99 created a single digit link.

Links numbered 91 or higher now create a double digit link
with a leading zero.

Signed-off-by: Einar Gunnarsson <tolvupostur@gmail.com>
---
 update-rc.d | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/update-rc.d b/update-rc.d
index c9355d7..95d1c22 100644
--- a/update-rc.d
+++ b/update-rc.d
@@ -114,7 +114,7 @@ renamelink()
         # or stop link to start link with a sequence number equal to the difference of 100 minus the original sequence number.
 	if ls ${etcd}${lev}.d/${oldstartstop}*${bn} >/dev/null 2>&1; then
 		oldnn=`basename ${etcd}${lev}.d/${oldstartstop}*${bn}|cut -c2-3`
-		newnn=$[100-$oldnn]
+		newnn=$(printf "%02d" $((100-${oldnn#0})))
 		[ $verbose -eq 1 ] && echo "rename ${etcd}${lev}.d/${oldstartstop}${oldnn}${bn} -> ${etcd}${lev}.d/${newstartstop}${newnn}${bn}"
 		if [ $notreally -eq 0 ];then
 			mv ${etcd}${lev}.d/${oldstartstop}${oldnn}${bn} ${etcd}${lev}.d/${newstartstop}${newnn}${bn}
-- 
2.17.1

Re: [OE-core] [PATCH] update-rc.d: Fix enable/disable command

[Alexandre Belloni]

Hello,

This was actually applied on saturday:
https://git.yoctoproject.org/cgit/cgit.cgi/update-rc.d/commit/?id=8636cf478d426b568c1be11dbd9346f67e03adac

On 05/07/2021 09:07:40+0200, Einar Gunnarsson wrote:
> $[] is a bashism and does not work on POSIX shells.
> 
> enable/disable on links numbered 08 and 09 gave the error:
> 'bash: 100-08: value too great for base (error token is "08")'
> Links numbered 91-99 created a single digit link.
> 
> Links numbered 91 or higher now create a double digit link
> with a leading zero.
> 
> Signed-off-by: Einar Gunnarsson <tolvupostur@gmail.com>
> ---
>  update-rc.d | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/update-rc.d b/update-rc.d
> index c9355d7..95d1c22 100644
> --- a/update-rc.d
> +++ b/update-rc.d
> @@ -114,7 +114,7 @@ renamelink()
>          # or stop link to start link with a sequence number equal to the difference of 100 minus the original sequence number.
>  	if ls ${etcd}${lev}.d/${oldstartstop}*${bn} >/dev/null 2>&1; then
>  		oldnn=`basename ${etcd}${lev}.d/${oldstartstop}*${bn}|cut -c2-3`
> -		newnn=$[100-$oldnn]
> +		newnn=$(printf "%02d" $((100-${oldnn#0})))
>  		[ $verbose -eq 1 ] && echo "rename ${etcd}${lev}.d/${oldstartstop}${oldnn}${bn} -> ${etcd}${lev}.d/${newstartstop}${newnn}${bn}"
>  		if [ $notreally -eq 0 ];then
>  			mv ${etcd}${lev}.d/${oldstartstop}${oldnn}${bn} ${etcd}${lev}.d/${newstartstop}${newnn}${bn}
> -- 
> 2.17.1
> 

> 
> 
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com