From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7524C07E98 for ; Mon, 5 Jul 2021 07:55:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C06CD613B2 for ; Mon, 5 Jul 2021 07:55:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230000AbhGEH61 (ORCPT ); Mon, 5 Jul 2021 03:58:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229993AbhGEH61 (ORCPT ); Mon, 5 Jul 2021 03:58:27 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C924C061574 for ; Mon, 5 Jul 2021 00:55:50 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0JSG-0008Ea-IW; Mon, 05 Jul 2021 09:55:48 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1m0JSF-0008GR-Jr; Mon, 05 Jul 2021 09:55:47 +0200 Date: Mon, 5 Jul 2021 09:55:47 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Thierry Reding Cc: Claudiu Beznea , Lee Jones , linux-pwm@vger.kernel.org, Alexandre Belloni , Nicolas Ferre , Ludovic Desroches , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] pwm: atmel: rework tracking updates pending in hardware Message-ID: <20210705075547.5feystwquxamsxfr@pengutronix.de> References: <20210420095118.1571344-1-u.kleine-koenig@pengutronix.de> <20210421092606.1634092-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7nxk2ybyfax6hjmm" Content-Disposition: inline In-Reply-To: <20210421092606.1634092-1-u.kleine-koenig@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pwm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org --7nxk2ybyfax6hjmm Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Thierry, On Wed, Apr 21, 2021 at 11:26:08AM +0200, Uwe Kleine-K=F6nig wrote: > This improves the driver's behavior in several ways: >=20 > - The lock is held for shorter periods and so a channel that is currently > waited for doesn't block disabling another channel. >=20 > - It's easier to understand because the procedure is split into more > semantic units and documentation is improved >=20 > - A channel is only set to pending when such an event is actually > scheduled in hardware (by writing the CUPD register). >=20 > - Also wait in .get_state() to report the last configured state instead > of (maybe) the previous one. This fixes the read back duty cycle and so > prevents a warning being emitted when PWM_DEBUG is on. >=20 > Tested on an AriettaG25. On patchwork this patch is in the state "Under Review". Did you change this? What does this mean? Does indeed someone look into this patch? There was some discussion in reply to this patch, but that doesn't affect correctness of it. It's just that there are still some problems in the driver that this patch doesn't address, but the net effect of it is still positive. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --7nxk2ybyfax6hjmm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmDiuwAACgkQwfwUeK3K 7Am0/Qf7BhFqMhXjrRiezuusvjGedrMWLDnIIljBPAer6shGZW6mcyvING5Bnthh 8sRB8ZCdXzpkX18FU1uEUghwY0k0aRiMdmzx7SKCm91rOUJVmkZw/vYwvSjTfc4C Zow/jYPKzDXOmkWtwwgONcpzWyHPAqUilAoJQ16/C3d047i5qXe5ReWPLPr2gGmf kxIJVWx4JWbpg4K5ubuOvebd9LmX71UYQFZwCTvUMILl0Ttbmahhjba4tLtz65U7 npwl7kUIYhOu/4DV3uHYYTRQKjMNxcZAUswpHvYbwk3dUXoZ0ABHBelIHGXDozs8 YF8d7ZW24is+tK/yCwkdxVTusejBAg== =gCff -----END PGP SIGNATURE----- --7nxk2ybyfax6hjmm-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF57C07E98 for ; Mon, 5 Jul 2021 07:57:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02AF3613B2 for ; Mon, 5 Jul 2021 07:57:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02AF3613B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Pd4OAfbR/ThkzCF6Gwc4T+UEcYTsia1dNYXw+GicOzU=; b=Uy01cdeauot/bOUj+GPPeSFawm HNKOvYu7TwGTjaNIqhfQeg/Ek84eZBnpcMgUjKkJygXHHuEqsklKSWnwm7RU4X+ODpIOKrXWvFXSv 1k1WciqqterKM0ico7id5psIWvSPDMzfN6uDHYKo7awqjvOhNF5veDp/r5zqbaoL8K0SHsssjFKID maDvuFGfPnQReb26la/t/VfP7TPezwoS2lS6YtIBdavYBu+7jP8+KUBEjp1BZx7tAZr5tv1f6Tn4h EGtsYY60nnuBKaY+mGHfAaB5INoS2db7euwYICquLUndxfhHHjKDsZR3+iLwhDVR39dt7WNMrxfJw 95y++eig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0JSR-0089Kh-8z; Mon, 05 Jul 2021 07:55:59 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0JSN-0089K6-Ku for linux-arm-kernel@lists.infradead.org; Mon, 05 Jul 2021 07:55:57 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0JSG-0008Ea-IW; Mon, 05 Jul 2021 09:55:48 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1m0JSF-0008GR-Jr; Mon, 05 Jul 2021 09:55:47 +0200 Date: Mon, 5 Jul 2021 09:55:47 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Thierry Reding Subject: Re: [PATCH] pwm: atmel: rework tracking updates pending in hardware Message-ID: <20210705075547.5feystwquxamsxfr@pengutronix.de> References: <20210420095118.1571344-1-u.kleine-koenig@pengutronix.de> <20210421092606.1634092-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20210421092606.1634092-1-u.kleine-koenig@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210705_005555_733692_7DF3E051 X-CRM114-Status: GOOD ( 22.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Alexandre Belloni , Ludovic Desroches , kernel@pengutronix.de, Lee Jones , Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1201568805363830199==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1201568805363830199== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7nxk2ybyfax6hjmm" Content-Disposition: inline --7nxk2ybyfax6hjmm Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Thierry, On Wed, Apr 21, 2021 at 11:26:08AM +0200, Uwe Kleine-K=F6nig wrote: > This improves the driver's behavior in several ways: >=20 > - The lock is held for shorter periods and so a channel that is currently > waited for doesn't block disabling another channel. >=20 > - It's easier to understand because the procedure is split into more > semantic units and documentation is improved >=20 > - A channel is only set to pending when such an event is actually > scheduled in hardware (by writing the CUPD register). >=20 > - Also wait in .get_state() to report the last configured state instead > of (maybe) the previous one. This fixes the read back duty cycle and so > prevents a warning being emitted when PWM_DEBUG is on. >=20 > Tested on an AriettaG25. On patchwork this patch is in the state "Under Review". Did you change this? What does this mean? Does indeed someone look into this patch? There was some discussion in reply to this patch, but that doesn't affect correctness of it. It's just that there are still some problems in the driver that this patch doesn't address, but the net effect of it is still positive. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --7nxk2ybyfax6hjmm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmDiuwAACgkQwfwUeK3K 7Am0/Qf7BhFqMhXjrRiezuusvjGedrMWLDnIIljBPAer6shGZW6mcyvING5Bnthh 8sRB8ZCdXzpkX18FU1uEUghwY0k0aRiMdmzx7SKCm91rOUJVmkZw/vYwvSjTfc4C Zow/jYPKzDXOmkWtwwgONcpzWyHPAqUilAoJQ16/C3d047i5qXe5ReWPLPr2gGmf kxIJVWx4JWbpg4K5ubuOvebd9LmX71UYQFZwCTvUMILl0Ttbmahhjba4tLtz65U7 npwl7kUIYhOu/4DV3uHYYTRQKjMNxcZAUswpHvYbwk3dUXoZ0ABHBelIHGXDozs8 YF8d7ZW24is+tK/yCwkdxVTusejBAg== =gCff -----END PGP SIGNATURE----- --7nxk2ybyfax6hjmm-- --===============1201568805363830199== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1201568805363830199==--