All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] math: Make RATIONAL tristate
@ 2021-07-05 11:46 Geert Uytterhoeven
  2021-07-05 14:53 ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-07-05 11:46 UTC (permalink / raw)
  To: Trent Piepho, Colin Ian King, Andy Shevchenko, Andrew Morton,
	Brendan Higgins
  Cc: linux-kselftest, kunit-dev, linux-kernel, Geert Uytterhoeven

All but one symbols that select RATIONAL are tristate, but RATIONAL
itself is bool.  Change it to tristate, so the rational fractions
support code can be modular if no builtin code relies on it.

While at it, add support for compile-testing and provide a help text.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Exposed by commit b6c75c4afceb8bc0 ("lib/math/rational: add Kunit test
cases") and CONFIG_KUNIT_ALL_TESTS=m.

I'm not so happy RATIONAL_KUNIT_TEST selects RATIONAL, as test code
should depend on the presence of the feature to test.  Else enabling
a test may add unneeded code to a production kernel.
Perhaps the "if COMPILE_TEST" should be dropped, making RATIONAL
visible, so RATIONAL_KUNIT_TEST can depend on RATIONAL instead?
---
 lib/math/Kconfig    | 5 ++++-
 lib/math/rational.c | 3 +++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/lib/math/Kconfig b/lib/math/Kconfig
index f19bc9734fa7cc4b..14def252ea7db6e0 100644
--- a/lib/math/Kconfig
+++ b/lib/math/Kconfig
@@ -14,4 +14,7 @@ config PRIME_NUMBERS
 	  If unsure, say N.
 
 config RATIONAL
-	bool
+	tristate "Rational fractions support" if COMPILE_TEST
+	help
+	  This option provides support for rational fractions.
+	  This symbol should be selected automatically by drivers that need it.
diff --git a/lib/math/rational.c b/lib/math/rational.c
index c0ab51d8fbb98d17..ec59d426ea638b0f 100644
--- a/lib/math/rational.c
+++ b/lib/math/rational.c
@@ -13,6 +13,7 @@
 #include <linux/export.h>
 #include <linux/minmax.h>
 #include <linux/limits.h>
+#include <linux/module.h>
 
 /*
  * calculate best rational approximation for a given fraction
@@ -106,3 +107,5 @@ void rational_best_approximation(
 }
 
 EXPORT_SYMBOL(rational_best_approximation);
+
+MODULE_LICENSE("GPL v2");
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] math: Make RATIONAL tristate
  2021-07-05 11:46 [PATCH] math: Make RATIONAL tristate Geert Uytterhoeven
@ 2021-07-05 14:53 ` Andy Shevchenko
  2021-07-06  7:14   ` Geert Uytterhoeven
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2021-07-05 14:53 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Trent Piepho, Colin Ian King, Andrew Morton, Brendan Higgins,
	linux-kselftest, kunit-dev, linux-kernel

On Mon, Jul 05, 2021 at 01:46:33PM +0200, Geert Uytterhoeven wrote:
> All but one symbols that select RATIONAL are tristate, but RATIONAL
> itself is bool.  Change it to tristate, so the rational fractions
> support code can be modular if no builtin code relies on it.
> 
> While at it, add support for compile-testing and provide a help text.

...

> Exposed by commit b6c75c4afceb8bc0 ("lib/math/rational: add Kunit test
> cases") and CONFIG_KUNIT_ALL_TESTS=m.
> 
> I'm not so happy RATIONAL_KUNIT_TEST selects RATIONAL, as test code
> should depend on the presence of the feature to test.  Else enabling
> a test may add unneeded code to a production kernel.
> Perhaps the "if COMPILE_TEST" should be dropped, making RATIONAL
> visible, so RATIONAL_KUNIT_TEST can depend on RATIONAL instead?

...

> +	tristate "Rational fractions support" if COMPILE_TEST

Making it tristate is okay, but visible (even for COMPILE_TEST)... why?
Just on purpose to be dependent on for test case? I understand your
justification above, but it will bring all hidden symbols to be unhidden
(due to test cases) and this is not the right thing to do in my opinion.

Why not to complain to KUnit people to fix their infra to avoid tests that
tries non-selected feature(s)?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] math: Make RATIONAL tristate
  2021-07-05 14:53 ` Andy Shevchenko
@ 2021-07-06  7:14   ` Geert Uytterhoeven
  0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-07-06  7:14 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Trent Piepho, Colin Ian King, Andrew Morton, Brendan Higgins,
	open list:KERNEL SELFTEST FRAMEWORK, kunit-dev,
	Linux Kernel Mailing List

Hi Andy,

On Mon, Jul 5, 2021 at 4:53 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Mon, Jul 05, 2021 at 01:46:33PM +0200, Geert Uytterhoeven wrote:
> > All but one symbols that select RATIONAL are tristate, but RATIONAL
> > itself is bool.  Change it to tristate, so the rational fractions
> > support code can be modular if no builtin code relies on it.
> >
> > While at it, add support for compile-testing and provide a help text.
>
> ...
>
> > Exposed by commit b6c75c4afceb8bc0 ("lib/math/rational: add Kunit test
> > cases") and CONFIG_KUNIT_ALL_TESTS=m.
> >
> > I'm not so happy RATIONAL_KUNIT_TEST selects RATIONAL, as test code
> > should depend on the presence of the feature to test.  Else enabling
> > a test may add unneeded code to a production kernel.
> > Perhaps the "if COMPILE_TEST" should be dropped, making RATIONAL
> > visible, so RATIONAL_KUNIT_TEST can depend on RATIONAL instead?
>
> ...
>
> > +     tristate "Rational fractions support" if COMPILE_TEST
>
> Making it tristate is okay, but visible (even for COMPILE_TEST)... why?
> Just on purpose to be dependent on for test case? I understand your
> justification above, but it will bring all hidden symbols to be unhidden
> (due to test cases) and this is not the right thing to do in my opinion.

OK.  Will drop in v2.

> Why not to complain to KUnit people to fix their infra to avoid tests that
> tries non-selected feature(s)?

I guess the audience is listening...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-06  7:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-05 11:46 [PATCH] math: Make RATIONAL tristate Geert Uytterhoeven
2021-07-05 14:53 ` Andy Shevchenko
2021-07-06  7:14   ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.