From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BDF6C07E99 for ; Mon, 5 Jul 2021 11:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1AE89613C8 for ; Mon, 5 Jul 2021 11:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231193AbhGEL43 (ORCPT ); Mon, 5 Jul 2021 07:56:29 -0400 Received: from verein.lst.de ([213.95.11.211]:56725 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230174AbhGEL42 (ORCPT ); Mon, 5 Jul 2021 07:56:28 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B8CC268B05; Mon, 5 Jul 2021 13:53:49 +0200 (CEST) Date: Mon, 5 Jul 2021 13:53:49 +0200 From: Christoph Hellwig To: "Shivamurthy Shastri (sshivamurthy)" Cc: Christoph Hellwig , "kbusch@kernel.org" , "axboe@fb.com" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "shiva.linuxworks@gmail.com" Subject: Re: [EXT] Re: [PATCH] nvme: Add abrupt shutdown support Message-ID: <20210705115349.GA20266@lst.de> References: <20210705101157.1009135-1-sshivamurthy@micron.com> <20210705101554.GA12803@lst.de> <20210705104208.GA14891@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 05, 2021 at 11:15:51AM +0000, Shivamurthy Shastri (sshivamurthy) wrote: > For systems with passive electronic components to handle power-loss/battery-removal, > CC.SHN=10b will help to achieve safer shutdown with relatively lower power back-up > requirements (at lower cost). > > The module parameter gives flexibility to the host to decide shutdown type even during > boot failure. If you have a device that always prefers an abrupt please introduce a TP in the NVMe technical working group so that the hosts automatically do the right thing. Requiring sysadmin intervention using a global kernel parameter is not the way to do this. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D7DC07E99 for ; Mon, 5 Jul 2021 11:54:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78B2E61261 for ; Mon, 5 Jul 2021 11:54:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78B2E61261 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Oi13wavfK/6iDEWV1Hu2GtELf5hya+rrum+i/GDgqBA=; b=HK0a3upt2Llt0j UABoOKkZ3vuPHug/LXUqumgoB0EkId/V6OvduWxGcAN88p2bGhlQIUKP8dA3JZ0Rp2iqOxYm0qKvk XVdlbwgjmwBK0qrxG71hOXfshywo556l1aHcJ76rtyk9mS11RTgWi2nfboBUikwMLPoGt+v25oKct GoyJtwmSniQT6s1/dkMiamI9ZEKeTT+isSNMXNvDQOrHWid/0zj2gEMJ8wPMQMukLziskylt1QTKw trzOIb74Gy4/dfdKw+K+czc7z4jI8pHyPDDOG9QK5T5ihFWEZT4ND8YnS4O/qdbCALTvFHGGXrs+t bk03W32rWznYAq01Bpiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0NAi-008rfp-1R; Mon, 05 Jul 2021 11:53:56 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0NAf-008rf7-B9 for linux-nvme@lists.infradead.org; Mon, 05 Jul 2021 11:53:54 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id B8CC268B05; Mon, 5 Jul 2021 13:53:49 +0200 (CEST) Date: Mon, 5 Jul 2021 13:53:49 +0200 From: Christoph Hellwig To: "Shivamurthy Shastri (sshivamurthy)" Cc: Christoph Hellwig , "kbusch@kernel.org" , "axboe@fb.com" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "shiva.linuxworks@gmail.com" Subject: Re: [EXT] Re: [PATCH] nvme: Add abrupt shutdown support Message-ID: <20210705115349.GA20266@lst.de> References: <20210705101157.1009135-1-sshivamurthy@micron.com> <20210705101554.GA12803@lst.de> <20210705104208.GA14891@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210705_045353_575352_C1A84731 X-CRM114-Status: GOOD ( 12.97 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Jul 05, 2021 at 11:15:51AM +0000, Shivamurthy Shastri (sshivamurthy) wrote: > For systems with passive electronic components to handle power-loss/battery-removal, > CC.SHN=10b will help to achieve safer shutdown with relatively lower power back-up > requirements (at lower cost). > > The module parameter gives flexibility to the host to decide shutdown type even during > boot failure. If you have a device that always prefers an abrupt please introduce a TP in the NVMe technical working group so that the hosts automatically do the right thing. Requiring sysadmin intervention using a global kernel parameter is not the way to do this. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme