From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CC15C07E9C for ; Mon, 5 Jul 2021 15:32:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 492A061997 for ; Mon, 5 Jul 2021 15:32:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232999AbhGEPfK (ORCPT ); Mon, 5 Jul 2021 11:35:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:58876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232003AbhGEPc7 (ORCPT ); Mon, 5 Jul 2021 11:32:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 69203619A1; Mon, 5 Jul 2021 15:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625499022; bh=m3zx+ceVEdckWgNJJueuh3O9BRsErHXlMTL9Bs9H3U8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hXUu9X0I3sBw84FUjlizgHpZ+E+wgVdn4CSCVztMLORe/mjIrGqwL1SuHZNwgbwa8 vWH8hOJtJYaDGXBhpanQKYVj3mkSMizIlmlqws9j9fLPy9Hh1htVe+kssgZSDvVRGY nZ2xJxu3/ITLZcx8D6wbIaIsdHA7/CwvI79q0II1eJlIcFhB2kMPDFvUDj5FZZuWMd IRKLLg1mK6wEKBz1DTtAX3q1smOhEOc+nQLqbGzI3BUO06bgoteiVEg1/vvOWdUCxb yT4ljfOksySZsdf80TnJ+Ms1UloFBGnldtgCr2Rdx5B1x69l0/ULcipk4uVHYaQcrB I2b41yCEFr6Eg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jiapeng Chong , Abaci Robot , Michael Kelley , Wei Liu , Sasha Levin , linux-hyperv@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 16/41] drivers: hv: Fix missing error code in vmbus_connect() Date: Mon, 5 Jul 2021 11:29:36 -0400 Message-Id: <20210705153001.1521447-16-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210705153001.1521447-1-sashal@kernel.org> References: <20210705153001.1521447-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiapeng Chong [ Upstream commit 9de6655cc5a6a1febc514465c87c24a0e96d8dba ] Eliminate the follow smatch warning: drivers/hv/connection.c:236 vmbus_connect() warn: missing error code 'ret'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/1621940321-72353-1-git-send-email-jiapeng.chong@linux.alibaba.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/connection.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c index 11170d9a2e1a..bfd7f00a59ec 100644 --- a/drivers/hv/connection.c +++ b/drivers/hv/connection.c @@ -229,8 +229,10 @@ int vmbus_connect(void) */ for (i = 0; ; i++) { - if (i == ARRAY_SIZE(vmbus_versions)) + if (i == ARRAY_SIZE(vmbus_versions)) { + ret = -EDOM; goto cleanup; + } version = vmbus_versions[i]; if (version > max_version) -- 2.30.2