From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAAA6C07E99 for ; Mon, 5 Jul 2021 16:51:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4496061278 for ; Mon, 5 Jul 2021 16:51:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4496061278 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0Ror-0005aF-9d for qemu-devel@archiver.kernel.org; Mon, 05 Jul 2021 12:51:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0Ro1-0004ZT-Vy for qemu-devel@nongnu.org; Mon, 05 Jul 2021 12:50:50 -0400 Received: from rev.ng ([5.9.113.41]:45461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0Rnz-0001Hm-PO for qemu-devel@nongnu.org; Mon, 05 Jul 2021 12:50:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0UiU2wkAztsZw4EQV4lRAOHZk6OxpSEDogjtsCWp+l4=; b=S0Rshek3g6tguBM/BAI1kxpqg/ kPpJlINU3ApYhiVG6zws0KCHsgoknx9fXTGSBdKVxbzLEnYJsuN8996Q2HW/tJE9mM7UDkpKEIG3i C1cN7Dxh2o3UIxRtJ4JQC5yT4BzKOGPq6C6U9ZZZgpiZ+AO64zY8/dxN8cUq3BQMkOQw=; Date: Mon, 5 Jul 2021 18:50:25 +0200 To: Taylor Simpson Cc: Alessandro Di Federico , qemu-devel@nongnu.org, tsimpson@quicinc.com, bcain@quicinc.com, babush@rev.ng, nizzo@rev.ng, philmd@redhat.com, richard.henderson@linaro.org Subject: Re: [PATCH v5 13/14] target/hexagon: import additional tests Message-ID: <20210705185025.3c430550@orange> In-Reply-To: References: <20210619093713.1845446-1-ale.qemu@rev.ng> <20210619093713.1845446-14-ale.qemu@rev.ng> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=5.9.113.41; envelope-from=ale@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Alessandro Di Federico From: Alessandro Di Federico via On Fri, 25 Jun 2021 18:56:57 -0500 Taylor Simpson wrote: > Each of these are very small, so I recommend putting them into misc.c > or combine all the assembly into a small number of executables. These tests are designed to run without libc and test in isolation very specific functionality making as little assumptions as possible about what instructions are working correctly. Now that we are mature enough it might not make much sense this approach, but starting from scratch (and also considering phase 2) they might be helpful. With some refactoring and ".include" directives I can probably make a single executable out of them, but it's not superelegant. For the rest, I've dropped several outdated comments and superflous tests. Thanks for looking into this. -- Alessandro Di Federico rev.ng