From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15713C07E9B for ; Mon, 5 Jul 2021 12:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E29F7610C7 for ; Mon, 5 Jul 2021 12:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231279AbhGEMGT (ORCPT ); Mon, 5 Jul 2021 08:06:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:44068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231159AbhGEMGS (ORCPT ); Mon, 5 Jul 2021 08:06:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A68B860241; Mon, 5 Jul 2021 12:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625486621; bh=SjTdmsxCPlxVFlvZvH52SfXXPq9CdpmxbJ1E9QcX+fs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y3eFVJeLa8O2Yfy8Gp3KwhyukvAPXPZwNZcsY6YAijHoPLWls/zBsDSTWgukWEajS nJVGNHxMuVtvSWrI/MVO7/jbbC6XImJZ/LNG17ZXUIemHPQziCFzLMV2R8sCx6x+n3 GK10H0854TeUAIULzi//RRV8lo7tdZ7x/xCoAyyZ8bfEghsXFgSmwnljbD3Kuwgs0P NBs6GWBo7ThEqJiEP6+YGNehbIhSS/WS1ZHC8LJKy8bpeMbgUOgAuZ+PNxMg3ecpiq NLXPr5jLlbc62a0bpHj/MuakB+GBnui128I0mZ7M7HmGIaBtTRKMXQ64e6R0oWCxPN YFB9TM6eZloGg== Date: Mon, 5 Jul 2021 21:03:36 +0900 From: Masami Hiramatsu To: Ingo Molnar Cc: Steven Rostedt , Josh Poimboeuf , X86 ML , Daniel Xu , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, kuba@kernel.org, mingo@redhat.com, ast@kernel.org, Thomas Gleixner , Borislav Petkov , Peter Zijlstra , kernel-team@fb.com, yhs@fb.com, linux-ia64@vger.kernel.org, Abhishek Sagar , Andrii Nakryiko Subject: Re: [PATCH -tip v8 02/13] kprobes: treewide: Replace arch_deref_entry_point() with dereference_symbol_descriptor() Message-Id: <20210705210336.8428fbf0e65deb1e437374f4@kernel.org> In-Reply-To: References: <162399992186.506599.8457763707951687195.stgit@devnote2> <162399994018.506599.10332627573727646767.stgit@devnote2> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Jul 2021 09:48:09 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > Replace arch_deref_entry_point() with dereference_symbol_descriptor() > > because those are doing same thing. > > > > Signed-off-by: Masami Hiramatsu > > Tested-by: Andrii Nakryik > > A better changelog: > > ~15 years ago kprobes grew the 'arch_deref_entry_point()' __weak function: > > 3d7e33825d87: ("jprobes: make jprobes a little safer for users") > > But this is just open-coded dereference_symbol_descriptor() in essence, and > its obscure nature was causing bugs. > > Just use the real thing. OK. BTW, I couldn't find actual bugs from it. What about this? "its obscure nature was causing problems in the past." Thank you, > > Thanks, > > Ingo -- Masami Hiramatsu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Date: Mon, 05 Jul 2021 12:03:36 +0000 Subject: Re: [PATCH -tip v8 02/13] kprobes: treewide: Replace arch_deref_entry_point() with dereference_symbo Message-Id: <20210705210336.8428fbf0e65deb1e437374f4@kernel.org> List-Id: References: <162399992186.506599.8457763707951687195.stgit@devnote2> <162399994018.506599.10332627573727646767.stgit@devnote2> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ingo Molnar Cc: Steven Rostedt , Josh Poimboeuf , X86 ML , Daniel Xu , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, kuba@kernel.org, mingo@redhat.com, ast@kernel.org, Thomas Gleixner , Borislav Petkov , Peter Zijlstra , kernel-team@fb.com, yhs@fb.com, linux-ia64@vger.kernel.org, Abhishek Sagar , Andrii Nakryiko On Mon, 5 Jul 2021 09:48:09 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > Replace arch_deref_entry_point() with dereference_symbol_descriptor() > > because those are doing same thing. > > > > Signed-off-by: Masami Hiramatsu > > Tested-by: Andrii Nakryik > > A better changelog: > > ~15 years ago kprobes grew the 'arch_deref_entry_point()' __weak function: > > 3d7e33825d87: ("jprobes: make jprobes a little safer for users") > > But this is just open-coded dereference_symbol_descriptor() in essence, and > its obscure nature was causing bugs. > > Just use the real thing. OK. BTW, I couldn't find actual bugs from it. What about this? "its obscure nature was causing problems in the past." Thank you, > > Thanks, > > Ingo -- Masami Hiramatsu