* [PATCH] arm: Fix arch_initialise_vcpu to be unsupported
@ 2021-07-06 10:28 Michal Orzel
2021-07-06 17:09 ` Bertrand Marquis
2021-07-07 12:53 ` Julien Grall
0 siblings, 2 replies; 4+ messages in thread
From: Michal Orzel @ 2021-07-06 10:28 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Julien Grall, Volodymyr Babchuk,
bertrand.marquis, Jan Beulich
Function arch_initialise_vcpu is not reachable as the
VCPUOP_initialise is an unsupported operation on arm.
Modify the function by adding ASSERT_UNREACHABLE() and
returning -EOPNOTSUPP.
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
xen/arch/arm/domain.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index c021a03c61..a2aa8b77ad 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -923,7 +923,8 @@ int arch_set_info_guest(
int arch_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
{
- return default_initialise_vcpu(v, arg);
+ ASSERT_UNREACHABLE();
+ return -EOPNOTSUPP;
}
int arch_vcpu_reset(struct vcpu *v)
--
2.29.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: Fix arch_initialise_vcpu to be unsupported
2021-07-06 10:28 [PATCH] arm: Fix arch_initialise_vcpu to be unsupported Michal Orzel
@ 2021-07-06 17:09 ` Bertrand Marquis
2021-07-07 12:53 ` Julien Grall
1 sibling, 0 replies; 4+ messages in thread
From: Bertrand Marquis @ 2021-07-06 17:09 UTC (permalink / raw)
To: Michal Orzel
Cc: Xen-devel, Stefano Stabellini, Julien Grall, Volodymyr Babchuk,
Jan Beulich
Hi Michal,
> On 6 Jul 2021, at 11:28, Michal Orzel <Michal.Orzel@arm.com> wrote:
>
> Function arch_initialise_vcpu is not reachable as the
> VCPUOP_initialise is an unsupported operation on arm.
> Modify the function by adding ASSERT_UNREACHABLE() and
> returning -EOPNOTSUPP.
>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Cheers
Bertrand
> ---
> xen/arch/arm/domain.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index c021a03c61..a2aa8b77ad 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -923,7 +923,8 @@ int arch_set_info_guest(
>
> int arch_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
> {
> - return default_initialise_vcpu(v, arg);
> + ASSERT_UNREACHABLE();
> + return -EOPNOTSUPP;
> }
>
> int arch_vcpu_reset(struct vcpu *v)
> --
> 2.29.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: Fix arch_initialise_vcpu to be unsupported
2021-07-06 10:28 [PATCH] arm: Fix arch_initialise_vcpu to be unsupported Michal Orzel
2021-07-06 17:09 ` Bertrand Marquis
@ 2021-07-07 12:53 ` Julien Grall
2021-07-07 13:06 ` Julien Grall
1 sibling, 1 reply; 4+ messages in thread
From: Julien Grall @ 2021-07-07 12:53 UTC (permalink / raw)
To: Michal Orzel, xen-devel
Cc: Stefano Stabellini, Volodymyr Babchuk, bertrand.marquis, Jan Beulich
Hi Michal,
On 06/07/2021 11:28, Michal Orzel wrote:
> Function arch_initialise_vcpu is not reachable as the
> VCPUOP_initialise is an unsupported operation on arm.
> Modify the function by adding ASSERT_UNREACHABLE() and
> returning -EOPNOTSUPP.
>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
Cheers,
--
Julien Grall
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: Fix arch_initialise_vcpu to be unsupported
2021-07-07 12:53 ` Julien Grall
@ 2021-07-07 13:06 ` Julien Grall
0 siblings, 0 replies; 4+ messages in thread
From: Julien Grall @ 2021-07-07 13:06 UTC (permalink / raw)
To: Michal Orzel, xen-devel
Cc: Stefano Stabellini, Volodymyr Babchuk, bertrand.marquis, Jan Beulich
On 07/07/2021 13:53, Julien Grall wrote:
> Hi Michal,
>
> On 06/07/2021 11:28, Michal Orzel wrote:
>> Function arch_initialise_vcpu is not reachable as the
>> VCPUOP_initialise is an unsupported operation on arm.
>> Modify the function by adding ASSERT_UNREACHABLE() and
>> returning -EOPNOTSUPP.
>>
>> Suggested-by: Jan Beulich <jbeulich@suse.com>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>
> Acked-by: Julien Grall <jgrall@amazon.com>
And committed.
Cheers,
>
> Cheers,
>
--
Julien Grall
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-07 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 10:28 [PATCH] arm: Fix arch_initialise_vcpu to be unsupported Michal Orzel
2021-07-06 17:09 ` Bertrand Marquis
2021-07-07 12:53 ` Julien Grall
2021-07-07 13:06 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.