All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-s390@vger.kernel.org, Eric Farman <farman@linux.ibm.com>,
	kernel@pengutronix.de, Vasily Gorbik <gor@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	linux-kernel@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Vineeth Vijayan <vneethv@linux.ibm.com>,
	kvm@vger.kernel.org, Matthew Rosato <mjrosato@linux.ibm.com>
Subject: Re: [PATCH v2 1/4] s390/cio: Make struct css_driver::remove return void
Date: Tue, 6 Jul 2021 18:05:43 +0200	[thread overview]
Message-ID: <20210706160543.3qfekhzalwsrtahv@pengutronix.de> (raw)
In-Reply-To: <87zguzfn8e.fsf@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

On Tue, Jul 06, 2021 at 05:58:25PM +0200, Cornelia Huck wrote:
> On Tue, Jul 06 2021, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> 
> > The driver core ignores the return value of css_remove()
> > (because there is only little it can do when a device disappears) and
> > there are no pci_epf_drivers with a remove callback.
> 
> s/pci_epf/css/

Argh, too much copy&paste. I make this:

	The driver core ignores the return value of css_remove()
	(because there is only little it can do when a device
	disappears) and all callbacks return 0 anyhow.

to make this actually correct.

> Reviewed-by: Cornelia Huck <cohuck@redhat.com>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-07-06 16:06 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 15:47 [PATCH v2 0/4] bus: Make remove callback return void Uwe Kleine-König
2021-07-06 15:47 ` Uwe Kleine-König
2021-07-06 15:47 ` Uwe Kleine-König
2021-07-06 15:47 ` Uwe Kleine-König
2021-07-06 15:48 ` [PATCH v2 1/4] s390/cio: Make struct css_driver::remove " Uwe Kleine-König
2021-07-06 15:58   ` Cornelia Huck
2021-07-06 16:05     ` Uwe Kleine-König [this message]
2021-07-07 11:28       ` Vineeth Vijayan
2021-07-07 14:34         ` Uwe Kleine-König
2021-07-12 12:13           ` Heiko Carstens
2021-07-06 15:48 ` [PATCH v2 2/4] s390/ccwgroup: Drop if with an always false condition Uwe Kleine-König
2021-07-06 16:04   ` Cornelia Huck
2021-07-07 11:15   ` Vineeth Vijayan
2021-07-06 15:48 ` [PATCH v2 3/4] s390/scm: Make struct scm_driver::remove return void Uwe Kleine-König
2021-07-06 16:05   ` Cornelia Huck
2021-07-07 11:32   ` Vineeth Vijayan
2021-07-06 15:48 ` [PATCH v2 4/4] bus: Make remove callback " Uwe Kleine-König
2021-07-06 15:48   ` Uwe Kleine-König
2021-07-06 15:48   ` Uwe Kleine-König
2021-07-06 15:48   ` Uwe Kleine-König
2021-07-06 16:09   ` Cornelia Huck
2021-07-06 16:09     ` Cornelia Huck
2021-07-06 16:09     ` Cornelia Huck
2021-07-06 16:09     ` Cornelia Huck
2021-07-06 16:09     ` Cornelia Huck
2021-07-06 16:44   ` Rafael J. Wysocki
2021-07-06 16:44     ` Rafael J. Wysocki
2021-07-06 16:44     ` Rafael J. Wysocki
2021-07-06 16:44     ` Rafael J. Wysocki
2021-07-06 16:44     ` Rafael J. Wysocki
2021-07-06 18:08   ` Bjorn Andersson
2021-07-06 18:08     ` Bjorn Andersson
2021-07-06 18:08     ` Bjorn Andersson
2021-07-06 18:08     ` Bjorn Andersson
2021-07-06 18:08     ` Bjorn Andersson
2021-07-06 18:43     ` Uwe Kleine-König
2021-07-06 18:43       ` Uwe Kleine-König
2021-07-06 18:43       ` Uwe Kleine-König
2021-07-06 18:43       ` Uwe Kleine-König
2021-07-06 20:43       ` Bjorn Andersson
2021-07-06 20:43         ` Bjorn Andersson
2021-07-06 20:43         ` Bjorn Andersson
2021-07-06 20:43         ` Bjorn Andersson
2021-07-06 20:43         ` Bjorn Andersson
2021-07-06 18:15   ` Srinivas Pandruvada
2021-07-06 18:15     ` Srinivas Pandruvada
2021-07-06 18:15     ` Srinivas Pandruvada
2021-07-06 18:15     ` Srinivas Pandruvada
2021-07-06 18:32   ` Uwe Kleine-König
2021-07-06 18:32     ` Uwe Kleine-König
2021-07-06 18:32     ` Uwe Kleine-König
2021-07-06 18:32     ` Uwe Kleine-König
2021-07-06 18:51   ` Dan Williams
2021-07-06 18:51     ` Dan Williams
2021-07-06 18:51     ` Dan Williams
2021-07-06 18:51     ` Dan Williams
2021-07-06 18:51     ` Dan Williams
2021-07-06 21:37   ` William Breathitt Gray
2021-07-06 21:37     ` William Breathitt Gray
2021-07-06 21:37     ` William Breathitt Gray
2021-07-06 21:37     ` William Breathitt Gray
2021-07-07  5:57   ` Stefan Richter
2021-07-07 14:24   ` Benjamin Tissoires
2021-07-07 14:24     ` Benjamin Tissoires
2021-07-07 14:24     ` Benjamin Tissoires
2021-07-07 14:24     ` Benjamin Tissoires
2021-07-07 21:51   ` Thorsten Scherer
2021-07-07 21:51     ` Thorsten Scherer
2021-07-07 21:51     ` Thorsten Scherer
2021-07-07 21:51     ` Thorsten Scherer
2021-07-07 21:51     ` Thorsten Scherer
2021-07-08 12:41   ` Ulf Hansson
2021-07-08 12:41     ` Ulf Hansson
2021-07-08 12:41     ` Ulf Hansson
2021-07-08 12:41     ` Ulf Hansson
2021-07-15 12:41   ` Wei Liu
2021-07-15 13:02   ` Thomas Bogendoerfer
2021-07-15 13:02     ` Thomas Bogendoerfer
2021-07-15 13:02     ` Thomas Bogendoerfer
2021-07-15 13:02     ` Thomas Bogendoerfer
2021-07-15 13:02     ` Thomas Bogendoerfer
2021-07-08  2:08 ` [PATCH v2 0/4] " Sven Van Asbroeck
2021-07-08  2:08   ` Sven Van Asbroeck
2021-07-08  2:08   ` Sven Van Asbroeck
2021-07-08  2:08   ` Sven Van Asbroeck
2021-07-08  5:38   ` Uwe Kleine-König
2021-07-08  5:38     ` Uwe Kleine-König
2021-07-08  5:38     ` Uwe Kleine-König
2021-07-08  5:38     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210706160543.3qfekhzalwsrtahv@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hca@linux.ibm.com \
    --cc=kernel@pengutronix.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=oberpar@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=vneethv@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.