From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2275FC07E96 for ; Tue, 6 Jul 2021 22:21:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 981DC61CA7 for ; Tue, 6 Jul 2021 22:21:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 981DC61CA7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0tRa-0003a0-HJ for qemu-devel@archiver.kernel.org; Tue, 06 Jul 2021 18:21:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0tQW-0002Qd-CG for qemu-devel@nongnu.org; Tue, 06 Jul 2021 18:20:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0tQN-0000pk-Qo for qemu-devel@nongnu.org; Tue, 06 Jul 2021 18:20:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625610013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rjyH+CXojeHX7zSU1AFzWnU9hn5rQVYicw5ZLHamtgE=; b=diHEjJKyTzSz8fsJuQiC8UVclnZ0whKkTcSgEqAOmISPd51AQLfrlKMeKvJ0Rj3YCDzhx8 K9OspR4gDBfwTmVCheboAmLHEHIIwQKVNT60MDh+vInp1CipEI+8kNV0/H2IRFtXP6lNuY eu9sptmB4vItP5TefYTD88VZhwJIvzU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-41-3qxP0Bi9Pj61Ca8z43WmKQ-1; Tue, 06 Jul 2021 18:20:11 -0400 X-MC-Unique: 3qxP0Bi9Pj61Ca8z43WmKQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 40DA036303; Tue, 6 Jul 2021 22:20:10 +0000 (UTC) Received: from localhost (ovpn-113-79.rdu2.redhat.com [10.10.113.79]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB9A019C44; Tue, 6 Jul 2021 22:20:09 +0000 (UTC) Date: Tue, 6 Jul 2021 18:20:08 -0400 From: Eduardo Habkost To: Ziqiao Kong Subject: Re: [PATCH v7 2/2] target/i386: Correct implementation for FCS, FIP, FDS and FDP Message-ID: <20210706222008.qxlidk57djrz27fo@habkost.net> References: <20210530150112.74411-1-ziqiaokong@gmail.com> <20210530150112.74411-2-ziqiaokong@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210530150112.74411-2-ziqiaokong@gmail.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, May 30, 2021 at 11:01:14PM +0800, Ziqiao Kong wrote: > Update FCS:FIP and FDS:FDP according to the Intel Manual Vol.1 8.1.8. Note that > CPUID.(EAX=07H,ECX=0H):EBX[bit 13] is not implemented by design in this patch > and will be added along with TCG features flag in a separate patch later. > > Signed-off-by: Ziqiao Kong Richard, are you OK with merging this? I'm not familiar enough with TCG code to be confident in reviewing it. -- Eduardo