All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH for-rc or next 1/2] IB/hfi1: Indicate DMA wait when txq is queued for wakeup
Date: Wed, 07 Jul 2021 05:41:30 +0800	[thread overview]
Message-ID: <202107070548.rJSoKdJk-lkp@intel.com> (raw)
In-Reply-To: <20210706172345.49902.10221.stgit@awfm-01.cornelisnetworks.com>

[-- Attachment #1: Type: text/plain, Size: 5109 bytes --]

Hi Dennis,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20210706]

url:    https://github.com/0day-ci/linux/commits/Dennis-Dalessandro/Second-attempt-at-two-small-fixups/20210707-012603
base:    d72e63193059258a81e12af070b859ef6e0c76fb
config: ia64-randconfig-r032-20210706 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1d73cc1ee156a80112a5d02a566e44319353a57d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dennis-Dalessandro/Second-attempt-at-two-small-fixups/20210707-012603
        git checkout 1d73cc1ee156a80112a5d02a566e44319353a57d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/pensando/ionic/ionic_main.c: In function 'ionic_identify':
>> drivers/net/ethernet/pensando/ionic/ionic_main.c:437:2: warning: 'strncpy' output truncated copying 31 bytes from a string of length 40 [-Wstringop-truncation]
     437 |  strncpy(ident->drv.driver_ver_str, UTS_RELEASE,
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     438 |   sizeof(ident->drv.driver_ver_str) - 1);
         |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/strncpy +437 drivers/net/ethernet/pensando/ionic/ionic_main.c

fbfb8031533c92 Shannon Nelson 2019-09-03  426  
fbfb8031533c92 Shannon Nelson 2019-09-03  427  int ionic_identify(struct ionic *ionic)
fbfb8031533c92 Shannon Nelson 2019-09-03  428  {
fbfb8031533c92 Shannon Nelson 2019-09-03  429  	struct ionic_identity *ident = &ionic->ident;
fbfb8031533c92 Shannon Nelson 2019-09-03  430  	struct ionic_dev *idev = &ionic->idev;
fbfb8031533c92 Shannon Nelson 2019-09-03  431  	size_t sz;
fbfb8031533c92 Shannon Nelson 2019-09-03  432  	int err;
fbfb8031533c92 Shannon Nelson 2019-09-03  433  
fbfb8031533c92 Shannon Nelson 2019-09-03  434  	memset(ident, 0, sizeof(*ident));
fbfb8031533c92 Shannon Nelson 2019-09-03  435  
fbfb8031533c92 Shannon Nelson 2019-09-03  436  	ident->drv.os_type = cpu_to_le32(IONIC_OS_TYPE_LINUX);
1fcbebf115d9ce Shannon Nelson 2020-03-06 @437  	strncpy(ident->drv.driver_ver_str, UTS_RELEASE,
fbfb8031533c92 Shannon Nelson 2019-09-03  438  		sizeof(ident->drv.driver_ver_str) - 1);
fbfb8031533c92 Shannon Nelson 2019-09-03  439  
fbfb8031533c92 Shannon Nelson 2019-09-03  440  	mutex_lock(&ionic->dev_cmd_lock);
fbfb8031533c92 Shannon Nelson 2019-09-03  441  
fbfb8031533c92 Shannon Nelson 2019-09-03  442  	sz = min(sizeof(ident->drv), sizeof(idev->dev_cmd_regs->data));
fbfb8031533c92 Shannon Nelson 2019-09-03  443  	memcpy_toio(&idev->dev_cmd_regs->data, &ident->drv, sz);
fbfb8031533c92 Shannon Nelson 2019-09-03  444  
fbfb8031533c92 Shannon Nelson 2019-09-03  445  	ionic_dev_cmd_identify(idev, IONIC_IDENTITY_VERSION_1);
fbfb8031533c92 Shannon Nelson 2019-09-03  446  	err = ionic_dev_cmd_wait(ionic, DEVCMD_TIMEOUT);
fbfb8031533c92 Shannon Nelson 2019-09-03  447  	if (!err) {
fbfb8031533c92 Shannon Nelson 2019-09-03  448  		sz = min(sizeof(ident->dev), sizeof(idev->dev_cmd_regs->data));
fbfb8031533c92 Shannon Nelson 2019-09-03  449  		memcpy_fromio(&ident->dev, &idev->dev_cmd_regs->data, sz);
fbfb8031533c92 Shannon Nelson 2019-09-03  450  	}
fbfb8031533c92 Shannon Nelson 2019-09-03  451  	mutex_unlock(&ionic->dev_cmd_lock);
fbfb8031533c92 Shannon Nelson 2019-09-03  452  
a21b5d49e77a2e Shannon Nelson 2020-10-01  453  	if (err) {
a21b5d49e77a2e Shannon Nelson 2020-10-01  454  		dev_err(ionic->dev, "Cannot identify ionic: %dn", err);
a21b5d49e77a2e Shannon Nelson 2020-10-01  455  		goto err_out;
a21b5d49e77a2e Shannon Nelson 2020-10-01  456  	}
fbfb8031533c92 Shannon Nelson 2019-09-03  457  
a21b5d49e77a2e Shannon Nelson 2020-10-01  458  	err = ionic_lif_identify(ionic, IONIC_LIF_TYPE_CLASSIC,
a21b5d49e77a2e Shannon Nelson 2020-10-01  459  				 &ionic->ident.lif);
a21b5d49e77a2e Shannon Nelson 2020-10-01  460  	if (err) {
a21b5d49e77a2e Shannon Nelson 2020-10-01  461  		dev_err(ionic->dev, "Cannot identify LIFs: %d\n", err);
a21b5d49e77a2e Shannon Nelson 2020-10-01  462  		goto err_out;
a21b5d49e77a2e Shannon Nelson 2020-10-01  463  	}
fbfb8031533c92 Shannon Nelson 2019-09-03  464  
fbfb8031533c92 Shannon Nelson 2019-09-03  465  	return 0;
fbfb8031533c92 Shannon Nelson 2019-09-03  466  
a21b5d49e77a2e Shannon Nelson 2020-10-01  467  err_out:
fbfb8031533c92 Shannon Nelson 2019-09-03  468  	return err;
fbfb8031533c92 Shannon Nelson 2019-09-03  469  }
fbfb8031533c92 Shannon Nelson 2019-09-03  470  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32591 bytes --]

  reply	other threads:[~2021-07-06 21:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 17:23 [PATCH for-rc or next 0/2] Second attempt at two small fixups Dennis Dalessandro
2021-07-06 17:23 ` [PATCH for-rc or next 1/2] IB/hfi1: Indicate DMA wait when txq is queued for wakeup Dennis Dalessandro
2021-07-06 21:41   ` kernel test robot [this message]
2021-07-12 17:42   ` Jason Gunthorpe
2021-07-12 19:33     ` Dennis Dalessandro
2021-07-13  0:00       ` Jason Gunthorpe
2021-07-14 15:45     ` Marciniszyn, Mike
2021-07-06 17:23 ` [PATCH for-rc or next 2/2] IB/hfi1: Adjust pkey entry in index 0 Dennis Dalessandro
  -- strict thread matches above, loose matches on Subject: below --
2021-07-01 15:46 [PATCH for-rc or next 0/2] Two small fixups Dennis Dalessandro
2021-07-01 15:47 ` [PATCH for-rc or next 1/2] IB/hfi1: Indicate DMA wait when txq is queued for wakeup Dennis Dalessandro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202107070548.rJSoKdJk-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.