From: Jacopo Mondi <jacopo@jmondi.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 09/11] rcar-vin: Specify media device ops at group creation time
Date: Wed, 7 Jul 2021 12:40:36 +0200 [thread overview]
Message-ID: <20210707104036.m6qr2cqobbvvtd4v@uno.localdomain> (raw)
In-Reply-To: <20210413180253.2575451-10-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas,
On Tue, Apr 13, 2021 at 08:02:51PM +0200, Niklas Söderlund wrote:
> The media device operations structure will be different deepening on
s/deepening/depending
> what media graph layout is used. Instead of hard-coding the R-Car CSI-2
> layout allow the operations to be passed as an argument.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/media/platform/rcar-vin/rcar-core.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c
> index d03ecd443b01c2b3..28bf9e8f19a1a27b 100644
> --- a/drivers/media/platform/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/rcar-vin/rcar-core.c
> @@ -248,7 +248,8 @@ static void rvin_group_cleanup(struct rvin_group *group)
> }
>
> static int rvin_group_init(struct rvin_group *group, struct rvin_dev *vin,
> - void (*link_setup)(struct rvin_dev *))
> + void (*link_setup)(struct rvin_dev *),
> + const struct media_device_ops *ops)
> {
> struct media_device *mdev = &group->mdev;
> const struct of_device_id *match;
> @@ -267,7 +268,7 @@ static int rvin_group_init(struct rvin_group *group, struct rvin_dev *vin,
> group->link_setup = link_setup;
>
> mdev->dev = vin->dev;
> - mdev->ops = &rvin_media_ops;
> + mdev->ops = ops;
>
> match = of_match_node(vin->dev->driver->of_match_table,
> vin->dev->of_node);
> @@ -299,7 +300,8 @@ static void rvin_group_release(struct kref *kref)
> }
>
> static int rvin_group_get(struct rvin_dev *vin,
> - void (*link_setup)(struct rvin_dev *))
> + void (*link_setup)(struct rvin_dev *),
> + const struct media_device_ops *ops)
> {
> struct rvin_group *group;
> u32 id;
> @@ -331,7 +333,7 @@ static int rvin_group_get(struct rvin_dev *vin,
> goto err_group;
> }
>
> - ret = rvin_group_init(group, vin, link_setup);
> + ret = rvin_group_init(group, vin, link_setup, ops);
> if (ret) {
> kfree(group);
> vin_err(vin, "Failed to initialize group\n");
> @@ -984,7 +986,7 @@ static int rvin_csi2_init(struct rvin_dev *vin)
> if (ret < 0)
> return ret;
>
> - ret = rvin_group_get(vin, rvin_csi2_setup_links);
> + ret = rvin_group_get(vin, rvin_csi2_setup_links, &rvin_media_ops);
I would continue the effort of using the csi2_ prefix for CSI-2
related fields. Just a nit, the change looks good
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Thanks
j
> if (ret)
> goto err_controls;
>
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-07-07 10:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 18:02 [PATCH 00/11] rcar-vin: Add r8a779a0 support Niklas Söderlund
2021-04-13 18:02 ` [PATCH 01/11] rcar-vin: Refactor controls creation for video device Niklas Söderlund
2021-07-06 16:04 ` Jacopo Mondi
2021-07-06 16:16 ` Niklas Söderlund
2021-07-06 16:58 ` Jacopo Mondi
2021-07-08 13:40 ` Sakari Ailus
2021-07-08 14:05 ` Niklas Söderlund
2021-07-08 14:42 ` Sakari Ailus
2021-07-06 16:08 ` Jacopo Mondi
2021-07-06 16:17 ` Niklas Söderlund
2021-04-13 18:02 ` [PATCH 02/11] rcar-vin: Fix error paths for rvin_mc_init() Niklas Söderlund
2021-07-06 16:09 ` Jacopo Mondi
2021-04-13 18:02 ` [PATCH 03/11] rcar-vin: Improve async notifier cleanup paths Niklas Söderlund
2021-07-06 16:41 ` Jacopo Mondi
2021-04-13 18:02 ` [PATCH 04/11] rcar-vin: Improve reuse of parallel notifier Niklas Söderlund
2021-07-06 16:51 ` Jacopo Mondi
2021-07-07 8:51 ` Niklas Söderlund
2021-04-13 18:02 ` [PATCH 05/11] rcar-vin: Rename array storing subdevice information Niklas Söderlund
2021-07-06 16:53 ` Jacopo Mondi
2021-04-13 18:02 ` [PATCH 06/11] rcar-vin: Move group async notifier Niklas Söderlund
2021-07-06 16:58 ` Jacopo Mondi
2021-04-13 18:02 ` [PATCH 07/11] rcar-vin: Extend group notifier DT parser to work with any port Niklas Söderlund
2021-07-07 10:24 ` Jacopo Mondi
2021-04-13 18:02 ` [PATCH 08/11] rcar-vin: Create a callback to setup media links Niklas Söderlund
2021-07-07 10:33 ` Jacopo Mondi
2021-07-08 15:46 ` Niklas Söderlund
2021-04-13 18:02 ` [PATCH 09/11] rcar-vin: Specify media device ops at group creation time Niklas Söderlund
2021-07-07 10:40 ` Jacopo Mondi [this message]
2021-04-13 18:02 ` [PATCH 10/11] rcar-vin: Move and rename CSI-2 link notifications Niklas Söderlund
2021-07-07 10:46 ` Jacopo Mondi
2021-04-13 18:02 ` [PATCH 11/11] rcar-vin: Add r8a779a0 support Niklas Söderlund
2021-07-07 11:09 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210707104036.m6qr2cqobbvvtd4v@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.