From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCE1DC07E95 for ; Wed, 7 Jul 2021 13:54:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADD5D61CA8 for ; Wed, 7 Jul 2021 13:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbhGGN5V (ORCPT ); Wed, 7 Jul 2021 09:57:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231472AbhGGN5U (ORCPT ); Wed, 7 Jul 2021 09:57:20 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3584CC061574 for ; Wed, 7 Jul 2021 06:54:40 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m180c-0002JU-DF; Wed, 07 Jul 2021 15:54:38 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m180b-0002X4-NJ; Wed, 07 Jul 2021 15:54:37 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1m180b-0005tg-M0; Wed, 07 Jul 2021 15:54:37 +0200 Date: Wed, 7 Jul 2021 15:54:37 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Ahmad Fatoum Cc: Shawn Guo , devicetree@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: freescale/imx8mp-evk.dts: reorder nodes alphabetically Message-ID: <20210707135437.p25nkjaw6vhqyxzb@pengutronix.de> References: <20210707105309.1693138-1-u.kleine-koenig@pengutronix.de> <800ac3ca-e3a0-8d6c-5164-af804c6b2d4d@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l6rfnymzmftvtdni" Content-Disposition: inline In-Reply-To: <800ac3ca-e3a0-8d6c-5164-af804c6b2d4d@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --l6rfnymzmftvtdni Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Ahmad, On Wed, Jul 07, 2021 at 01:06:19PM +0200, Ahmad Fatoum wrote: > On 07.07.21 12:53, Uwe Kleine-K=F6nig wrote: > > The nodes after the root nodes are supposed to be ordered > > alphabetically. So move &flexcan1, &flexcan2 and &pinctrl to their > > proper place. >=20 > At least for i.MX, it seems to be convention to have iomuxc at the end > of the file. Oh, that's news to me. Looking at next/master and the output of $ for f in $(git grep -l \&iomux arch/arm/boot/dts/imx* arch/arm64/boot/dts= /freescale/*); do awk '/^&/ { handle =3D $1; } END { if ( handle =3D=3D "&i= omuxc" ) { print "end" } else { print "middle" } }' "$f"; done | sort | uni= q -c 158 end 143 middle (i.e. among the files that have a &iomux node, iomuxc is at the end for 158, and for 143 is isn't) So that convention is either new or not very binding. Note: In the end case there are a few (e.g. arch/arm/boot/dts/imx6qdl-pico-dwarf.dtsi and arch/arm/boot/dts/imx6qdl-pico-pi.dtsi) where iomuxc is at the end and the file is sorted. > I'd not reorder it, file is easier to browse when it's not in the > middle. Seems to be subjective :-) I would consider it easier to browse if each pinmux define would be near the device node that makes use of it, but iomuxc being at the end doesn't have an advantage for me. I don't feel like resending to only fix the flexcan ordering. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --l6rfnymzmftvtdni Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmDlshoACgkQwfwUeK3K 7AnznQf9EiG1fYgCrTnLWq2vSnwYr05IR0VABi22DbU+F9qv1wbdPYUM52Psv+Iy VtC1tCkBSSD49jHM3CYMjHsVY0jbVLI6GJIHFn7reh9pEE2hGi5LtaLV9AsMBFks IK6vcOfxTjmk0i41u1ZZshLJxx8UPo6aF5ok9lH35OfO3Ew4S5vjRQ7NosCm3nCY EMRbxfCklwALN2cdFJskHbG1YYExg8sVtCc28+Gg7X+uayKIr1CHvU0u3yL/mn0R QE2xsJkjqzu9Es0p7UY48OURYYJGO57v+IrJDT3yCRtRIg8bcb37eBVp6uizTwtx 9LXwB9jbPIJRWw+aZ+sLsDmQu4rCMA== =+EU+ -----END PGP SIGNATURE----- --l6rfnymzmftvtdni-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A551AC07E95 for ; Wed, 7 Jul 2021 13:56:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6519461C73 for ; Wed, 7 Jul 2021 13:56:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6519461C73 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tZvB2YBX3BhG27rZl4V42ViLff1bba0txjney+0wxnQ=; b=RljCXV4oO/irlrl64bgU7ASbsb T47WkdsOLLd3/EjRKLFGCpPQLrQSeuVM3xwEscujD6uS5J4D7w9imiYeGW03vhp3+vdUaalBEalKF /JAkAI36eoWVEoYE4aVeGMky6leXLcT/3B1VZVtLCHTSinjfx+0mE5OdQVTsJYlkeGQMW5uGMEP8O vjJ65Y58QyBZmB6rT3V+/RkQApTgCynoByHtD0uUZR3R1nj4T/4K1ql/GBFQ5pkCvKny6+DZVeUAF lQr3p9urHiRaKIk7S5Xxh3kKowJS7y23xcJ/Uj+mQlzmuBwYWD51pmlW639TS7/Yk0FxX3uWNVQix bfXPODQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m180m-00EzmW-TG; Wed, 07 Jul 2021 13:54:49 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m180i-00EzlX-Fp for linux-arm-kernel@lists.infradead.org; Wed, 07 Jul 2021 13:54:45 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m180c-0002JU-DF; Wed, 07 Jul 2021 15:54:38 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m180b-0002X4-NJ; Wed, 07 Jul 2021 15:54:37 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1m180b-0005tg-M0; Wed, 07 Jul 2021 15:54:37 +0200 Date: Wed, 7 Jul 2021 15:54:37 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Ahmad Fatoum Cc: Shawn Guo , devicetree@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: freescale/imx8mp-evk.dts: reorder nodes alphabetically Message-ID: <20210707135437.p25nkjaw6vhqyxzb@pengutronix.de> References: <20210707105309.1693138-1-u.kleine-koenig@pengutronix.de> <800ac3ca-e3a0-8d6c-5164-af804c6b2d4d@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <800ac3ca-e3a0-8d6c-5164-af804c6b2d4d@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210707_065444_574175_03C27361 X-CRM114-Status: GOOD ( 21.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5603934195133212077==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5603934195133212077== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l6rfnymzmftvtdni" Content-Disposition: inline --l6rfnymzmftvtdni Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Ahmad, On Wed, Jul 07, 2021 at 01:06:19PM +0200, Ahmad Fatoum wrote: > On 07.07.21 12:53, Uwe Kleine-K=F6nig wrote: > > The nodes after the root nodes are supposed to be ordered > > alphabetically. So move &flexcan1, &flexcan2 and &pinctrl to their > > proper place. >=20 > At least for i.MX, it seems to be convention to have iomuxc at the end > of the file. Oh, that's news to me. Looking at next/master and the output of $ for f in $(git grep -l \&iomux arch/arm/boot/dts/imx* arch/arm64/boot/dts= /freescale/*); do awk '/^&/ { handle =3D $1; } END { if ( handle =3D=3D "&i= omuxc" ) { print "end" } else { print "middle" } }' "$f"; done | sort | uni= q -c 158 end 143 middle (i.e. among the files that have a &iomux node, iomuxc is at the end for 158, and for 143 is isn't) So that convention is either new or not very binding. Note: In the end case there are a few (e.g. arch/arm/boot/dts/imx6qdl-pico-dwarf.dtsi and arch/arm/boot/dts/imx6qdl-pico-pi.dtsi) where iomuxc is at the end and the file is sorted. > I'd not reorder it, file is easier to browse when it's not in the > middle. Seems to be subjective :-) I would consider it easier to browse if each pinmux define would be near the device node that makes use of it, but iomuxc being at the end doesn't have an advantage for me. I don't feel like resending to only fix the flexcan ordering. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --l6rfnymzmftvtdni Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmDlshoACgkQwfwUeK3K 7AnznQf9EiG1fYgCrTnLWq2vSnwYr05IR0VABi22DbU+F9qv1wbdPYUM52Psv+Iy VtC1tCkBSSD49jHM3CYMjHsVY0jbVLI6GJIHFn7reh9pEE2hGi5LtaLV9AsMBFks IK6vcOfxTjmk0i41u1ZZshLJxx8UPo6aF5ok9lH35OfO3Ew4S5vjRQ7NosCm3nCY EMRbxfCklwALN2cdFJskHbG1YYExg8sVtCc28+Gg7X+uayKIr1CHvU0u3yL/mn0R QE2xsJkjqzu9Es0p7UY48OURYYJGO57v+IrJDT3yCRtRIg8bcb37eBVp6uizTwtx 9LXwB9jbPIJRWw+aZ+sLsDmQu4rCMA== =+EU+ -----END PGP SIGNATURE----- --l6rfnymzmftvtdni-- --===============5603934195133212077== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5603934195133212077==--