From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E71CC07E95 for ; Wed, 7 Jul 2021 16:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA3A661CC8 for ; Wed, 7 Jul 2021 16:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230372AbhGGQdc (ORCPT ); Wed, 7 Jul 2021 12:33:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:33854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbhGGQda (ORCPT ); Wed, 7 Jul 2021 12:33:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 212E761CC5; Wed, 7 Jul 2021 16:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625675450; bh=6q+hWWacieAshKe+FazOGS4+liEhM0sS2Dz2WwbaioM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l6XE8rJ8eCIjEuW/OTCcINKwbPPXVtpu1wnpjWfrXvuqb0kQuKtiQNyTRuRVFW2X/ uLnAP3RX5HV0Wia26RBwkuHUZ3QQ6KfsxbYp61H/6MRs+R4VBUPzhgdWPQwWKcKGmc /twuV2LZBQJOnNy0Cd3DjWIa3X8yN9h86d4hcbZoisFFLMqMJ09K2IhG3DMrX/Ox2G V6hUjpJPbqVvo91IoYq6Ym8XjI3f9hkxViihmEmg2O/+Gciek/fWIhwpRKkn/8LPZa EriIi+C4sXCftiOqtC8gP9HSlEhTAzgNOTaW4O6h5ChjwNkgiMkzoW4LJctP0RGV5R a+rP5Xlfv7PdQ== Date: Wed, 7 Jul 2021 17:30:18 +0100 From: Mark Brown To: Vijendar Mukunda Cc: alsa-devel@alsa-project.org, Alexander.Deucher@amd.com, Sunil-kumar.Dommati@amd.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , open list Subject: Re: [PATCH 07/12] ASoC: amd: add ACP5x pcm dma driver ops Message-ID: <20210707163018.GH4394@sirena.org.uk> References: <20210707055623.27371-1-vijendar.mukunda@amd.com> <20210707055623.27371-8-vijendar.mukunda@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dCSxeJc5W8HZXZrD" Content-Disposition: inline In-Reply-To: <20210707055623.27371-8-vijendar.mukunda@amd.com> X-Cookie: I will never lie to you. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dCSxeJc5W8HZXZrD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 07, 2021 at 11:26:18AM +0530, Vijendar Mukunda wrote: > + /* Group Enable */ > + acp_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp5x_base + > + ACPAXI2AXI_ATU_BASE_ADDR_GRP_1); > + acp_writel(PAGE_SIZE_4K_ENABLE, rtd->acp5x_base + > + ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1); This isn't connected to the kernel page size is it? If so we might've configured to 16K or 64K, or possibly even some other options - I know those two are out there in the wild. --dCSxeJc5W8HZXZrD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDl1poACgkQJNaLcl1U h9BiQAf6AtJK2Ffb4vUcYoiF04zy8sKGtW2lCQKie6xHafUl64QvbDcxF977k09V Bpu700qytonU3CYdFtqWcgiHpOT8XkSubup2Dswx+XkSp4oygFj+tG08oEUyw78I tNBSG8PYuLBjAQukjrvs59MUieYz2QkGhQLWnJhImCtM8rM0JVWP+Qb1Vd9U3pYH CDxQz8fKZKJGo88Ng9xJhxzfW+nTyxuxIfJVDgDyAj+8a9vlWz1uV/Q6VS9FdGXj W+4uFwf96SUfICTOmQxgE5Tcm9cfLZ1ITHSdC4vzFq+6dalxF91u/Rekfh4+xb2v NGJDu6PyrHM9EzxLM73YYa1f0VSa2w== =iaY1 -----END PGP SIGNATURE----- --dCSxeJc5W8HZXZrD-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFB0C07E95 for ; Wed, 7 Jul 2021 16:31:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BC3B61CC7 for ; Wed, 7 Jul 2021 16:31:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BC3B61CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0C4A682A; Wed, 7 Jul 2021 18:30:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0C4A682A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1625675507; bh=6q+hWWacieAshKe+FazOGS4+liEhM0sS2Dz2WwbaioM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VRGRHUvz12GOog83U+qZ/gO7jY7/MYh8wRkMzGPsbnqzc43zsLLejJjbBpLvHpWil AQXADm1dyKcIuCo1Ezb/kzMTx9RESrgUREEpFNBUiV0OlHEdAYelwDCnTKqVncJVXm gtwM+WRDiH5FWbWue33yTiCDyHjhssVQXJf6EDBY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9567CF8016C; Wed, 7 Jul 2021 18:30:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0146EF80224; Wed, 7 Jul 2021 18:30:54 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7998AF8012A for ; Wed, 7 Jul 2021 18:30:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7998AF8012A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l6XE8rJ8" Received: by mail.kernel.org (Postfix) with ESMTPSA id 212E761CC5; Wed, 7 Jul 2021 16:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625675450; bh=6q+hWWacieAshKe+FazOGS4+liEhM0sS2Dz2WwbaioM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l6XE8rJ8eCIjEuW/OTCcINKwbPPXVtpu1wnpjWfrXvuqb0kQuKtiQNyTRuRVFW2X/ uLnAP3RX5HV0Wia26RBwkuHUZ3QQ6KfsxbYp61H/6MRs+R4VBUPzhgdWPQwWKcKGmc /twuV2LZBQJOnNy0Cd3DjWIa3X8yN9h86d4hcbZoisFFLMqMJ09K2IhG3DMrX/Ox2G V6hUjpJPbqVvo91IoYq6Ym8XjI3f9hkxViihmEmg2O/+Gciek/fWIhwpRKkn/8LPZa EriIi+C4sXCftiOqtC8gP9HSlEhTAzgNOTaW4O6h5ChjwNkgiMkzoW4LJctP0RGV5R a+rP5Xlfv7PdQ== Date: Wed, 7 Jul 2021 17:30:18 +0100 From: Mark Brown To: Vijendar Mukunda Subject: Re: [PATCH 07/12] ASoC: amd: add ACP5x pcm dma driver ops Message-ID: <20210707163018.GH4394@sirena.org.uk> References: <20210707055623.27371-1-vijendar.mukunda@amd.com> <20210707055623.27371-8-vijendar.mukunda@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dCSxeJc5W8HZXZrD" Content-Disposition: inline In-Reply-To: <20210707055623.27371-8-vijendar.mukunda@amd.com> X-Cookie: I will never lie to you. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, Sunil-kumar.Dommati@amd.com, open list , Takashi Iwai , Liam Girdwood , Alexander.Deucher@amd.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --dCSxeJc5W8HZXZrD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 07, 2021 at 11:26:18AM +0530, Vijendar Mukunda wrote: > + /* Group Enable */ > + acp_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp5x_base + > + ACPAXI2AXI_ATU_BASE_ADDR_GRP_1); > + acp_writel(PAGE_SIZE_4K_ENABLE, rtd->acp5x_base + > + ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1); This isn't connected to the kernel page size is it? If so we might've configured to 16K or 64K, or possibly even some other options - I know those two are out there in the wild. --dCSxeJc5W8HZXZrD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDl1poACgkQJNaLcl1U h9BiQAf6AtJK2Ffb4vUcYoiF04zy8sKGtW2lCQKie6xHafUl64QvbDcxF977k09V Bpu700qytonU3CYdFtqWcgiHpOT8XkSubup2Dswx+XkSp4oygFj+tG08oEUyw78I tNBSG8PYuLBjAQukjrvs59MUieYz2QkGhQLWnJhImCtM8rM0JVWP+Qb1Vd9U3pYH CDxQz8fKZKJGo88Ng9xJhxzfW+nTyxuxIfJVDgDyAj+8a9vlWz1uV/Q6VS9FdGXj W+4uFwf96SUfICTOmQxgE5Tcm9cfLZ1ITHSdC4vzFq+6dalxF91u/Rekfh4+xb2v NGJDu6PyrHM9EzxLM73YYa1f0VSa2w== =iaY1 -----END PGP SIGNATURE----- --dCSxeJc5W8HZXZrD--