From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 409BAC07E96 for ; Thu, 8 Jul 2021 14:34:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 293766146E for ; Thu, 8 Jul 2021 14:34:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231756AbhGHOhg (ORCPT ); Thu, 8 Jul 2021 10:37:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:41542 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbhGHOhg (ORCPT ); Thu, 8 Jul 2021 10:37:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F091561447; Thu, 8 Jul 2021 14:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625754894; bh=P4PBX+GAQy0bO8fw85gOwG3PJ2Psj8KDGEnKC6hNrTc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r/aMWZUU4sxAM6tQacQmFtX8vgQR7dO0Il1mCuRHlKhPYHxcTsuUjJmEtFR9xlISe m3fYl0wcNBVsaH5YthbOHdwHFOWJvrF6vDxZqGzmyBSEoKlMWtefyP9bgsWUMfTY3h q5s92fhxR/JzIc/rdTHqF7C4JNI3UNvSCY9w9vfJkOxxTJi9IEHqqL8bg25i4TtHVO s9BJninc4SnHHcqOvO3Ou0KIGL9ZgLJC7M4eIqM3K4KDZLwns0Z4a3q2riCrX/dHVP tUeObXiOu8KwIvvMVd4KRdh8adZC53fkl2T38anOBYJkftvSZ+UQRVRPXz9bLsV+hX ULhBo625NKYGA== Received: by pali.im (Postfix) id 3747F7B5; Thu, 8 Jul 2021 16:34:51 +0200 (CEST) Date: Thu, 8 Jul 2021 16:34:51 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Konstantin Porotchkin , Nadav Haklai , Ken Ma , Victor Gu , Jason Hung Cc: Marek =?utf-8?B?QmVow7pu?= , Viresh Kumar , Gregory CLEMENT , Robert Marko , Tomasz Maciej Nowak , Anders Trier Olesen , Philip Soares , linux-pm@vger.kernel.org, Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, nnet Subject: Re: [PATCH v2] cpufreq: armada-37xx: forbid cpufreq for 1.2 GHz variant Message-ID: <20210708143451.4htvdop4zvjufrq6@pali> References: <20210630135942.29730-1-kabel@kernel.org> <20210630225601.6372-1-kabel@kernel.org> <20210702163035.nmb5pniwpqtmaz4b@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210702163035.nmb5pniwpqtmaz4b@pali> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Konstantin, Nadav, Ken, Victor, Jason: This issue is pretty serious, CPU on 1.2GHz A3720 is crashing. Could you please look at it? On Friday 02 July 2021 18:30:35 Pali Rohár wrote: > +Jason from GlobalScale as this issue affects GlobalScale Espressobin Ultra and V7 1.2 GHz boards. > > On Thursday 01 July 2021 00:56:01 Marek Behún wrote: > > The 1.2 GHz variant of the Armada 3720 SOC is unstable with DVFS: when > > the SOC boots, the WTMI firmware sets clocks and AVS values that work > > correctly with 1.2 GHz CPU frequency, but random crashes occur once > > cpufreq driver starts scaling. > > > > We do not know currently what is the reason: > > - it may be that the voltage value for L0 for 1.2 GHz variant provided > > by the vendor in the OTP is simply incorrect when scaling is used, > > - it may be that some delay is needed somewhere, > > - it may be something else. > > > > The most sane solution now seems to be to simply forbid the cpufreq > > driver on 1.2 GHz variant. > > > > Signed-off-by: Marek Behún > > Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx") > > --- > > If someone from Marvell could look into this, it would be great since > > basically 1.2 GHz variant cannot scale, which is a feature that was > > claimed to be supported by the SOC. > > > > Ken Ma / Victor Gu, you have worked on commit > > https://github.com/MarvellEmbeddedProcessors/linux-marvell/commit/d6719fdc2b3cac58064f41b531f86993c919aa9a > > in linux-marvell. > > Your patch takes away the 1202 mV constant for 1.2 GHz base CPU > > frequency and instead adds code that computes the voltages from the > > voltage found in L0 AVS register (which is filled in by WTMI firmware). > > > > Do you know why the code does not work correctly for some 1.2 GHz > > boards? Do we need to force the L0 voltage to 1202 mV if it is lower, > > or something? > > --- > > drivers/cpufreq/armada-37xx-cpufreq.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c > > index 3fc98a3ffd91..c10fc33b29b1 100644 > > --- a/drivers/cpufreq/armada-37xx-cpufreq.c > > +++ b/drivers/cpufreq/armada-37xx-cpufreq.c > > @@ -104,7 +104,11 @@ struct armada_37xx_dvfs { > > }; > > > > static struct armada_37xx_dvfs armada_37xx_dvfs[] = { > > - {.cpu_freq_max = 1200*1000*1000, .divider = {1, 2, 4, 6} }, > > + /* > > + * The cpufreq scaling for 1.2 GHz variant of the SOC is currently > > + * unstable because we do not know how to configure it properly. > > + */ > > + /* {.cpu_freq_max = 1200*1000*1000, .divider = {1, 2, 4, 6} }, */ > > {.cpu_freq_max = 1000*1000*1000, .divider = {1, 2, 4, 5} }, > > {.cpu_freq_max = 800*1000*1000, .divider = {1, 2, 3, 4} }, > > {.cpu_freq_max = 600*1000*1000, .divider = {2, 4, 5, 6} }, > > -- > > 2.31.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E481BC07E99 for ; Thu, 8 Jul 2021 14:36:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC7B861467 for ; Thu, 8 Jul 2021 14:36:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC7B861467 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f/93MI5sKv0oMYiyXunAUq553bKonJ7ifD8U4M06c6c=; b=KqtmvCJOo8Ed4m ccWbzu3dJC2G3m2QPJ/xkEItWm6sRFQji85lbd5shpAYUOIpzj9Li9BpL4tOYB21CZEbJ1Ue89PGQ tza41JB02qHohT9QJJufSwyomIIXhRz3mQRru7hUXYCvSjvWtRGfUDCEAvgI12JmZ4vys62DeUE8F sKJHVzWy2PtPATm5gfLJN0hPNvyGCMXajGwioegjy2fmKvf10P08gvYEaTD7NYlN0GGm5Ij9ocY1o tgfcd1SaPlxGJKQ8i9A2oQEvNjk91gLZ0vQJMo3y6Uq+SQIPIV70Qvdj6DQaHULK5T1+tZ+AqY/4b LZj6VPX5/oWA35Sh6K1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1V7C-00HCoK-S2; Thu, 08 Jul 2021 14:34:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1V78-00HCnu-K8 for linux-arm-kernel@lists.infradead.org; Thu, 08 Jul 2021 14:34:56 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id F091561447; Thu, 8 Jul 2021 14:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625754894; bh=P4PBX+GAQy0bO8fw85gOwG3PJ2Psj8KDGEnKC6hNrTc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r/aMWZUU4sxAM6tQacQmFtX8vgQR7dO0Il1mCuRHlKhPYHxcTsuUjJmEtFR9xlISe m3fYl0wcNBVsaH5YthbOHdwHFOWJvrF6vDxZqGzmyBSEoKlMWtefyP9bgsWUMfTY3h q5s92fhxR/JzIc/rdTHqF7C4JNI3UNvSCY9w9vfJkOxxTJi9IEHqqL8bg25i4TtHVO s9BJninc4SnHHcqOvO3Ou0KIGL9ZgLJC7M4eIqM3K4KDZLwns0Z4a3q2riCrX/dHVP tUeObXiOu8KwIvvMVd4KRdh8adZC53fkl2T38anOBYJkftvSZ+UQRVRPXz9bLsV+hX ULhBo625NKYGA== Received: by pali.im (Postfix) id 3747F7B5; Thu, 8 Jul 2021 16:34:51 +0200 (CEST) Date: Thu, 8 Jul 2021 16:34:51 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Konstantin Porotchkin , Nadav Haklai , Ken Ma , Victor Gu , Jason Hung Cc: Marek =?utf-8?B?QmVow7pu?= , Viresh Kumar , Gregory CLEMENT , Robert Marko , Tomasz Maciej Nowak , Anders Trier Olesen , Philip Soares , linux-pm@vger.kernel.org, Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, nnet Subject: Re: [PATCH v2] cpufreq: armada-37xx: forbid cpufreq for 1.2 GHz variant Message-ID: <20210708143451.4htvdop4zvjufrq6@pali> References: <20210630135942.29730-1-kabel@kernel.org> <20210630225601.6372-1-kabel@kernel.org> <20210702163035.nmb5pniwpqtmaz4b@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210702163035.nmb5pniwpqtmaz4b@pali> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210708_073454_739711_3462B941 X-CRM114-Status: GOOD ( 34.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org S29uc3RhbnRpbiwgTmFkYXYsIEtlbiwgVmljdG9yLCBKYXNvbjogVGhpcyBpc3N1ZSBpcyBwcmV0 dHkgc2VyaW91cywKQ1BVIG9uIDEuMkdIeiBBMzcyMCBpcyBjcmFzaGluZy4gQ291bGQgeW91IHBs ZWFzZSBsb29rIGF0IGl0PwoKT24gRnJpZGF5IDAyIEp1bHkgMjAyMSAxODozMDozNSBQYWxpIFJv aMOhciB3cm90ZToKPiArSmFzb24gZnJvbSBHbG9iYWxTY2FsZSBhcyB0aGlzIGlzc3VlIGFmZmVj dHMgR2xvYmFsU2NhbGUgRXNwcmVzc29iaW4gVWx0cmEgYW5kIFY3IDEuMiBHSHogYm9hcmRzLgo+ IAo+IE9uIFRodXJzZGF5IDAxIEp1bHkgMjAyMSAwMDo1NjowMSBNYXJlayBCZWjDum4gd3JvdGU6 Cj4gPiBUaGUgMS4yIEdIeiB2YXJpYW50IG9mIHRoZSBBcm1hZGEgMzcyMCBTT0MgaXMgdW5zdGFi bGUgd2l0aCBEVkZTOiB3aGVuCj4gPiB0aGUgU09DIGJvb3RzLCB0aGUgV1RNSSBmaXJtd2FyZSBz ZXRzIGNsb2NrcyBhbmQgQVZTIHZhbHVlcyB0aGF0IHdvcmsKPiA+IGNvcnJlY3RseSB3aXRoIDEu MiBHSHogQ1BVIGZyZXF1ZW5jeSwgYnV0IHJhbmRvbSBjcmFzaGVzIG9jY3VyIG9uY2UKPiA+IGNw dWZyZXEgZHJpdmVyIHN0YXJ0cyBzY2FsaW5nLgo+ID4gCj4gPiBXZSBkbyBub3Qga25vdyBjdXJy ZW50bHkgd2hhdCBpcyB0aGUgcmVhc29uOgo+ID4gLSBpdCBtYXkgYmUgdGhhdCB0aGUgdm9sdGFn ZSB2YWx1ZSBmb3IgTDAgZm9yIDEuMiBHSHogdmFyaWFudCBwcm92aWRlZAo+ID4gICBieSB0aGUg dmVuZG9yIGluIHRoZSBPVFAgaXMgc2ltcGx5IGluY29ycmVjdCB3aGVuIHNjYWxpbmcgaXMgdXNl ZCwKPiA+IC0gaXQgbWF5IGJlIHRoYXQgc29tZSBkZWxheSBpcyBuZWVkZWQgc29tZXdoZXJlLAo+ ID4gLSBpdCBtYXkgYmUgc29tZXRoaW5nIGVsc2UuCj4gPiAKPiA+IFRoZSBtb3N0IHNhbmUgc29s dXRpb24gbm93IHNlZW1zIHRvIGJlIHRvIHNpbXBseSBmb3JiaWQgdGhlIGNwdWZyZXEKPiA+IGRy aXZlciBvbiAxLjIgR0h6IHZhcmlhbnQuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE1hcmVrIEJl aMO6biA8a2FiZWxAa2VybmVsLm9yZz4KPiA+IEZpeGVzOiA5MmNlNDVmYjg3NWQgKCJjcHVmcmVx OiBBZGQgRFZGUyBzdXBwb3J0IGZvciBBcm1hZGEgMzd4eCIpCj4gPiAtLS0KPiA+IElmIHNvbWVv bmUgZnJvbSBNYXJ2ZWxsIGNvdWxkIGxvb2sgaW50byB0aGlzLCBpdCB3b3VsZCBiZSBncmVhdCBz aW5jZQo+ID4gYmFzaWNhbGx5IDEuMiBHSHogdmFyaWFudCBjYW5ub3Qgc2NhbGUsIHdoaWNoIGlz IGEgZmVhdHVyZSB0aGF0IHdhcwo+ID4gY2xhaW1lZCB0byBiZSBzdXBwb3J0ZWQgYnkgdGhlIFNP Qy4KPiA+IAo+ID4gS2VuIE1hIC8gVmljdG9yIEd1LCB5b3UgaGF2ZSB3b3JrZWQgb24gY29tbWl0 Cj4gPiBodHRwczovL2dpdGh1Yi5jb20vTWFydmVsbEVtYmVkZGVkUHJvY2Vzc29ycy9saW51eC1t YXJ2ZWxsL2NvbW1pdC9kNjcxOWZkYzJiM2NhYzU4MDY0ZjQxYjUzMWY4Njk5M2M5MTlhYTlhCj4g PiBpbiBsaW51eC1tYXJ2ZWxsLgo+ID4gWW91ciBwYXRjaCB0YWtlcyBhd2F5IHRoZSAxMjAyIG1W IGNvbnN0YW50IGZvciAxLjIgR0h6IGJhc2UgQ1BVCj4gPiBmcmVxdWVuY3kgYW5kIGluc3RlYWQg YWRkcyBjb2RlIHRoYXQgY29tcHV0ZXMgdGhlIHZvbHRhZ2VzIGZyb20gdGhlCj4gPiB2b2x0YWdl IGZvdW5kIGluIEwwIEFWUyByZWdpc3RlciAod2hpY2ggaXMgZmlsbGVkIGluIGJ5IFdUTUkgZmly bXdhcmUpLgo+ID4gCj4gPiBEbyB5b3Uga25vdyB3aHkgdGhlIGNvZGUgZG9lcyBub3Qgd29yayBj b3JyZWN0bHkgZm9yIHNvbWUgMS4yIEdIego+ID4gYm9hcmRzPyBEbyB3ZSBuZWVkIHRvIGZvcmNl IHRoZSBMMCB2b2x0YWdlIHRvIDEyMDIgbVYgaWYgaXQgaXMgbG93ZXIsCj4gPiBvciBzb21ldGhp bmc/Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2NwdWZyZXEvYXJtYWRhLTM3eHgtY3B1ZnJlcS5jIHwg NiArKysrKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u KC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2NwdWZyZXEvYXJtYWRhLTM3eHgtY3B1 ZnJlcS5jIGIvZHJpdmVycy9jcHVmcmVxL2FybWFkYS0zN3h4LWNwdWZyZXEuYwo+ID4gaW5kZXgg M2ZjOThhM2ZmZDkxLi5jMTBmYzMzYjI5YjEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2NwdWZy ZXEvYXJtYWRhLTM3eHgtY3B1ZnJlcS5jCj4gPiArKysgYi9kcml2ZXJzL2NwdWZyZXEvYXJtYWRh LTM3eHgtY3B1ZnJlcS5jCj4gPiBAQCAtMTA0LDcgKzEwNCwxMSBAQCBzdHJ1Y3QgYXJtYWRhXzM3 eHhfZHZmcyB7Cj4gPiAgfTsKPiA+ICAKPiA+ICBzdGF0aWMgc3RydWN0IGFybWFkYV8zN3h4X2R2 ZnMgYXJtYWRhXzM3eHhfZHZmc1tdID0gewo+ID4gLQl7LmNwdV9mcmVxX21heCA9IDEyMDAqMTAw MCoxMDAwLCAuZGl2aWRlciA9IHsxLCAyLCA0LCA2fSB9LAo+ID4gKwkvKgo+ID4gKwkgKiBUaGUg Y3B1ZnJlcSBzY2FsaW5nIGZvciAxLjIgR0h6IHZhcmlhbnQgb2YgdGhlIFNPQyBpcyBjdXJyZW50 bHkKPiA+ICsJICogdW5zdGFibGUgYmVjYXVzZSB3ZSBkbyBub3Qga25vdyBob3cgdG8gY29uZmln dXJlIGl0IHByb3Blcmx5Lgo+ID4gKwkgKi8KPiA+ICsJLyogey5jcHVfZnJlcV9tYXggPSAxMjAw KjEwMDAqMTAwMCwgLmRpdmlkZXIgPSB7MSwgMiwgNCwgNn0gfSwgKi8KPiA+ICAJey5jcHVfZnJl cV9tYXggPSAxMDAwKjEwMDAqMTAwMCwgLmRpdmlkZXIgPSB7MSwgMiwgNCwgNX0gfSwKPiA+ICAJ ey5jcHVfZnJlcV9tYXggPSA4MDAqMTAwMCoxMDAwLCAgLmRpdmlkZXIgPSB7MSwgMiwgMywgNH0g fSwKPiA+ICAJey5jcHVfZnJlcV9tYXggPSA2MDAqMTAwMCoxMDAwLCAgLmRpdmlkZXIgPSB7Miwg NCwgNSwgNn0gfSwKPiA+IC0tIAo+ID4gMi4zMS4xCj4gPiAKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK