From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B41FC07E96 for ; Thu, 8 Jul 2021 15:33:47 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F715616ED for ; Thu, 8 Jul 2021 15:33:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F715616ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 438D783191; Thu, 8 Jul 2021 17:33:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="De1y4wvt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4303C831A2; Thu, 8 Jul 2021 17:33:43 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 483068318E for ; Thu, 8 Jul 2021 17:33:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2a.google.com with SMTP id i4so2521129qvq.10 for ; Thu, 08 Jul 2021 08:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7sT9SaLnqGDGC2g1tJiMhMw+GK2n2eQRV0+sK6L9HMA=; b=De1y4wvt5H8tJhOv89bG0WR4Pbou4pkc+Ytqr6jvax1n+/9C0KcHq2oyt3EKcg2/be NBMvjC8R3jkvgiSHY0qBfj9oiPVx2RAmUusX9Cjnf/CwDXNMLSq1bTFJOa53+xxZvb0j qOEhe9RFtj5C0u8X3/Di8Ke88mu3QIAN3GYBM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7sT9SaLnqGDGC2g1tJiMhMw+GK2n2eQRV0+sK6L9HMA=; b=ErhHZf0G//XIUmLqw0r/dpk8h5snJdTjW5mXnD8bDkhtrwDXugHQNzGTFtvPdwCyax iPcC4o8urPYeoe1K68MTubWKQZusdHqINiu9sh0YXaH2lRvY7bIbb9kRb1cIMtZkCN1l 530emDivcD5Gg4GEv+DNF6LgO+RltXyX/9CGp0IRlrnVDUNZwJCfIv4gi8iFP9kMCcIO tPdQ1X/lbF+qTHEvZPB935ktmK5kB3sldsMFuIK7nm0n3Vv6b52r3XE8a4z4AmwbTL8A PV4RYF/XaQQMyGPLgzZpx4TmdIGHCH45ya7UtyXHPV5KftRBM4g7VpaftcbINLyYXWZR mg8w== X-Gm-Message-State: AOAM532okqlayQvmVA4mLA3XuAqgpd8D6uHgB7D5sb27M0mH/phAh8ZU rKXoZhnHYGMacpuRZZsTq0FXnw== X-Google-Smtp-Source: ABdhPJwP4SJYBol0wd3azNHsYQajIffp5838MJ0xdNhAsGIC7v5hdza2+Qj2k9ECRq1CT9Vfmjlp3A== X-Received: by 2002:ad4:47a8:: with SMTP id a8mr7768508qvz.53.1625758414958; Thu, 08 Jul 2021 08:33:34 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-24ca-1bbe-7b3c-6375.res6.spectrum.com. [2603:6081:7b01:cbda:24ca:1bbe:7b3c:6375]) by smtp.gmail.com with ESMTPSA id k124sm1079823qkc.132.2021.07.08.08.33.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Jul 2021 08:33:34 -0700 (PDT) Date: Thu, 8 Jul 2021 11:33:32 -0400 From: Tom Rini To: Michael Nazzareno Trimarchi Cc: Marek Behun , Wolfgang Denk , Sean Anderson , U-Boot-Denx , Simon Glass , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos Subject: Re: [RFC PATCH 02/28] cli: Add LIL shell Message-ID: <20210708153332.GD9516@bill-the-cat> References: <126700.1625223815@gemini.denx.de> <8bbdb7a1-5085-a3b7-614f-12ae9aee8e8b@gmail.com> <18831.1625340810@gemini.denx.de> <20210705191058.GB9516@bill-the-cat> <192103.1625557460@gemini.denx.de> <20210706154346.GT9516@bill-the-cat> <49439.1625645734@gemini.denx.de> <20210707164800.4d43a8a8@thinkpad> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aYf6g/0xIBJIpXks" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --aYf6g/0xIBJIpXks Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 08, 2021 at 07:19:05AM +0200, Michael Nazzareno Trimarchi wrote: > Hi >=20 > On Wed, Jul 7, 2021 at 4:48 PM Marek Behun wrote: > > > > Dear Tom, Sean, Wolfgang and others, > > > > here are some of my opinions for this discussion > > > > - I agree with Wolfgang that there are far better options than > > a Tcl-like shell, if we want to add another language > > > > - I also think that instead of adding another language, it is more > > preferable to improve the existing one. Adding a new language will > > cause more problems in the future: > > - I think it can end up with OS distributions needing to write > > boot scripts in both languages, because they can't be sure which > > will be compiled into U-Boot > > - we will certainly end up with more bugs > > - userbase will fragment between the two languages > > > > - I think we can start improving the current U-Boot's shell in ways > > that are incompatible with upstream Hush. > > > > The idea back then, as I understand it, was to minimize man-hours > > invested into the CLI code, and so an existing shell was incorporated > > (with many #ifdef guards). But U-Boot has since evolved so much that > > it is very probable it would be more economic to simply fork from > > upsteam Hush, remove all the #ifdefs and start developing features we > > want in U-Boot. Is upstream Hush even maintained properly? > > What is the upstream repository? Is it > > https://github.com/sheumann/hush? > > >=20 > I think that hush is the one that is now in the busybox. I could spent > ten minutes this morning and this is my short list: >=20 > - we have several define that allow it to enabled e/o disable a lot of fe= atures > - we are talking about 11K lines compared to 3K (including comment) > - we have 25-30 configuration option on hush on busybox > - in u-boot code some of the problem was solved some time ago > - as describe is 68Kb, I think this consider all the option enables > - the code is different from what we have and what is there >=20 > I don't know if options like ENABLE_HUSH_JOB and ENABLE_MMU can partially > solve some of the problems described in the thread >=20 > * Sean *: You have spent more on this, can you please complete it. >=20 > Out of that. Do we have some script shell unit test in uboot? To the last point, yes, we have some, but always need more, tests for how hush behaves as part of pytest. --=20 Tom --aYf6g/0xIBJIpXks Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDnGsgACgkQFHw5/5Y0 tywLDQv/eQMUaSkWSqvlK+fu2DRUOe2JnFzu097j4fyTePrGFtkAjbXuESJMvnDY 23CQMTLnfHADFIxce1lSuX24uRz+ktVljA1UrT4pCqxO4CAC5ClHdPPSxSWBOvrp 9OEnH0Pz9CjQq20FbHv2BaqoGif4NGgeUFXpzSpEDIXJ666pUa7ZbsT56jfKr2ik mJtqz0LD/zAwInV4/XAz4mx5h5tIcoJnSpWoDUFzWEhw1OvW1DvvnOOx8i4Oscvl Xl7eO9l+OBEn+9APh8oTFJUewH48hprX/vsajM2nuK6wlAXkts9n6y6bDPfQJDkf cR+/hHXYSRKahMBvpy4DeDJv+5zMnOY8k4HHtCNxCgdA5jqPdEa2ucgZaHnEhpk6 AqTIEzsOCKOniBI/SS7tD1f11fmO2M0qi/admQSAeKTbFEXO5/ewkkgfakDzuZv+ TQgZSlshBTg2GwMuZqdGnw/x52EYofzFQ2tpnREdrPbWhY8CyFmhbCUvouSKHfsl cz6YvSg9 =Jcul -----END PGP SIGNATURE----- --aYf6g/0xIBJIpXks--