From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6591BC07E99 for ; Thu, 8 Jul 2021 14:15:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B69361263 for ; Thu, 8 Jul 2021 14:15:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231937AbhGHOSY convert rfc822-to-8bit (ORCPT ); Thu, 8 Jul 2021 10:18:24 -0400 Received: from mslow1.mail.gandi.net ([217.70.178.240]:60291 "EHLO mslow1.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbhGHOSX (ORCPT ); Thu, 8 Jul 2021 10:18:23 -0400 Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 37B69C46A2; Thu, 8 Jul 2021 14:13:58 +0000 (UTC) Received: (Authenticated sender: clement.leger@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id DEEA2C000A; Thu, 8 Jul 2021 14:13:34 +0000 (UTC) Date: Thu, 8 Jul 2021 16:13:34 +0200 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Alexandre Belloni Cc: Stephen Boyd , Michael Turquette , linux-kernel@vger.kernel.org, Ludovic Desroches , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk: at91: fix count of periph clocks passed to pmc_data_allocate Message-ID: <20210708161334.039d09fb@fixe.home> In-Reply-To: References: <20210609080145.44226-1-clement.leger@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le Wed, 9 Jun 2021 10:31:01 +0200, Alexandre Belloni a écrit : > hi, > > Subject should have been: > clk: at91: sama5d2: fix count of periph clocks passed to > pmc_data_allocate > This patch can actually be discarded since it won't fix allocation at all but will just allocate more data than needed since nck already returns the max .id field of the periph array. > > > On 09/06/2021 10:01:44+0200, Clément Léger wrote: > > When allocating clk_hw structure, only the periph32 clocks are > > considered. Since sama5d2_periphck are also added to the phws there > > is currently an out of bound write. Fix this by adding the count of > > periphck to periph32ck. > > > > Signed-off-by: Clément Léger > Fixes: a2038077de9a ("clk: at91: add sama5d2 PMC driver") > > > --- > > drivers/clk/at91/sama5d2.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clk/at91/sama5d2.c b/drivers/clk/at91/sama5d2.c > > index 3d1f78176c3e..663b73a032ee 100644 > > --- a/drivers/clk/at91/sama5d2.c > > +++ b/drivers/clk/at91/sama5d2.c > > @@ -170,7 +170,7 @@ static void __init sama5d2_pmc_setup(struct > > device_node *np) > > sama5d2_pmc = pmc_data_allocate(PMC_AUDIOPLLCK + 1, > > nck(sama5d2_systemck), > > - nck(sama5d2_periph32ck), > > + nck(sama5d2_periphck) + > > nck(sama5d2_periph32ck), nck(sama5d2_gck), 3); > > if (!sama5d2_pmc) > > return; > > -- > > 2.32.0 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57ECC07E9C for ; Thu, 8 Jul 2021 14:15:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8991661178 for ; Thu, 8 Jul 2021 14:15:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8991661178 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XckXxmroXsatM2cNSG3byLwfKNZvKIHlXuoZ+jYGqDg=; b=Ju3mfODHFVyLLe 5ZrMhd2PrHSH38bnAJWkLyYNEJ60VR7Qoi6qOftlgrKQ3dkWaE4owhnJFLJh2AmJnBid1ouxsps/T lSQqsLhFJcXf5Gd4i6gzae1ogUwq+jXBjFm5UFgotCEK8gV9WSAXeY01nC6tiheCxX2VqTJyw9ZPn Fvg/NmbsiIHTwKAK5HgmXGVE0ftl6bHdz+rM+gg4n57K1k68viTB9AqHwAHn1btWps1bb7zJF1M9W W51e3gj11cZ+CxpahAOTLJUcUo48UgfYhbUUQ3HGW6jlCau2hjeVBopOTJAUGP828s8T5d+u7Gryl vIqBUgyC21Zmn/aEfQnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1Umf-00HAaI-Lu; Thu, 08 Jul 2021 14:13:45 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1Umb-00HAZv-Al for linux-arm-kernel@lists.infradead.org; Thu, 08 Jul 2021 14:13:43 +0000 Received: (Authenticated sender: clement.leger@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id DEEA2C000A; Thu, 8 Jul 2021 14:13:34 +0000 (UTC) Date: Thu, 8 Jul 2021 16:13:34 +0200 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Alexandre Belloni Cc: Stephen Boyd , Michael Turquette , linux-kernel@vger.kernel.org, Ludovic Desroches , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk: at91: fix count of periph clocks passed to pmc_data_allocate Message-ID: <20210708161334.039d09fb@fixe.home> In-Reply-To: References: <20210609080145.44226-1-clement.leger@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210708_071341_557389_965FA28A X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpMZSBXZWQsIDkgSnVuIDIwMjEgMTA6MzE6MDEgKzAyMDAsCkFsZXhhbmRyZSBCZWxsb25p IDxhbGV4YW5kcmUuYmVsbG9uaUBib290bGluLmNvbT4gYSDDqWNyaXQgOgoKPiBoaSwKPiAKPiBT dWJqZWN0IHNob3VsZCBoYXZlIGJlZW46Cj4gY2xrOiBhdDkxOiBzYW1hNWQyOiBmaXggY291bnQg b2YgcGVyaXBoIGNsb2NrcyBwYXNzZWQgdG8KPiBwbWNfZGF0YV9hbGxvY2F0ZQo+IAoKVGhpcyBw YXRjaCBjYW4gYWN0dWFsbHkgYmUgZGlzY2FyZGVkIHNpbmNlIGl0IHdvbid0IGZpeCBhbGxvY2F0 aW9uIGF0CmFsbCBidXQgd2lsbCBqdXN0IGFsbG9jYXRlIG1vcmUgZGF0YSB0aGFuIG5lZWRlZCBz aW5jZSBuY2sgYWxyZWFkeQpyZXR1cm5zIHRoZSBtYXggLmlkIGZpZWxkIG9mIHRoZSBwZXJpcGgg YXJyYXkuCgo+IAo+IAo+IE9uIDA5LzA2LzIwMjEgMTA6MDE6NDQrMDIwMCwgQ2zDqW1lbnQgTMOp Z2VyIHdyb3RlOgo+ID4gV2hlbiBhbGxvY2F0aW5nIGNsa19odyBzdHJ1Y3R1cmUsIG9ubHkgdGhl IHBlcmlwaDMyIGNsb2NrcyBhcmUKPiA+IGNvbnNpZGVyZWQuIFNpbmNlIHNhbWE1ZDJfcGVyaXBo Y2sgYXJlIGFsc28gYWRkZWQgdG8gdGhlIHBod3MgdGhlcmUKPiA+IGlzIGN1cnJlbnRseSBhbiBv dXQgb2YgYm91bmQgd3JpdGUuIEZpeCB0aGlzIGJ5IGFkZGluZyB0aGUgY291bnQgb2YKPiA+IHBl cmlwaGNrIHRvIHBlcmlwaDMyY2suCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IENsw6ltZW50IEzD qWdlciA8Y2xlbWVudC5sZWdlckBib290bGluLmNvbT4gIAo+IEZpeGVzOiBhMjAzODA3N2RlOWEg KCJjbGs6IGF0OTE6IGFkZCBzYW1hNWQyIFBNQyBkcml2ZXIiKQo+IAo+ID4gLS0tCj4gPiAgZHJp dmVycy9jbGsvYXQ5MS9zYW1hNWQyLmMgfCAyICstCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2Ns ay9hdDkxL3NhbWE1ZDIuYyBiL2RyaXZlcnMvY2xrL2F0OTEvc2FtYTVkMi5jCj4gPiBpbmRleCAz ZDFmNzgxNzZjM2UuLjY2M2I3M2EwMzJlZSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvY2xrL2F0 OTEvc2FtYTVkMi5jCj4gPiArKysgYi9kcml2ZXJzL2Nsay9hdDkxL3NhbWE1ZDIuYwo+ID4gQEAg LTE3MCw3ICsxNzAsNyBAQCBzdGF0aWMgdm9pZCBfX2luaXQgc2FtYTVkMl9wbWNfc2V0dXAoc3Ry dWN0Cj4gPiBkZXZpY2Vfbm9kZSAqbnApIAo+ID4gIAlzYW1hNWQyX3BtYyA9IHBtY19kYXRhX2Fs bG9jYXRlKFBNQ19BVURJT1BMTENLICsgMSwKPiA+ICAJCQkJCW5jayhzYW1hNWQyX3N5c3RlbWNr KSwKPiA+IC0JCQkJCW5jayhzYW1hNWQyX3BlcmlwaDMyY2spLAo+ID4gKwkJCQkJbmNrKHNhbWE1 ZDJfcGVyaXBoY2spICsKPiA+IG5jayhzYW1hNWQyX3BlcmlwaDMyY2spLCBuY2soc2FtYTVkMl9n Y2spLCAzKTsKPiA+ICAJaWYgKCFzYW1hNWQyX3BtYykKPiA+ICAJCXJldHVybjsKPiA+IC0tIAo+ ID4gMi4zMi4wCj4gPiAgIAo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK