All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v3 00/28] accel/tcg: Introduce translator_use_goto_tb
Date: Thu,  8 Jul 2021 09:40:22 -0700	[thread overview]
Message-ID: <20210708164050.711967-1-richard.henderson@linaro.org> (raw)

There are a number of inconsistencies with goto_tb usage, and I
plan to make changes in order to better support breakpoints.

(1) Testing CF_LAST_IO is a hold-over from since before ba3e7926691
    ("icount: clean up cpu_can_io at the entry to the block").
    Several targets still have this test.

(2) Testing singlestep is superfluous, as it doesn't mean anything
    besides limiting max_insns to 1.

(3) Not testing page crossing for CONFIG_USER_ONLY is wrong, because
    mmap and mprotect can change page permissions.  It's a very
    uncommon case wrt executables, but it's still wrong.

(4) Not testing page crossing for non-mmu targets (where page
    permissions literally cannot change) is not currently wrong,
    but will be after the breakpoint changes.

(5) When the TB does cross two pages, considering non-page crossing
    from the second page is not currently wrong, but will be after
    the breakpoint changes.

Changes for v3:
  * Adjust aarch32 ISB, SB change to simply set is_jmp.

Changes for v2:
  * Fix aarch32 ISB, SB insns vs single-stepping.
  * Drop use_goto_tb for aarch32
  * Retain use_goto_tb for aarch64.

Patches lacking review:
  05-target-arm-Use-DISAS_TOO_MANY-for-ISB-and-SB.patch


r~


Richard Henderson (28):
  accel/tcg: Introduce translator_use_goto_tb
  target/alpha: Remove use_exit_tb
  target/alpha: Remove in_superpage
  target/alpha: Use translator_use_goto_tb
  target/arm: Use DISAS_TOO_MANY for ISB and SB
  target/arm: Use translator_use_goto_tb for aarch64
  target/arm: Use translator_use_goto_tb for aarch32
  target/avr: Use translator_use_goto_tb
  target/avr: Mark some helpers noreturn
  target/cris: Use translator_use_goto_tb
  target/hppa: Use translator_use_goto_tb
  target/i386: Use translator_use_goto_tb
  target/m68k: Use translator_use_goto_tb
  target/microblaze: Use translator_use_goto_tb
  target/mips: Use translator_use_goto_tb
  target/mips: Fix missing else in gen_goto_tb
  target/nios2: Use translator_use_goto_tb
  target/openrisc: Use translator_use_goto_tb
  target/ppc: Use translator_use_goto_tb
  target/riscv: Use translator_use_goto_tb
  target/rx: Use translator_use_goto_tb
  target/s390x: Use translator_use_goto_tb
  target/s390x: Remove use_exit_tb
  target/sh4: Use translator_use_goto_tb
  target/sparc: Use translator_use_goto_tb
  target/tricore: Use translator_use_goto_tb
  target/tricore: Use tcg_gen_lookup_and_goto_ptr
  target/xtensa: Use translator_use_goto_tb

 include/exec/translator.h     | 10 ++++++++
 target/avr/helper.h           |  8 +++---
 accel/tcg/translator.c        | 11 +++++++++
 target/alpha/translate.c      | 46 ++++-------------------------------
 target/arm/translate-a64.c    | 25 ++++---------------
 target/arm/translate.c        | 16 +++---------
 target/avr/translate.c        |  9 ++++---
 target/cris/translate.c       |  5 ++--
 target/hppa/translate.c       |  5 +---
 target/i386/tcg/translate.c   | 14 ++---------
 target/m68k/translate.c       | 12 +--------
 target/microblaze/translate.c | 11 +--------
 target/mips/tcg/translate.c   | 20 +++------------
 target/nios2/translate.c      | 15 +-----------
 target/openrisc/translate.c   | 15 ++++++------
 target/ppc/translate.c        | 10 +-------
 target/riscv/translate.c      | 20 +--------------
 target/rx/translate.c         | 11 +--------
 target/s390x/translate.c      | 18 +++-----------
 target/sh4/translate.c        | 11 +++------
 target/sparc/translate.c      | 19 ++++-----------
 target/tricore/translate.c    | 20 +++------------
 target/xtensa/translate.c     |  6 +----
 23 files changed, 83 insertions(+), 254 deletions(-)

-- 
2.25.1



             reply	other threads:[~2021-07-08 16:54 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 16:40 Richard Henderson [this message]
2021-07-08 16:40 ` [PATCH v3 01/28] " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 02/28] target/alpha: Remove use_exit_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 03/28] target/alpha: Remove in_superpage Richard Henderson
2021-07-08 16:40 ` [PATCH v3 04/28] target/alpha: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 05/28] target/arm: Use DISAS_TOO_MANY for ISB and SB Richard Henderson
2021-07-08 16:40 ` [PATCH v3 06/28] target/arm: Use translator_use_goto_tb for aarch64 Richard Henderson
2021-07-08 16:40 ` [PATCH v3 07/28] target/arm: Use translator_use_goto_tb for aarch32 Richard Henderson
2021-07-08 16:40 ` [PATCH v3 08/28] target/avr: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 09/28] target/avr: Mark some helpers noreturn Richard Henderson
2021-07-08 16:40 ` [PATCH v3 10/28] target/cris: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 11/28] target/hppa: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 12/28] target/i386: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 13/28] target/m68k: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 14/28] target/microblaze: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 15/28] target/mips: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 16/28] target/mips: Fix missing else in gen_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 17/28] target/nios2: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 18/28] target/openrisc: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 19/28] target/ppc: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 20/28] target/riscv: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 21/28] target/rx: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 22/28] target/s390x: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 23/28] target/s390x: Remove use_exit_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 24/28] target/sh4: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 25/28] target/sparc: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 26/28] target/tricore: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 27/28] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2021-07-08 16:40 ` [PATCH v3 28/28] target/xtensa: Use translator_use_goto_tb Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210708164050.711967-1-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: [PATCH v3 00/28] accel/tcg: Introduce translator_use_goto_tb' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.