From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Subject: [PATCH v3 25/28] target/sparc: Use translator_use_goto_tb Date: Thu, 8 Jul 2021 09:40:47 -0700 [thread overview] Message-ID: <20210708164050.711967-26-richard.henderson@linaro.org> (raw) In-Reply-To: <20210708164050.711967-1-richard.henderson@linaro.org> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/sparc/translate.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 4bfa3179f8..fb0c242606 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -339,23 +339,14 @@ static inline TCGv gen_dest_gpr(DisasContext *dc, int reg) } } -static inline bool use_goto_tb(DisasContext *s, target_ulong pc, - target_ulong npc) +static bool use_goto_tb(DisasContext *s, target_ulong pc, target_ulong npc) { - if (unlikely(s->base.singlestep_enabled || singlestep)) { - return false; - } - -#ifndef CONFIG_USER_ONLY - return (pc & TARGET_PAGE_MASK) == (s->base.tb->pc & TARGET_PAGE_MASK) && - (npc & TARGET_PAGE_MASK) == (s->base.tb->pc & TARGET_PAGE_MASK); -#else - return true; -#endif + return translator_use_goto_tb(&s->base, pc) && + translator_use_goto_tb(&s->base, npc); } -static inline void gen_goto_tb(DisasContext *s, int tb_num, - target_ulong pc, target_ulong npc) +static void gen_goto_tb(DisasContext *s, int tb_num, + target_ulong pc, target_ulong npc) { if (use_goto_tb(s, pc, npc)) { /* jump to same page: we can use a direct jump */ -- 2.25.1
next prev parent reply other threads:[~2021-07-08 17:15 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-08 16:40 [PATCH v3 00/28] accel/tcg: Introduce translator_use_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 01/28] " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 02/28] target/alpha: Remove use_exit_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 03/28] target/alpha: Remove in_superpage Richard Henderson 2021-07-08 16:40 ` [PATCH v3 04/28] target/alpha: Use translator_use_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 05/28] target/arm: Use DISAS_TOO_MANY for ISB and SB Richard Henderson 2021-07-08 16:40 ` [PATCH v3 06/28] target/arm: Use translator_use_goto_tb for aarch64 Richard Henderson 2021-07-08 16:40 ` [PATCH v3 07/28] target/arm: Use translator_use_goto_tb for aarch32 Richard Henderson 2021-07-08 16:40 ` [PATCH v3 08/28] target/avr: Use translator_use_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 09/28] target/avr: Mark some helpers noreturn Richard Henderson 2021-07-08 16:40 ` [PATCH v3 10/28] target/cris: Use translator_use_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 11/28] target/hppa: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 12/28] target/i386: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 13/28] target/m68k: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 14/28] target/microblaze: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 15/28] target/mips: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 16/28] target/mips: Fix missing else in gen_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 17/28] target/nios2: Use translator_use_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 18/28] target/openrisc: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 19/28] target/ppc: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 20/28] target/riscv: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 21/28] target/rx: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 22/28] target/s390x: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 23/28] target/s390x: Remove use_exit_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 24/28] target/sh4: Use translator_use_goto_tb Richard Henderson 2021-07-08 16:40 ` Richard Henderson [this message] 2021-07-08 16:40 ` [PATCH v3 26/28] target/tricore: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 27/28] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson 2021-07-08 16:40 ` [PATCH v3 28/28] target/xtensa: Use translator_use_goto_tb Richard Henderson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210708164050.711967-26-richard.henderson@linaro.org \ --to=richard.henderson@linaro.org \ --cc=mark.cave-ayland@ilande.co.uk \ --cc=qemu-devel@nongnu.org \ --subject='Re: [PATCH v3 25/28] target/sparc: Use translator_use_goto_tb' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.