All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [PATCH v3 06/28] target/arm: Use translator_use_goto_tb for aarch64
Date: Thu,  8 Jul 2021 09:40:28 -0700	[thread overview]
Message-ID: <20210708164050.711967-7-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210708164050.711967-1-richard.henderson@linaro.org>

We have not needed to end a TB for I/O since ba3e7926691
("icount: clean up cpu_can_io at the entry to the block"),
and gdbstub singlestep is handled by the generic function.

Drop the unused 'n' argument to use_goto_tb.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/translate-a64.c | 25 +++++--------------------
 1 file changed, 5 insertions(+), 20 deletions(-)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index e81cc20d04..856a689b90 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -386,35 +386,20 @@ static void gen_step_complete_exception(DisasContext *s)
     s->base.is_jmp = DISAS_NORETURN;
 }
 
-static inline bool use_goto_tb(DisasContext *s, int n, uint64_t dest)
+static inline bool use_goto_tb(DisasContext *s, uint64_t dest)
 {
-    /* No direct tb linking with singlestep (either QEMU's or the ARM
-     * debug architecture kind) or deterministic io
-     */
-    if (s->base.singlestep_enabled || s->ss_active ||
-        (tb_cflags(s->base.tb) & CF_LAST_IO)) {
+    if (s->ss_active) {
         return false;
     }
-
-#ifndef CONFIG_USER_ONLY
-    /* Only link tbs from inside the same guest page */
-    if ((s->base.tb->pc & TARGET_PAGE_MASK) != (dest & TARGET_PAGE_MASK)) {
-        return false;
-    }
-#endif
-
-    return true;
+    return translator_use_goto_tb(&s->base, dest);
 }
 
 static inline void gen_goto_tb(DisasContext *s, int n, uint64_t dest)
 {
-    const TranslationBlock *tb;
-
-    tb = s->base.tb;
-    if (use_goto_tb(s, n, dest)) {
+    if (use_goto_tb(s, dest)) {
         tcg_gen_goto_tb(n);
         gen_a64_set_pc_im(dest);
-        tcg_gen_exit_tb(tb, n);
+        tcg_gen_exit_tb(s->base.tb, n);
         s->base.is_jmp = DISAS_NORETURN;
     } else {
         gen_a64_set_pc_im(dest);
-- 
2.25.1



  parent reply	other threads:[~2021-07-08 17:09 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 16:40 [PATCH v3 00/28] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 01/28] " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 02/28] target/alpha: Remove use_exit_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 03/28] target/alpha: Remove in_superpage Richard Henderson
2021-07-08 16:40 ` [PATCH v3 04/28] target/alpha: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 05/28] target/arm: Use DISAS_TOO_MANY for ISB and SB Richard Henderson
2021-07-08 16:40 ` Richard Henderson [this message]
2021-07-08 16:40 ` [PATCH v3 07/28] target/arm: Use translator_use_goto_tb for aarch32 Richard Henderson
2021-07-08 16:40 ` [PATCH v3 08/28] target/avr: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 09/28] target/avr: Mark some helpers noreturn Richard Henderson
2021-07-08 16:40 ` [PATCH v3 10/28] target/cris: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 11/28] target/hppa: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 12/28] target/i386: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 13/28] target/m68k: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 14/28] target/microblaze: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 15/28] target/mips: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 16/28] target/mips: Fix missing else in gen_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 17/28] target/nios2: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 18/28] target/openrisc: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 19/28] target/ppc: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 20/28] target/riscv: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 21/28] target/rx: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 22/28] target/s390x: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 23/28] target/s390x: Remove use_exit_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 24/28] target/sh4: Use translator_use_goto_tb Richard Henderson
2021-07-08 16:40 ` [PATCH v3 25/28] target/sparc: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 26/28] target/tricore: " Richard Henderson
2021-07-08 16:40 ` [PATCH v3 27/28] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2021-07-08 16:40 ` [PATCH v3 28/28] target/xtensa: Use translator_use_goto_tb Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210708164050.711967-7-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: [PATCH v3 06/28] target/arm: Use translator_use_goto_tb for aarch64' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.