From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Cc: Peter Maydell <peter.maydell@linaro.org> Subject: [PATCH v3 08/28] target/avr: Use translator_use_goto_tb Date: Thu, 8 Jul 2021 09:40:30 -0700 [thread overview] Message-ID: <20210708164050.711967-9-richard.henderson@linaro.org> (raw) In-Reply-To: <20210708164050.711967-1-richard.henderson@linaro.org> Single stepping is not the only reason not to use goto_tb. If goto_tb is disallowed, and single-stepping is not enabled, then use tcg_gen_lookup_and_goto_tb to indirectly chain. Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/avr/translate.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index c06ce45bc7..8237a03c23 100644 --- a/target/avr/translate.c +++ b/target/avr/translate.c @@ -1083,14 +1083,17 @@ static void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest) { const TranslationBlock *tb = ctx->base.tb; - if (!ctx->base.singlestep_enabled) { + if (translator_use_goto_tb(&ctx->base, dest)) { tcg_gen_goto_tb(n); tcg_gen_movi_i32(cpu_pc, dest); tcg_gen_exit_tb(tb, n); } else { tcg_gen_movi_i32(cpu_pc, dest); - gen_helper_debug(cpu_env); - tcg_gen_exit_tb(NULL, 0); + if (ctx->base.singlestep_enabled) { + gen_helper_debug(cpu_env); + } else { + tcg_gen_lookup_and_goto_ptr(); + } } ctx->base.is_jmp = DISAS_NORETURN; } -- 2.25.1
next prev parent reply other threads:[~2021-07-08 16:59 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-08 16:40 [PATCH v3 00/28] accel/tcg: Introduce translator_use_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 01/28] " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 02/28] target/alpha: Remove use_exit_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 03/28] target/alpha: Remove in_superpage Richard Henderson 2021-07-08 16:40 ` [PATCH v3 04/28] target/alpha: Use translator_use_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 05/28] target/arm: Use DISAS_TOO_MANY for ISB and SB Richard Henderson 2021-07-08 16:40 ` [PATCH v3 06/28] target/arm: Use translator_use_goto_tb for aarch64 Richard Henderson 2021-07-08 16:40 ` [PATCH v3 07/28] target/arm: Use translator_use_goto_tb for aarch32 Richard Henderson 2021-07-08 16:40 ` Richard Henderson [this message] 2021-07-08 16:40 ` [PATCH v3 09/28] target/avr: Mark some helpers noreturn Richard Henderson 2021-07-08 16:40 ` [PATCH v3 10/28] target/cris: Use translator_use_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 11/28] target/hppa: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 12/28] target/i386: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 13/28] target/m68k: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 14/28] target/microblaze: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 15/28] target/mips: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 16/28] target/mips: Fix missing else in gen_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 17/28] target/nios2: Use translator_use_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 18/28] target/openrisc: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 19/28] target/ppc: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 20/28] target/riscv: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 21/28] target/rx: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 22/28] target/s390x: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 23/28] target/s390x: Remove use_exit_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 24/28] target/sh4: Use translator_use_goto_tb Richard Henderson 2021-07-08 16:40 ` [PATCH v3 25/28] target/sparc: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 26/28] target/tricore: " Richard Henderson 2021-07-08 16:40 ` [PATCH v3 27/28] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson 2021-07-08 16:40 ` [PATCH v3 28/28] target/xtensa: Use translator_use_goto_tb Richard Henderson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210708164050.711967-9-richard.henderson@linaro.org \ --to=richard.henderson@linaro.org \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ --subject='Re: [PATCH v3 08/28] target/avr: Use translator_use_goto_tb' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.