All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathew McBride <matt@traverse.com.au>
To: linux-rtc@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org
Cc: Mathew McBride <matt@traverse.com.au>
Subject: [PATCH v2 0/2] rtc: Implement support for EPSON RX-8035
Date: Fri,  9 Jul 2021 04:45:16 +0000	[thread overview]
Message-ID: <20210709044518.28769-1-matt@traverse.com.au> (raw)

The EPSON RX-8035[SA] is a I2C real time clock module with
built-in oscillator[1]. It is a very close relative of the EPSON
RX-8025 that is supported by the rtc-rx8025 driver.

The main difference is that the RX-8035 has inverted the
'oscillator stop' bit in the control register. The operation
of the devices is otherwise identical for the features currently
supported.

Curiously, the RX-8025 is also supported by the ds1307 driver
as the time register set is compatible. The control registers,
however, are not.

I have decided to implement the RX-8035 in rtc-rx8025 due the simplicity
of that driver.

As best as I can determine, the rtc-rx8025 driver was in the tree
some months[1] before rx8025 support was added to ds1307[2].

[1] - https://www5.epsondevice.com/en/products/rtc/rx8035sa.html
[2] - commit 3c2b9075cbdb541dbe486bde45925c9610de6f35
[3] - commit a216685818a54b4f15235068b53908f954850251

Changes in v2:
Coding style fixes as per suggestions
Use 'model' instead of 'type' in drvdata
Call rx8025_is_osc_stopped in a consistent manner

Mathew McBride (2):
  rtc: rx8025: implement RX-8035 support
  dt-bindings: rtc: add Epson RX-8025 and RX-8035

 .../devicetree/bindings/rtc/trivial-rtc.yaml  |  3 +
 drivers/rtc/rtc-rx8025.c                      | 59 +++++++++++++++++--
 2 files changed, 57 insertions(+), 5 deletions(-)

-- 
2.30.1


             reply	other threads:[~2021-07-09  4:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09  4:45 Mathew McBride [this message]
2021-07-09  4:45 ` [PATCH v2 1/2] rtc: rx8025: implement RX-8035 support Mathew McBride
2021-07-19  8:15   ` Nobuhiro Iwamatsu
2021-07-09  4:45 ` [PATCH v2 2/2] dt-bindings: rtc: add Epson RX-8025 and RX-8035 Mathew McBride
2021-07-14 23:15   ` Rob Herring
2021-07-19  8:18   ` Nobuhiro Iwamatsu
2021-08-17 22:08 ` [PATCH v2 0/2] rtc: Implement support for EPSON RX-8035 Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210709044518.28769-1-matt@traverse.com.au \
    --to=matt@traverse.com.au \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.