From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DDAC07E9B for ; Fri, 9 Jul 2021 09:57:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9DC7613CC for ; Fri, 9 Jul 2021 09:57:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232080AbhGIKAB (ORCPT ); Fri, 9 Jul 2021 06:00:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231889AbhGIKAA (ORCPT ); Fri, 9 Jul 2021 06:00:00 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75FE6C0613DD; Fri, 9 Jul 2021 02:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IrbycDAuQ3MUvmas9RXbsQxlkhqcD9Mn93U+OHYoQbQ=; b=dHK7uFZKHgXI7RgD+Fplit5uF WGjmxe7ihLF5RF7Jlr49Yo9qeDvAQYwYGFs4scDveaLIg6c95mSP2tP/USQGmheDtTdPVIhnbo284 YcXRGWCAwVtp6vg0CX+VFD7LvfJzxWJ86nUodfp9Dgk01iX7+Ixoo+7Gxujp7F2ByRKVWLy1oF/kd 44q/z2pF6dXvaHAaAmpuELe3Tv+vQCUBLUPkEX3TgrgPZeD8eEQLujbFO54H09e17OH3owSKabjk+ ewuA/xI3p5EVFTIm5vqzLzJbLbNPWC9LQyRo7ozWFwDF49bBQ4AMu+07gMl3S8Y6tJWEOo2xyUHfY lJlp5Enaw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45904) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1nFq-0001gB-JO; Fri, 09 Jul 2021 10:57:06 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1m1nFm-0004rK-TB; Fri, 09 Jul 2021 10:57:02 +0100 Date: Fri, 9 Jul 2021 10:57:02 +0100 From: "Russell King (Oracle)" To: Florian Fainelli Cc: "Ismail, Mohammad Athari" , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Jakub Kicinski , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net] net: phy: reconfigure PHY WOL in resume if WOL option still enabled Message-ID: <20210709095702.GX22278@shell.armlinux.org.uk> References: <20210708004253.6863-1-mohammad.athari.ismail@intel.com> <4e159b98-ec02-33b7-862a-0e35832c3a5f@gmail.com> <9871a015-bcfb-0bdb-c481-5e8f2356e5ba@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9871a015-bcfb-0bdb-c481-5e8f2356e5ba@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 08, 2021 at 09:41:45AM -0700, Florian Fainelli wrote: > During S4 resume (disk), I suppose that you have to involve the boot > loader to restore the DRAM image from the storage disk, and so that does > effectively look like a quasi cold boot from the kernel? If so, that > should still lead to config_init() being called when the PHY is > attached, no? Don't forget that when resuming from S4, we effectively boot the kernel normally, then check whether we are resuming, before we then start loading the resume image, suspend the current kernel, shuffle the pages around, and resume the original kernel. What that means is that a PHY will see the effects of a normal kernel boot before we resume the original kernel. If a PHY driver (e.g.) disables features such as WOL and we do not restore these settings on resume, then those settings will be reset. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!