All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Zhong <yang.zhong@intel.com>
To: qemu-devel@nongnu.org
Cc: yang.zhong@intel.com, seanjc@google.com, kai.huang@intel.com,
	jarkko@kernel.org, pbonzini@redhat.com, eblake@redhat.com
Subject: [PATCH v3 28/33] i386: Add sgx_get_info() interface
Date: Fri,  9 Jul 2021 19:09:50 +0800	[thread overview]
Message-ID: <20210709110955.73256-29-yang.zhong@intel.com> (raw)
In-Reply-To: <20210709110955.73256-1-yang.zhong@intel.com>

Add the sgx_get_info() interface for hmp and QMP usage, which
will get the SGX info from this API.

Signed-off-by: Yang Zhong <yang.zhong@intel.com>
---
 hw/i386/sgx.c             | 23 +++++++++++++++++++++++
 include/hw/i386/pc.h      |  1 +
 include/hw/i386/sgx-epc.h |  1 +
 monitor/hmp-cmds.c        | 20 ++++++++++++++++++--
 monitor/qmp-cmds.c        | 12 ++++++++++--
 stubs/meson.build         |  1 +
 stubs/sgx-stub.c          |  7 +++++++
 7 files changed, 61 insertions(+), 4 deletions(-)
 create mode 100644 stubs/sgx-stub.c

diff --git a/hw/i386/sgx.c b/hw/i386/sgx.c
index 8f322e4e3d..cbc8da94cc 100644
--- a/hw/i386/sgx.c
+++ b/hw/i386/sgx.c
@@ -18,6 +18,29 @@
 #include "qapi/error.h"
 #include "exec/address-spaces.h"
 
+SGXInfo *sgx_get_info(void)
+{
+    SGXInfo *info = NULL;
+    MachineState *ms = MACHINE(qdev_get_machine());
+
+    if (ms->sgx_epc.memdev) {
+        PCMachineState *pcms = PC_MACHINE(ms);
+        SGXEPCState *sgx_epc = pcms->sgx_epc;
+
+        info = g_new0(SGXInfo, 1);
+
+        info->sgx = true;
+        info->sgx1 = true;
+        info->sgx2 = true;
+        info->flc = true;
+
+        if (sgx_epc) {
+            info->section_size = sgx_epc->size;
+        }
+    }
+    return info;
+}
+
 int sgx_epc_get_section(int section_nr, uint64_t *addr, uint64_t *size)
 {
     PCMachineState *pcms = PC_MACHINE(qdev_get_machine());
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index f603e2f75a..2dba83aee2 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -204,6 +204,7 @@ extern const size_t pc_compat_6_0_len;
 void pc_machine_init_sgx_epc(PCMachineState *pcms);
 void sgx_memory_backend_reset(HostMemoryBackend *backend, int fd,
                               Error **errp);
+SGXInfo *sgx_get_info(void);
 
 extern GlobalProperty pc_compat_5_2[];
 extern const size_t pc_compat_5_2_len;
diff --git a/include/hw/i386/sgx-epc.h b/include/hw/i386/sgx-epc.h
index 155e8fad3e..8f9c7becb9 100644
--- a/include/hw/i386/sgx-epc.h
+++ b/include/hw/i386/sgx-epc.h
@@ -13,6 +13,7 @@
 #define QEMU_SGX_EPC_H
 
 #include "sysemu/hostmem.h"
+#include "qapi/qapi-types-misc.h"
 
 #define TYPE_SGX_EPC "sgx-epc"
 #define SGX_EPC(obj) \
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 9ebc86190f..053d210535 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -2233,6 +2233,22 @@ void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict)
 
 void hmp_info_sgx(Monitor *mon, const QDict *qdict)
 {
-    error_setg(errp, QERR_FEATURE_DISABLED, "query-sgx");
-    return NULL;
+    SGXInfo *info = qmp_query_sgx(NULL);
+
+    if (info && info->sgx) {
+        monitor_printf(mon, "SGX support: %s\n",
+                       info->sgx ? "enabled" : "disabled");
+        monitor_printf(mon, "SGX1 support: %s\n",
+                       info->sgx1 ? "enabled" : "disabled");
+        monitor_printf(mon, "SGX2 support: %s\n",
+                       info->sgx2 ? "enabled" : "disabled");
+        monitor_printf(mon, "FLC support: %s\n",
+                       info->flc ? "enabled" : "disabled");
+        monitor_printf(mon, "size: %" PRIu64 "\n",
+                       info->section_size);
+    } else {
+        monitor_printf(mon, "SGX is not enabled\n");
+    }
+
+    qapi_free_SGXInfo(info);
 }
diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c
index d63d59149f..48f7708ffe 100644
--- a/monitor/qmp-cmds.c
+++ b/monitor/qmp-cmds.c
@@ -40,6 +40,7 @@
 #include "qapi/qmp/qerror.h"
 #include "hw/mem/memory-device.h"
 #include "hw/acpi/acpi_dev_interface.h"
+#include "hw/i386/pc.h"
 
 NameInfo *qmp_query_name(Error **errp)
 {
@@ -354,6 +355,13 @@ void qmp_display_reload(DisplayReloadOptions *arg, Error **errp)
 
 SGXInfo *qmp_query_sgx(Error **errp)
 {
-    error_setg(errp, QERR_FEATURE_DISABLED, "query-sgx");
-    return NULL;
+    SGXInfo *info;
+
+    info = sgx_get_info();
+    if (!info) {
+        error_setg(errp, "SGX features are not available");
+        return NULL;
+    }
+
+    return info;
 }
diff --git a/stubs/meson.build b/stubs/meson.build
index 2e79ff9f4d..5d394267f5 100644
--- a/stubs/meson.build
+++ b/stubs/meson.build
@@ -55,3 +55,4 @@ if have_system
 else
   stub_ss.add(files('qdev.c'))
 endif
+stub_ss.add(files('sgx-stub.c'))
diff --git a/stubs/sgx-stub.c b/stubs/sgx-stub.c
new file mode 100644
index 0000000000..c2b59a88fd
--- /dev/null
+++ b/stubs/sgx-stub.c
@@ -0,0 +1,7 @@
+#include "qemu/osdep.h"
+#include "hw/i386/pc.h"
+
+SGXInfo *sgx_get_info(void)
+{
+    return NULL;
+}
-- 
2.29.2.334.gfaefdd61ec



  parent reply	other threads:[~2021-07-09 11:41 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09 11:09 [PATCH v3 00/33] Qemu SGX virtualization Yang Zhong
2021-07-09 11:09 ` [PATCH v3 01/33] memory: Add RAM_PROTECTED flag to skip IOMMU mappings Yang Zhong
2021-07-09 11:09 ` [PATCH v3 02/33] hostmem: Add hostmem-epc as a backend for SGX EPC Yang Zhong
2021-07-09 11:09 ` [PATCH v3 03/33] qom: Add memory-backend-epc ObjectOptions support Yang Zhong
2021-07-09 11:09 ` [PATCH v3 04/33] i386: Add 'sgx-epc' device to expose EPC sections to guest Yang Zhong
2021-07-09 11:09 ` [PATCH v3 05/33] vl: Add sgx compound properties to expose SGX " Yang Zhong
2021-07-09 16:07   ` Paolo Bonzini
2021-07-12  9:23     ` Yang Zhong
2021-07-09 11:09 ` [PATCH v3 06/33] i386: Add primary SGX CPUID and MSR defines Yang Zhong
2021-07-09 11:09 ` [PATCH v3 07/33] i386: Add SGX CPUID leaf FEAT_SGX_12_0_EAX Yang Zhong
2021-07-09 11:09 ` [PATCH v3 08/33] i386: Add SGX CPUID leaf FEAT_SGX_12_0_EBX Yang Zhong
2021-07-09 11:09 ` [PATCH v3 09/33] i386: Add SGX CPUID leaf FEAT_SGX_12_1_EAX Yang Zhong
2021-07-09 11:09 ` [PATCH v3 10/33] i386: Add get/set/migrate support for SGX_LEPUBKEYHASH MSRs Yang Zhong
2021-07-09 11:09 ` [PATCH v3 11/33] i386: Add feature control MSR dependency when SGX is enabled Yang Zhong
2021-07-09 11:09 ` [PATCH v3 12/33] i386: Update SGX CPUID info according to hardware/KVM/user input Yang Zhong
2021-07-09 11:09 ` [PATCH v3 13/33] i386: kvm: Add support for exposing PROVISIONKEY to guest Yang Zhong
2021-07-09 11:09 ` [PATCH v3 14/33] i386: Propagate SGX CPUID sub-leafs to KVM Yang Zhong
2021-07-09 11:09 ` [PATCH v3 15/33] Adjust min CPUID level to 0x12 when SGX is enabled Yang Zhong
2021-07-09 11:09 ` [PATCH v3 16/33] hw/i386/fw_cfg: Set SGX bits in feature control fw_cfg accordingly Yang Zhong
2021-07-09 11:09 ` [PATCH v3 17/33] hw/i386/pc: Account for SGX EPC sections when calculating device memory Yang Zhong
2021-07-09 11:09 ` [PATCH v3 18/33] i386/pc: Add e820 entry for SGX EPC section(s) Yang Zhong
2021-07-09 11:09 ` [PATCH v3 19/33] i386: acpi: Add SGX EPC entry to ACPI tables Yang Zhong
2021-07-09 11:09 ` [PATCH v3 20/33] q35: Add support for SGX EPC Yang Zhong
2021-07-09 11:09 ` [PATCH v3 21/33] i440fx: " Yang Zhong
2021-07-09 11:09 ` [PATCH v3 22/33] hostmem-epc: Add the reset interface for EPC backend reset Yang Zhong
2021-07-09 11:09 ` [PATCH v3 23/33] sgx-epc: Add the reset interface for sgx-epc virt device Yang Zhong
2021-07-09 11:09 ` [PATCH v3 24/33] sgx-epc: Avoid bios reset during sgx epc initialization Yang Zhong
2021-07-09 11:09 ` [PATCH v3 25/33] hostmem-epc: Make prealloc consistent with qemu cmdline during reset Yang Zhong
2021-07-09 11:09 ` [PATCH v3 26/33] qmp: Add query-sgx command Yang Zhong
2021-07-09 11:09 ` [PATCH v3 27/33] hmp: Add 'info sgx' command Yang Zhong
2021-07-09 11:09 ` Yang Zhong [this message]
2021-07-09 11:09 ` [PATCH v3 29/33] bitops: Support 32 and 64 bit mask macro Yang Zhong
2021-07-09 11:09 ` [PATCH v3 30/33] qmp: Add the qmp_query_sgx_capabilities() Yang Zhong
2021-07-09 11:09 ` [PATCH v3 31/33] Kconfig: Add CONFIG_SGX support Yang Zhong
2021-07-09 11:09 ` [PATCH v3 32/33] sgx-epc: Add the fill_device_info() callback support Yang Zhong
2021-07-09 11:09 ` [PATCH v3 33/33] doc: Add the SGX doc Yang Zhong
2021-07-09 17:48 ` [PATCH v3 00/33] Qemu SGX virtualization Jarkko Sakkinen
2021-07-12  6:57   ` Yang Zhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210709110955.73256-29-yang.zhong@intel.com \
    --to=yang.zhong@intel.com \
    --cc=eblake@redhat.com \
    --cc=jarkko@kernel.org \
    --cc=kai.huang@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.