Re: [PATCH v5 03/11] futex2: Implement requeue operation

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 03/11] futex2: Implement requeue operation
Date: Fri, 09 Jul 2021 12:11:46 +0800	[thread overview]
Message-ID: <202107091229.7n1Bqbng-lkp@intel.com> (raw)
In-Reply-To: <20210709001328.329716-4-andrealmeid@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 3961 bytes --]

Hi "André,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/locking/core]
[also build test WARNING on tip/x86/asm asm-generic/master tip/master linus/master v5.13]
[cannot apply to next-20210708]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andr-Almeida/Add-futex2-syscalls/20210709-081529
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git d1bbfd0c7c9f985e57795a7e0cefc209ebf689c0
config: sparc64-randconfig-s031-20210707 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/b56df808966a9a9447b38ebb1160de18bd1be248
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andr-Almeida/Add-futex2-syscalls/20210709-081529
        git checkout b56df808966a9a9447b38ebb1160de18bd1be248
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sparc64 SHELL=/bin/bash kernel/events/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from kernel/events/core.c:44:
>> include/linux/compat.h:711:49: warning: 'struct futex_requeue' declared inside parameter list will not be visible outside of this definition or declaration
     711 | asmlinkage long compat_sys_futex_requeue(struct futex_requeue __user *rq1,
         |                                                 ^~~~~~~~~~~~~
   kernel/events/core.c:6677:6: warning: no previous prototype for 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
    6677 | long perf_pmu_snapshot_aux(struct perf_buffer *rb,
         |      ^~~~~~~~~~~~~~~~~~~~~

vim +711 include/linux/compat.h

   688	
   689	/* kernel/exit.c */
   690	asmlinkage long compat_sys_waitid(int, compat_pid_t,
   691			struct compat_siginfo __user *, int,
   692			struct compat_rusage __user *);
   693	
   694	
   695	
   696	/* kernel/futex.c */
   697	asmlinkage long
   698	compat_sys_set_robust_list(struct compat_robust_list_head __user *head,
   699				   compat_size_t len);
   700	asmlinkage long
   701	compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
   702				   compat_size_t __user *len_ptr);
   703	
   704	/* kernel/futex2.c */
   705	asmlinkage long compat_sys_futex_wait(void __user *uaddr, compat_u64 val,
   706					      unsigned int flags,
   707					      struct __kernel_timespec __user *timo);
   708	asmlinkage long compat_sys_futex_waitv(struct compat_futex_waitv *waiters,
   709					       compat_uint_t nr_futexes, compat_uint_t flags,
   710					       struct __kernel_timespec __user *timo);
 > 711	asmlinkage long compat_sys_futex_requeue(struct futex_requeue __user *rq1,
   712						 struct futex_requeue __user *rq2,
   713						 unsigned int nr_wake,
   714						 unsigned int nr_requeue,
   715						 u64 cmpval, unsigned int flags);
   716	/* kernel/itimer.c */
   717	asmlinkage long compat_sys_getitimer(int which,
   718					     struct old_itimerval32 __user *it);
   719	asmlinkage long compat_sys_setitimer(int which,
   720					     struct old_itimerval32 __user *in,
   721					     struct old_itimerval32 __user *out);
   722	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 23266 bytes --]