All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Behún" <marek.behun@nic.cz>
To: Stefan Roese <sr@denx.de>
Cc: u-boot@lists.denx.de, Chris Packham <judge.packham@gmail.com>,
	Baruch Siach <baruch@tkos.co.il>,
	Dirk Eibach <dirk.eibach@gdsys.cc>,
	Chris Packham <chris.packham@alliedtelesis.co.nz>,
	Dennis Gilmore <dgilmore@redhat.com>,
	Mario Six <mario.six@gdsys.cc>, Jon Nettleton <jon@solid-run.com>
Subject: Re: [PATCH u-boot-mvebu 00/31] kwboot / kwbimage improvements
Date: Fri, 9 Jul 2021 13:22:21 +0200	[thread overview]
Message-ID: <20210709132221.16dd91e3@dellmb> (raw)
In-Reply-To: <0325eee7-7c6a-5e61-6e3d-229567b07000@denx.de>

Hi Stefan

On Fri, 9 Jul 2021 08:05:40 +0200
Stefan Roese <sr@denx.de> wrote:

> > The main goal of this series is to correctly use BootROM's code
> > for loading U-Boot from NOR / NAND: currently only SPL is read by
> > BootROM and the main U-Boot is read by SPL. By using BootROM to also
> > load main U-Boot we can reduce the size of SPL image, since it does
> > not need to contain code for reading NOR / NAND.  
> 
> Before going into a review of the patches, let me ask about the
> motivation of this patchset. Is the reduction of the SPL image size
> the main motivation for this series? Or did you experiece some
> problems with the SPL code for U-Boot proper loading?

The motivation is reduction of SPL code size.
Pali started working on something different (adding support for higher
baudrates to kwboot, so that a bricked board can be booted over UART
faster), and he is still working on it, but when he started studying the
kwbimage/kwboot code and A38x documentation, he noticed that these
things could be improved, so first he did this series.

> BTW: This patch / mail subject "kwboot / kwbimage improvements" does
> not really match its content AFAIU. Here, the SPL returns always back
> to the BootROM for U-Boot proper loading part is missing. Or do I
> misunderstand something?

You are right, the subject of the series could have been better. I
shall change it in v2.

> 
> BTW2: Could you please list the affected MVEBU SoC's that are affected
> by this series so that this is clear?

OK.

Marek

  reply	other threads:[~2021-07-09 11:22 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 17:30 [PATCH u-boot-mvebu 00/31] kwboot / kwbimage improvements Marek Behún
2021-07-08 17:30 ` [PATCH u-boot-mvebu 01/31] tools: kwbimage: Fix compilation without CONFIG_SYS_U_BOOT_OFFS Marek Behún
2021-07-15  8:32   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 02/31] tools: kwbimage: Simplify aligning and calculating checksum Marek Behún
2021-07-15  8:33   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 03/31] tools: kwbimage: Align SPI and NAND images to 256 bytes Marek Behún
2021-07-15  8:34   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 04/31] tools: kwbimage: Add constant for SDIO bootfrom Marek Behún
2021-07-15  8:34   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 05/31] tools: kwbimage: Fix generation of SATA, SDIO and PCIe images Marek Behún
2021-07-15  8:35   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 06/31] tools: kwbimage: Don't crash when binary file name does not contain '/' Marek Behún
2021-07-15  8:35   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 07/31] tools: kwbimage: Fix check for v0 extended header checksum Marek Behún
2021-07-15  8:36   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 08/31] tools: kwbimage: Validate extended headers of v1 images Marek Behún
2021-07-15  8:36   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 09/31] tools: kwbimage: Validate data checksum " Marek Behún
2021-07-15  8:37   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 10/31] tools: kwbimage: Print size of binary header in kwbimage_print_header() Marek Behún
2021-07-15  8:37   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 11/31] tools: kwboot: Fix wrong parameter passed to read() Marek Behún
2021-07-15  8:38   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 12/31] tools: kwboot: Fix restoring terminal Marek Behún
2021-07-15  8:38   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 13/31] tools: kwboot: Print trailing newline after terminal is terminated Marek Behún
2021-07-15  8:39   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 14/31] tools: kwboot: Cosmetic fix - add missing curly brackets Marek Behún
2021-07-15  8:39   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 15/31] tools: kwboot: Check for v1 header size Marek Behún
2021-07-15  8:39   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 16/31] tools: kwbimage: Cosmetic fix - remove redundant space character Marek Behún
2021-07-15  8:40   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 17/31] tools: kwbimage: Use -a parameter (load address) for v1 images Marek Behún
2021-07-15  8:41   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 18/31] arm: mvebu: Fix return_to_bootrom() Marek Behún
2021-07-15  8:42   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 19/31] arm: mvebu: Mark return_to_bootrom() as a noreturn function Marek Behún
2021-07-15  8:43   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 20/31] arm: mvebu: Implement return_to_bootrom() via U-Boot's SPL framework Marek Behún
2021-07-15  8:46   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 21/31] arm: mvebu: Use U-Boot's SPL BootROM framework for booting from NAND/UART Marek Behún
2021-07-15  8:48   ` Stefan Roese
2021-07-08 17:30 ` [PATCH u-boot-mvebu 22/31] arm: mvebu: Always use BootROM for loading the rest of U-Boot's binary Marek Behún
2021-07-09  5:02   ` Baruch Siach
2021-07-08 17:30 ` [PATCH u-boot-mvebu 23/31] arm: mvebu: gdsys: Remove custom spl_board_init() Marek Behún
2021-07-08 17:30 ` [PATCH u-boot-mvebu 24/31] arm: mvebu: Remove legacy U-Boot header from kwbimage v1 files Marek Behún
2021-07-08 17:30 ` [PATCH u-boot-mvebu 25/31] tools: kwbimage: Remove v1 kwbimage SPL padding to CONFIG_SYS_U_BOOT_OFFS bytes Marek Behún
2021-07-09  0:37   ` Chris Packham
2021-07-08 17:30 ` [PATCH u-boot-mvebu 26/31] arm: mvebu: Remove unused macro CONFIG_SYS_U_BOOT_OFFS Marek Behún
2021-07-08 17:30 ` [PATCH u-boot-mvebu 27/31] tools: kwbimage: Add support for more BINARY headers Marek Behún
2021-07-08 17:30 ` [PATCH u-boot-mvebu 28/31] tools: kwbimage: Don't parse PAYLOAD keyword Marek Behún
2021-07-08 17:30 ` [PATCH u-boot-mvebu 29/31] tools: kwbimage: Add support for DATA command also for v1 images Marek Behún
2021-07-08 17:30 ` [PATCH u-boot-mvebu 30/31] tools: kwbimage: Add support for a new DATA_DELAY command Marek Behún
2021-07-08 17:30 ` [PATCH u-boot-mvebu 31/31] tools: kwbimage: Do not hide usage of secure header under CONFIG_ARMADA_38X Marek Behún
2021-07-09  6:05 ` [PATCH u-boot-mvebu 00/31] kwboot / kwbimage improvements Stefan Roese
2021-07-09 11:22   ` Marek Behún [this message]
2021-07-09 12:35     ` Stefan Roese
2021-07-09 14:08       ` Marek Behún
2021-07-10  0:31         ` Stefan Roese
2021-07-10  0:43           ` Pali Rohár
2021-07-10  0:59             ` Pali Rohár
2021-07-11  7:11               ` Stefan Roese
2021-07-11  7:11             ` Stefan Roese
2021-07-09 14:54 ` Baruch Siach
2021-07-09 14:57   ` Marek Behún
2021-07-11 21:56 ` Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210709132221.16dd91e3@dellmb \
    --to=marek.behun@nic.cz \
    --cc=baruch@tkos.co.il \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=dgilmore@redhat.com \
    --cc=dirk.eibach@gdsys.cc \
    --cc=jon@solid-run.com \
    --cc=judge.packham@gmail.com \
    --cc=mario.six@gdsys.cc \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.