From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D1E7C07E9B for ; Sat, 10 Jul 2021 02:19:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8707E613D4 for ; Sat, 10 Jul 2021 02:19:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231948AbhGJCVy (ORCPT ); Fri, 9 Jul 2021 22:21:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:37792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232277AbhGJCVS (ORCPT ); Fri, 9 Jul 2021 22:21:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BEE87613BE; Sat, 10 Jul 2021 02:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625883514; bh=psjiZPoJqTbIx9wY8pQaLI33HJVWFseOA6R/5ygYdO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SG0f8xiiuz8y8/650POICuvLZ1vRS9ekdqPPhvevvwejdukf6Q12DP4s8439PNuQ7 zJgWOoripkh22akuukxsuCYIrc7AfcDh5aY6H5l4AzXJ4XQCrmaHS4TnHBM2ShIWH2 UdB3Dh1cctvjiptKIv2M3AuRoFHvEDDLn+ddOE3faYE8BKOsJYUTc2Xv9cX5EhBOYj IODffDLy8T8AX/wTPWaFUL/upkBK1NMq6qtepq1kBPM3LQdW1A7VbbPAcsCzMYQXTe 1VH9cxjx9ITS5pGDCvJ7xzPNhsjm2EnXvqe6JJwvjSF1BiLluVoQfmux1BOaaoqYLB 2SirhZdwSBBpA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yufen Yu , Hulk Robot , Takashi Iwai , Sasha Levin , alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.13 033/114] ALSA: ac97: fix PM reference leak in ac97_bus_remove() Date: Fri, 9 Jul 2021 22:16:27 -0400 Message-Id: <20210710021748.3167666-33-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710021748.3167666-1-sashal@kernel.org> References: <20210710021748.3167666-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yufen Yu [ Upstream commit a38e93302ee25b2ca6f4ee76c6c974cf3637985e ] pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Yufen Yu Link: https://lore.kernel.org/r/20210524093811.612302-1-yuyufen@huawei.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/ac97/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c index d9077e91382b..6ddf646cda65 100644 --- a/sound/ac97/bus.c +++ b/sound/ac97/bus.c @@ -520,7 +520,7 @@ static int ac97_bus_remove(struct device *dev) struct ac97_codec_driver *adrv = to_ac97_driver(dev->driver); int ret; - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0) return ret; -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67176C07E99 for ; Sat, 10 Jul 2021 02:23:39 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9A93613FD for ; Sat, 10 Jul 2021 02:23:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9A93613FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 406B316A6; Sat, 10 Jul 2021 04:22:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 406B316A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1625883817; bh=psjiZPoJqTbIx9wY8pQaLI33HJVWFseOA6R/5ygYdO4=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OVK4QSqIlmFJcT7fe3AS6SFDkd71e+OIGEX1cqzbjpvm1B1bQJDOelA/m6Z9P0uPe TGOSSrpz6bWYlr4t1oj/ddUQCzmgCtQm+1ppcFPMp/zwBbpqez1REmBGxqbd/96tou e0MAJFmxE1jLokxy9dXbq44gFBpadVBNt+G5hPJ8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EE3A8F80534; Sat, 10 Jul 2021 04:18:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AD560F804F3; Sat, 10 Jul 2021 04:18:44 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 61BB0F80518 for ; Sat, 10 Jul 2021 04:18:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 61BB0F80518 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SG0f8xii" Received: by mail.kernel.org (Postfix) with ESMTPSA id BEE87613BE; Sat, 10 Jul 2021 02:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625883514; bh=psjiZPoJqTbIx9wY8pQaLI33HJVWFseOA6R/5ygYdO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SG0f8xiiuz8y8/650POICuvLZ1vRS9ekdqPPhvevvwejdukf6Q12DP4s8439PNuQ7 zJgWOoripkh22akuukxsuCYIrc7AfcDh5aY6H5l4AzXJ4XQCrmaHS4TnHBM2ShIWH2 UdB3Dh1cctvjiptKIv2M3AuRoFHvEDDLn+ddOE3faYE8BKOsJYUTc2Xv9cX5EhBOYj IODffDLy8T8AX/wTPWaFUL/upkBK1NMq6qtepq1kBPM3LQdW1A7VbbPAcsCzMYQXTe 1VH9cxjx9ITS5pGDCvJ7xzPNhsjm2EnXvqe6JJwvjSF1BiLluVoQfmux1BOaaoqYLB 2SirhZdwSBBpA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 5.13 033/114] ALSA: ac97: fix PM reference leak in ac97_bus_remove() Date: Fri, 9 Jul 2021 22:16:27 -0400 Message-Id: <20210710021748.3167666-33-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710021748.3167666-1-sashal@kernel.org> References: <20210710021748.3167666-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Cc: Takashi Iwai , Hulk Robot , alsa-devel@alsa-project.org, Yufen Yu , Sasha Levin X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Yufen Yu [ Upstream commit a38e93302ee25b2ca6f4ee76c6c974cf3637985e ] pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Yufen Yu Link: https://lore.kernel.org/r/20210524093811.612302-1-yuyufen@huawei.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/ac97/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c index d9077e91382b..6ddf646cda65 100644 --- a/sound/ac97/bus.c +++ b/sound/ac97/bus.c @@ -520,7 +520,7 @@ static int ac97_bus_remove(struct device *dev) struct ac97_codec_driver *adrv = to_ac97_driver(dev->driver); int ret; - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0) return ret; -- 2.30.2