From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB7FAC07E95 for ; Sat, 10 Jul 2021 07:05:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C32D0613C3 for ; Sat, 10 Jul 2021 07:05:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232208AbhGJHIA (ORCPT ); Sat, 10 Jul 2021 03:08:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232184AbhGJHIA (ORCPT ); Sat, 10 Jul 2021 03:08:00 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5988C0613DD for ; Sat, 10 Jul 2021 00:05:15 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id b12so10884085pfv.6 for ; Sat, 10 Jul 2021 00:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NyelH3y/Sii7PCvkumT3IvAArvEB9YXUeii5v7j0syg=; b=ej+0sNuNNat0KE9bTIFKRP3jvF3IVHdpZRQVd6NLSVB28jEsDw0mk5ks6v/pvu4YGR PxWl9bsnKhrjJBhj5MaLxCcZyRKwOpMSmqF7Wg9cFRuNr1uijseCpES9gt9RMkissZnA Y80EXBB3mEjif194IEWYktBKRHnAyDaDpSVSvD2GQrbSoEEnwjIIfBFMOyD93qazqW2C 7Jh8PucurSVmXZ/aA8SlJDFRMag4wqM5trDo6xIO38fT9TUk65aweePEMR/hl7l+BxMs xqULkEoKf12A4ml2KU8Ivbpv8ayDd/eUQ0eS5bWhze81NQ9PydPqLckL9cOXYWkDo3r5 36/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NyelH3y/Sii7PCvkumT3IvAArvEB9YXUeii5v7j0syg=; b=W5TZbtGQ1uSRQOBGBjTPLj0uoJYWLzHjbgSG8xkgZghUZkTr7/QGXslTxmAMoaejGb KTiAEkrO5zDexwtmgurmNeAshF3Mp3esng6HDHlNNkXLqTjOhuOTeD7NCQg2Ih4IPL/j DqO4TGJijimQwt3egI6NjDBY0vWCkDQm31d9xtQBTP2pdT/kNN8wCykM9XDro0gIVKW0 hdpn1V2NvBIEpyHvwRIHENMlxNJyjKcQqMq9YiPaJeQUmvYsx5q5q1oDiyra9EMbbzL2 SV+Mx1HYcK1mv2nn4lGvTv8XRBVndoFUAieZ8osCjqGS2WX0Sh3P+uhLCpSpvBKSPOah KiOg== X-Gm-Message-State: AOAM533B377ApiD630o/oOFAX5SWAPyWnUwpnG6QXrXy9QyLDMCnm8RC PqcbOt7JPKG0MU3qnpSP3Mdbmg== X-Google-Smtp-Source: ABdhPJyTt9ua5bgo9EOj/fAnBbinirlp0+fwpueIPjCZCx3LPza4hc9vG92Nc+5IYw3IO8dTkY71Fw== X-Received: by 2002:a62:2ec7:0:b029:301:fe50:7d4b with SMTP id u190-20020a622ec70000b0290301fe507d4bmr41511393pfu.78.1625900715175; Sat, 10 Jul 2021 00:05:15 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.131.71.237]) by smtp.gmail.com with ESMTPSA id i8sm8428557pfo.154.2021.07.10.00.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 00:05:14 -0700 (PDT) Date: Sat, 10 Jul 2021 15:05:09 +0800 From: Leo Yan To: Mathieu Poirier , Suzuki K Poulose , Mike Leach , Alexander Shishkin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] coresight: tmc-etr: Speed up for bounce buffer in flat mode Message-ID: <20210710070509.GB273828@leoy-ThinkPad-X240s> References: <20210710050046.414669-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210710050046.414669-1-leo.yan@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, On Sat, Jul 10, 2021 at 01:00:46PM +0800, Leo Yan wrote: [...] > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > @@ -21,6 +21,7 @@ > > struct etr_flat_buf { > struct device *dev; > + struct page *pages; > dma_addr_t daddr; > void *vaddr; > size_t size; > @@ -600,6 +601,7 @@ static int tmc_etr_alloc_flat_buf(struct tmc_drvdata *drvdata, > { > struct etr_flat_buf *flat_buf; > struct device *real_dev = drvdata->csdev->dev.parent; > + ssize_t aligned_size; > > /* We cannot reuse existing pages for flat buf */ > if (pages) > @@ -609,12 +611,17 @@ static int tmc_etr_alloc_flat_buf(struct tmc_drvdata *drvdata, > if (!flat_buf) > return -ENOMEM; > > - flat_buf->vaddr = dma_alloc_coherent(real_dev, etr_buf->size, > - &flat_buf->daddr, GFP_KERNEL); > - if (!flat_buf->vaddr) { > - kfree(flat_buf); > - return -ENOMEM; > - } > + aligned_size = PAGE_ALIGN(etr_buf->size); > + flat_buf->pages = alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, > + get_order(aligned_size)); > + if (!flat_buf->pages) > + goto fail_alloc_pages; > + > + flat_buf->vaddr = page_address(flat_buf->pages); > + flat_buf->daddr = dma_map_page(real_dev, flat_buf->pages, 0, > + aligned_size, DMA_FROM_DEVICE); > + if (dma_mapping_error(real_dev, flat_buf->daddr)) > + goto fail_dma_map_page; > > flat_buf->size = etr_buf->size; > flat_buf->dev = &drvdata->csdev->dev; > @@ -622,23 +629,34 @@ static int tmc_etr_alloc_flat_buf(struct tmc_drvdata *drvdata, > etr_buf->mode = ETR_MODE_FLAT; > etr_buf->private = flat_buf; > return 0; > + > +fail_dma_map_page: > + __free_pages(flat_buf->pages, get_order(aligned_size)); > +fail_alloc_pages: > + kfree(flat_buf); > + return -ENOMEM; > } > > static void tmc_etr_free_flat_buf(struct etr_buf *etr_buf) > { > struct etr_flat_buf *flat_buf = etr_buf->private; > > - if (flat_buf && flat_buf->daddr) { > + if (flat_buf && flat_buf->vaddr) { I found here I introduced an unexpected change for checking "flat_buf->vaddr", we should still check "flat_buf->daddr". Sent patch v2 to address this issue; please directly review patch v2. Thanks, Leo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D798BC07E95 for ; Sat, 10 Jul 2021 07:11:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B856613DA for ; Sat, 10 Jul 2021 07:11:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B856613DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SCi8NP16n5TjoRcMy2ue6f1i4b+swPTdQoGZVxXJfpQ=; b=FadVL0JooPmulY jY36F+WDwxg62EH4rd+1sIFoCgBCKqykDhhI38ML89XtZ7IERqPEpHvs/uk6nd3gedar8drZyP+Vl 47PpljWOe0ySf8whKSGlH/ODfmC86SzqkAGEXr+pLSSeDf91UVXLc2G7eTTsffTz1x63pr4vEsWKK PLCg23WcDkmR4VzzFGTthllZKSE/zWABKKUmEKCCYAvDA/hTWPfWNFcWfyRLKu8MPVFMW0ehBrxZc 4HLz5MBO4R8xyQ+2xyHtCtSZTxH5Jv8Bqv0yh4wLgx+ele1M+bZMaAteX/o5qGX/oLSnYLzWVPX7+ JAEzpb3cJcP9cAhQwPwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m273S-003BrT-OA; Sat, 10 Jul 2021 07:05:38 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m273K-003Bps-ID for linux-arm-kernel@lists.infradead.org; Sat, 10 Jul 2021 07:05:36 +0000 Received: by mail-pg1-x52c.google.com with SMTP id a2so12257145pgi.6 for ; Sat, 10 Jul 2021 00:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NyelH3y/Sii7PCvkumT3IvAArvEB9YXUeii5v7j0syg=; b=ej+0sNuNNat0KE9bTIFKRP3jvF3IVHdpZRQVd6NLSVB28jEsDw0mk5ks6v/pvu4YGR PxWl9bsnKhrjJBhj5MaLxCcZyRKwOpMSmqF7Wg9cFRuNr1uijseCpES9gt9RMkissZnA Y80EXBB3mEjif194IEWYktBKRHnAyDaDpSVSvD2GQrbSoEEnwjIIfBFMOyD93qazqW2C 7Jh8PucurSVmXZ/aA8SlJDFRMag4wqM5trDo6xIO38fT9TUk65aweePEMR/hl7l+BxMs xqULkEoKf12A4ml2KU8Ivbpv8ayDd/eUQ0eS5bWhze81NQ9PydPqLckL9cOXYWkDo3r5 36/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NyelH3y/Sii7PCvkumT3IvAArvEB9YXUeii5v7j0syg=; b=ZhwVxF8Z1wuDLkQqq1yV+nelWhVDo23edqVO42QfOVR4dxHLZ8mkC9CZSlaJ3XkdPr 4ANscu6QIqhe8k9lGlA3Z+0LVILuU87cv2tZ8mY8ho33hYmLgHYBh0svgGRKIftEJGzR wwOWmrLUBkJT/CFQb8cokkLtce3/bFyGLfF3yJ29gF1/FPVv50gUTpYMb38MU/H1R9q6 CN4GmB28zfwp8rgAh2bEIVXJN8TlpU5S43hszjTITt8IC5DDehT4Ad+3f1hU+/XeofKV /paSxXH6/wkqugrzoAYANXHyFHtty2VZbGBDS91WCq4MQ1wpsAhASSlR2/S4w9YrhgSO zl9w== X-Gm-Message-State: AOAM533CcB2VYh7vyuuQvz5IHKlTYaNIdCjewBuQN9+hPcL4ROjaz1T4 CzspK2wum53/g1iKIX4FoC2cI1JdSnLL8H4Z X-Google-Smtp-Source: ABdhPJyTt9ua5bgo9EOj/fAnBbinirlp0+fwpueIPjCZCx3LPza4hc9vG92Nc+5IYw3IO8dTkY71Fw== X-Received: by 2002:a62:2ec7:0:b029:301:fe50:7d4b with SMTP id u190-20020a622ec70000b0290301fe507d4bmr41511393pfu.78.1625900715175; Sat, 10 Jul 2021 00:05:15 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.131.71.237]) by smtp.gmail.com with ESMTPSA id i8sm8428557pfo.154.2021.07.10.00.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 00:05:14 -0700 (PDT) Date: Sat, 10 Jul 2021 15:05:09 +0800 From: Leo Yan To: Mathieu Poirier , Suzuki K Poulose , Mike Leach , Alexander Shishkin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] coresight: tmc-etr: Speed up for bounce buffer in flat mode Message-ID: <20210710070509.GB273828@leoy-ThinkPad-X240s> References: <20210710050046.414669-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210710050046.414669-1-leo.yan@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210710_000530_654863_2AE7BA0A X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi all, On Sat, Jul 10, 2021 at 01:00:46PM +0800, Leo Yan wrote: [...] > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > @@ -21,6 +21,7 @@ > > struct etr_flat_buf { > struct device *dev; > + struct page *pages; > dma_addr_t daddr; > void *vaddr; > size_t size; > @@ -600,6 +601,7 @@ static int tmc_etr_alloc_flat_buf(struct tmc_drvdata *drvdata, > { > struct etr_flat_buf *flat_buf; > struct device *real_dev = drvdata->csdev->dev.parent; > + ssize_t aligned_size; > > /* We cannot reuse existing pages for flat buf */ > if (pages) > @@ -609,12 +611,17 @@ static int tmc_etr_alloc_flat_buf(struct tmc_drvdata *drvdata, > if (!flat_buf) > return -ENOMEM; > > - flat_buf->vaddr = dma_alloc_coherent(real_dev, etr_buf->size, > - &flat_buf->daddr, GFP_KERNEL); > - if (!flat_buf->vaddr) { > - kfree(flat_buf); > - return -ENOMEM; > - } > + aligned_size = PAGE_ALIGN(etr_buf->size); > + flat_buf->pages = alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, > + get_order(aligned_size)); > + if (!flat_buf->pages) > + goto fail_alloc_pages; > + > + flat_buf->vaddr = page_address(flat_buf->pages); > + flat_buf->daddr = dma_map_page(real_dev, flat_buf->pages, 0, > + aligned_size, DMA_FROM_DEVICE); > + if (dma_mapping_error(real_dev, flat_buf->daddr)) > + goto fail_dma_map_page; > > flat_buf->size = etr_buf->size; > flat_buf->dev = &drvdata->csdev->dev; > @@ -622,23 +629,34 @@ static int tmc_etr_alloc_flat_buf(struct tmc_drvdata *drvdata, > etr_buf->mode = ETR_MODE_FLAT; > etr_buf->private = flat_buf; > return 0; > + > +fail_dma_map_page: > + __free_pages(flat_buf->pages, get_order(aligned_size)); > +fail_alloc_pages: > + kfree(flat_buf); > + return -ENOMEM; > } > > static void tmc_etr_free_flat_buf(struct etr_buf *etr_buf) > { > struct etr_flat_buf *flat_buf = etr_buf->private; > > - if (flat_buf && flat_buf->daddr) { > + if (flat_buf && flat_buf->vaddr) { I found here I introduced an unexpected change for checking "flat_buf->vaddr", we should still check "flat_buf->daddr". Sent patch v2 to address this issue; please directly review patch v2. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel