Re: [RFC PATCH v2 net-next 2/8] net: dsa: ocelot: felix: move MDIO access to a common location

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3500 bytes --]

Hi Colin,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Colin-Foster/Add-support-for-VSC7511-7514-chips-over-SPI/20210711-032838
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5e437416ff66981d8154687cfdf7de50b1d82bfc
config: microblaze-buildonly-randconfig-r006-20210711 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/68d3578b85be193a45003b797fef9a8ee3d1832b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Colin-Foster/Add-support-for-VSC7511-7514-chips-over-SPI/20210711-032838
        git checkout 68d3578b85be193a45003b797fef9a8ee3d1832b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/dsa/ocelot/felix_mdio.c:100:5: warning: no previous prototype for 'felix_mdio_register' [-Wmissing-prototypes]
     100 | int felix_mdio_register(struct ocelot *ocelot)
         |     ^~~~~~~~~~~~~~~~~~~
>> drivers/net/dsa/ocelot/felix_mdio.c:116:5: warning: no previous prototype for 'felix_mdio_bus_alloc' [-Wmissing-prototypes]
     116 | int felix_mdio_bus_alloc(struct ocelot *ocelot)
         |     ^~~~~~~~~~~~~~~~~~~~
>> drivers/net/dsa/ocelot/felix_mdio.c:138:6: warning: no previous prototype for 'felix_mdio_bus_free' [-Wmissing-prototypes]
     138 | void felix_mdio_bus_free(struct ocelot *ocelot)
         |      ^~~~~~~~~~~~~~~~~~~


vim +/felix_mdio_register +100 drivers/net/dsa/ocelot/felix_mdio.c

    99	
 > 100	int felix_mdio_register(struct ocelot *ocelot)
   101	{
   102		struct felix *felix = ocelot_to_felix(ocelot);
   103		struct device *dev = ocelot->dev;
   104		int rc;
   105	
   106		/* Needed in order to initialize the bus mutex lock */
   107		rc = mdiobus_register(felix->imdio);
   108		if (rc < 0) {
   109			dev_err(dev, "failed to register MDIO bus\n");
   110			felix->imdio = NULL;
   111		}
   112	
   113		return rc;
   114	}
   115	
 > 116	int felix_mdio_bus_alloc(struct ocelot *ocelot)
   117	{
   118		struct felix *felix = ocelot_to_felix(ocelot);
   119		struct device *dev = ocelot->dev;
   120		struct mii_bus *bus;
   121	
   122		bus = devm_mdiobus_alloc(dev);
   123		if (!bus)
   124			return -ENOMEM;
   125	
   126		bus->name = "Felix internal MDIO bus";
   127		bus->read = felix_mdio_read;
   128		bus->write = felix_mdio_write;
   129		bus->parent = dev;
   130		bus->priv = ocelot;
   131		snprintf(bus->id, MII_BUS_ID_SIZE, "%s-imdio", dev_name(dev));
   132	
   133		felix->imdio = bus;
   134	
   135		return 0;
   136	}
   137	
 > 138	void felix_mdio_bus_free(struct ocelot *ocelot)
   139	{
   140		struct felix *felix = ocelot_to_felix(ocelot);
   141	
   142		if (felix->imdio)
   143			mdiobus_unregister(felix->imdio);
   144	}
   145	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27008 bytes --]