From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1694C07E96 for ; Sun, 11 Jul 2021 10:41:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC1E3611ED for ; Sun, 11 Jul 2021 10:41:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232371AbhGKKoN (ORCPT ); Sun, 11 Jul 2021 06:44:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232085AbhGKKoJ (ORCPT ); Sun, 11 Jul 2021 06:44:09 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77542C0613DD for ; Sun, 11 Jul 2021 03:41:22 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id i16-20020a17090acf90b02901736d9d2218so3737273pju.1 for ; Sun, 11 Jul 2021 03:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tvAJvuDnRJDe9YMY5R2L+q2C0nSKQeIr4jFz4M7hp0E=; b=er914k1odHGQXFxKzwCAlSjDGT1lEhzg/54+63PQydsGFVX2c9kqX4DPnaoiLiqnTP Sw261DSe/328/xnD6Q0ZHboHc2K56SXChdQ8gad+HDOsfl/dCd/Zkfda9mRDkkuz4V/F PxnXcnEgmWJSCgPt0zXCAszYveUShnZMGHu5vn5yxmAVcIC0pjjHzjY1X6lRErUI/oa6 PbqT1IFNUz5O3YrANKzyUQ/XhuAG3SdAY3lRCQzDVoUvMMdrEFpLSQw1ENZ9znLkXwvM wM6qimqRDCqFO3Wq2+eZ1BIfH/Im3aalssq5IIu+S5UCtJLL58kuPYMZwjGiJfUrW15c 73jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tvAJvuDnRJDe9YMY5R2L+q2C0nSKQeIr4jFz4M7hp0E=; b=GFEO0ZNpUX6aedLNYMeBZ8eZ7KX+u/56KH7dsJxjrqyjRa3UqlGcnbcKyikig6gnci BNK5jvxMhDUbOfCo2Pcc98YMJIFUnWgm5/IeTYxu+KpxkioHLsFe2pFlNDak6Dn2fvAM SOW6kJwE+RF4+hbkjPQK/PS6T6m3UQt7AFryUjeFN7Z2dfJREv8lNhtPDWFVfw/Xw4gm 19EDEDWd7Jy+iXyJjJcT9gEs1mQsJEBbaOWVXm9W8DNV/AKwapm5bSpqrH3BW+YH0Awh OEzJBjFxzdsIfN3h1JeHEdcuhJn/ar7NUMZjespFR4IeIoMdphK3mr3vSR71yLQUTgSQ 8Feg== X-Gm-Message-State: AOAM5314NI1KYglXDxEYaSKJ6JL2ZI5Avo3viKeDV9YfCNWANvNeVAML PG6r2gFnfYgTgl8qSVs+JSP04w== X-Google-Smtp-Source: ABdhPJx3EsK700CJoPDmV2uQscNMM5W/vzqGJIPYWH/E+Oq8jMLYvmO+fUcusoi8LDNTAkzV9oH4bg== X-Received: by 2002:a17:90a:4681:: with SMTP id z1mr7368243pjf.156.1626000082010; Sun, 11 Jul 2021 03:41:22 -0700 (PDT) Received: from localhost ([103.127.241.250]) by smtp.gmail.com with ESMTPSA id d191sm13945165pga.27.2021.07.11.03.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jul 2021 03:41:21 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Adrian Hunter , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Mathieu Poirier , Suzuki K Poulose , Mike Leach , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan Subject: [PATCH v4 02/11] coresight: tmc-etr: Add barrier after updating AUX ring buffer Date: Sun, 11 Jul 2021 18:40:56 +0800 Message-Id: <20210711104105.505728-3-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210711104105.505728-1-leo.yan@linaro.org> References: <20210711104105.505728-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since a memory barrier is required between AUX trace data store and aux_head store, and the AUX trace data is filled with memcpy(), it's sufficient to use smp_wmb() so can ensure the trace data is visible prior to updating aux_head. Signed-off-by: Leo Yan --- drivers/hwtracing/coresight/coresight-tmc-etr.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c index acdb59e0e661..713205db15a1 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -1563,6 +1563,14 @@ tmc_update_etr_buffer(struct coresight_device *csdev, */ if (etr_perf->snapshot) handle->head += size; + + /* + * It requires the ordering between the AUX trace data and aux_head + * store, below smp_wmb() ensures the AUX trace data is visible prior + * to updating aux_head. + */ + smp_wmb(); + out: /* * Don't set the TRUNCATED flag in snapshot mode because 1) the -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED20CC07E96 for ; Sun, 11 Jul 2021 10:44:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE1D961159 for ; Sun, 11 Jul 2021 10:44:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE1D961159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LBGHnhE+zRJI1qPjd2jcqywIU2jUE5MQeyFi9Wr7E+c=; b=yc+RG05b+pDl77 1oir7raVJG8EU0lRKakLXVL/6zmC4hJwrFTDVAgRq5/6Ncy3rD98QAuWceoa9DfWAPbGGOdRMnZvv ohfgY8d9taIRodPNhczN3KTROwoyrHZ4nhisAQhgRHpWOTVGGlzjZgpjj4Qxt94g5jdkdeQBn9vpx DWAb9qtVp3rD+CgCoANddeSUt1VfTq+h+PvSI7tqr4G36S6f9VRFpbClvC9GaEhfq1igKPjRTmUD3 s7IgK5tqxhsb5RJGrWrCBWefbF8R6oRSaFiqLdscJvd5yVOrg8yLrGDapvlYhLprffEzZxe+F/XSO zyyQc88XNnUFb4ePC4tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2Wuy-004scT-VY; Sun, 11 Jul 2021 10:42:37 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2Wtm-004sA7-QH for linux-arm-kernel@lists.infradead.org; Sun, 11 Jul 2021 10:41:24 +0000 Received: by mail-pl1-x62e.google.com with SMTP id c15so7471258pls.13 for ; Sun, 11 Jul 2021 03:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tvAJvuDnRJDe9YMY5R2L+q2C0nSKQeIr4jFz4M7hp0E=; b=er914k1odHGQXFxKzwCAlSjDGT1lEhzg/54+63PQydsGFVX2c9kqX4DPnaoiLiqnTP Sw261DSe/328/xnD6Q0ZHboHc2K56SXChdQ8gad+HDOsfl/dCd/Zkfda9mRDkkuz4V/F PxnXcnEgmWJSCgPt0zXCAszYveUShnZMGHu5vn5yxmAVcIC0pjjHzjY1X6lRErUI/oa6 PbqT1IFNUz5O3YrANKzyUQ/XhuAG3SdAY3lRCQzDVoUvMMdrEFpLSQw1ENZ9znLkXwvM wM6qimqRDCqFO3Wq2+eZ1BIfH/Im3aalssq5IIu+S5UCtJLL58kuPYMZwjGiJfUrW15c 73jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tvAJvuDnRJDe9YMY5R2L+q2C0nSKQeIr4jFz4M7hp0E=; b=l/BNP20TsoveeoXl5smD4Cer9d7MT3g3F3hSZ3jhILbzUFg1p4Y+lOe3vlVMRjTrGK pbtBhPniXGerVrKmrCC/8YGo38aFle+vH1IDh98NktBgo8+a1GdNNFl7rceWV1ylNqZu xCYwPOJXipLnir++fiUARlOjVCAzmqmjV5eUww//ECd3mQUgXeYayAvQEU7Fqf7OL9uO Kz5M32tr8ngMZBVtz/+5S2ZudSK1lbb8ZaoaxAL1hy3+VmJbfMMpTzKIa8zZn5XfQS7Y urpuiGi3xeZc/8iQ9BY2FM9ZXKfBn2TgCh6eoa6WhYsUIrXzNV6Efx/3i5PARfv+WzUf ofMQ== X-Gm-Message-State: AOAM5308b2+Z23+vGxfikT99bmgDTsm1PlK8R/+Dwr7i8hwtPKtyynXZ 7M+3LEHY7h6eHuxPh0Zdm4rk2g== X-Google-Smtp-Source: ABdhPJx3EsK700CJoPDmV2uQscNMM5W/vzqGJIPYWH/E+Oq8jMLYvmO+fUcusoi8LDNTAkzV9oH4bg== X-Received: by 2002:a17:90a:4681:: with SMTP id z1mr7368243pjf.156.1626000082010; Sun, 11 Jul 2021 03:41:22 -0700 (PDT) Received: from localhost ([103.127.241.250]) by smtp.gmail.com with ESMTPSA id d191sm13945165pga.27.2021.07.11.03.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jul 2021 03:41:21 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Adrian Hunter , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Mathieu Poirier , Suzuki K Poulose , Mike Leach , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan Subject: [PATCH v4 02/11] coresight: tmc-etr: Add barrier after updating AUX ring buffer Date: Sun, 11 Jul 2021 18:40:56 +0800 Message-Id: <20210711104105.505728-3-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210711104105.505728-1-leo.yan@linaro.org> References: <20210711104105.505728-1-leo.yan@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210711_034122_898213_B91645AA X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since a memory barrier is required between AUX trace data store and aux_head store, and the AUX trace data is filled with memcpy(), it's sufficient to use smp_wmb() so can ensure the trace data is visible prior to updating aux_head. Signed-off-by: Leo Yan --- drivers/hwtracing/coresight/coresight-tmc-etr.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c index acdb59e0e661..713205db15a1 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -1563,6 +1563,14 @@ tmc_update_etr_buffer(struct coresight_device *csdev, */ if (etr_perf->snapshot) handle->head += size; + + /* + * It requires the ordering between the AUX trace data and aux_head + * store, below smp_wmb() ensures the AUX trace data is visible prior + * to updating aux_head. + */ + smp_wmb(); + out: /* * Don't set the TRUNCATED flag in snapshot mode because 1) the -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel