From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDFFC07E9C for ; Mon, 12 Jul 2021 10:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8003161152 for ; Mon, 12 Jul 2021 10:04:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236682AbhGLKHB (ORCPT ); Mon, 12 Jul 2021 06:07:01 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:18768 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233469AbhGLKGv (ORCPT ); Mon, 12 Jul 2021 06:06:51 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 16C9lOl5099565; Mon, 12 Jul 2021 17:47:24 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from localhost.localdomain (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Jul 2021 18:03:18 +0800 From: Steven Lee To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list CC: , , , Subject: [PATCH v6 0/9] ASPEED sgpio driver enhancement. Date: Mon, 12 Jul 2021 18:03:07 +0800 Message-ID: <20210712100317.23298-1-steven_lee@aspeedtech.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 16C9lOl5099565 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org AST2600 SoC has 2 SGPIO master interfaces one with 128 pins another one with 80 pins, AST2500/AST2400 SoC has 1 SGPIO master interface that supports up to 80 pins. In the current driver design, the max number of sgpio pins is hardcoded in macro MAX_NR_HW_SGPIO and the value is 80. For supporting sgpio master interfaces of AST2600 SoC, the patch series contains the following enhancement: - Convert txt dt-bindings to yaml. - Update aspeed-g6 dtsi to support the enhanced sgpio. - Support muiltiple SGPIO master interfaces. - Support up to 128 pins by dts ngpios property. - Pair input/output GPIOs instead of using 0 as GPIO input pin base and MAX_NR_HW_SGPIO as GPIO output pin base. - Support wdt reset tolerance. - Fix irq_chip issues which causes multiple sgpio devices use the same irq_chip data. - Replace all of_*() APIs with device_*(). Changes from v5: * Squash v5 patch-05 and patch-06 to one patch. * Remove MAX_NR_HW_SGPIO and corresponding design to make the gpio input/output pin base are determined by ngpios. For example, if MAX_NR_HW_SGPIO is 80 and ngpios is 10, the original pin order is as follows: Input: 0 1 2 3 ... 9 Output: 80 81 82 ... 89 With the new design, pin order is changed as follows: Input: 0 2 4 6 ... 18(ngpios * 2 - 2) Output: 1 3 5 7 ... 19(ngpios * 2 - 1) * Replace ast2600-sgpiom-128 and ast2600-sgpiom-80 compatibles by ast2600-sgpiom. * Fix coding style issues. Changes from v4: * Remove ngpios from dtsi * Add ast2400 and ast2500 platform data. * Remove unused macros. * Add ngpios check in a separate patch. * Fix coding style issues. Changes from v3: * Split dt-bindings patch to 2 patches * Rename ast2600-sgpiom1 compatible with ast2600-sgiom-128 * Rename ast2600-sgpiom2 compatible with ast2600-sgiom-80 * Correct the typo in commit messages. * Fix coding style issues. * Replace all of_*() APIs with device_*(). Changes from v2: * Remove maximum/minimum of ngpios from bindings. * Remove max-ngpios from bindings and dtsi. * Remove ast2400-sgpiom and ast2500-sgpiom compatibles from dts and driver. * Add ast2600-sgpiom1 and ast2600-sgpiom2 compatibles as their max number of available gpio pins are different. * Modify functions to pass aspeed_sgpio struct instead of passing max_ngpios. * Split sgpio driver patch to 3 patches Changes from v1: * Fix yaml format issues. * Fix issues reported by kernel test robot. Please help to review. Thanks, Steven Steven Lee (9): dt-bindings: aspeed-sgpio: Convert txt bindings to yaml. dt-bindings: aspeed-sgpio: Add ast2600 sgpio ARM: dts: aspeed-g6: Add SGPIO node. ARM: dts: aspeed-g5: Remove ngpios from sgpio node. gpio: gpio-aspeed-sgpio: Add AST2600 sgpio support gpio: gpio-aspeed-sgpio: Add set_config function gpio: gpio-aspeed-sgpio: Move irq_chip to aspeed-sgpio struct gpio: gpio-aspeed-sgpio: Use generic device property APIs gpio: gpio-aspeed-sgpio: Return error if ngpios is not multiple of 8. .../bindings/gpio/aspeed,sgpio.yaml | 77 ++++++++ .../devicetree/bindings/gpio/sgpio-aspeed.txt | 46 ----- arch/arm/boot/dts/aspeed-g5.dtsi | 1 - arch/arm/boot/dts/aspeed-g6.dtsi | 28 +++ drivers/gpio/gpio-aspeed-sgpio.c | 178 +++++++++++------- 5 files changed, 215 insertions(+), 115 deletions(-) create mode 100644 Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml delete mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 194A2C07E99 for ; Mon, 12 Jul 2021 10:05:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD711610E6 for ; Mon, 12 Jul 2021 10:05:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD711610E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=O8RzrHzW7jW9EFfbOjEc8wUc0QSoGhrtrLi3PdHEO2Y=; b=eCR2UjhnhYW0Q0 kvkSwhH3SCFj4kEwCOuAJZC5eBmXan+0dvJfmo9gTAnqXdyaRtdIJwtKgfPJK9UrKkr8cXoiRt2Hv tvyYEeUEK5ESpCB1OAwfp+kbe2rz7YavwAhwoeum6VOSPO73Gsf1u516jtsjYZdlnZMTSA/SCU/bT E7WeuDpdzZi7Upw9DjGpo7ly7LNs7vVmX3jbC50F06nI5bnNZI8LFLTIG7OjCkzXVR9vkbg9Vfei1 77DefF+EE0Bs6XUzjuNVOsxrTMp1fpZEuXmhdAYrOEX6tmrZGE5qWmVneAvKJV7iLzswMxtobjXwT xnxAvC7eVCiJZxJ8DGHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2sn2-006ozP-6A; Mon, 12 Jul 2021 10:03:52 +0000 Received: from [211.20.114.71] (helo=twspam01.aspeedtech.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2smx-006oyB-TT for linux-arm-kernel@lists.infradead.org; Mon, 12 Jul 2021 10:03:49 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 16C9lOl5099565; Mon, 12 Jul 2021 17:47:24 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from localhost.localdomain (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Jul 2021 18:03:18 +0800 From: Steven Lee To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list CC: , , , Subject: [PATCH v6 0/9] ASPEED sgpio driver enhancement. Date: Mon, 12 Jul 2021 18:03:07 +0800 Message-ID: <20210712100317.23298-1-steven_lee@aspeedtech.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 16C9lOl5099565 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_030348_333293_BDE41E47 X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org AST2600 SoC has 2 SGPIO master interfaces one with 128 pins another one with 80 pins, AST2500/AST2400 SoC has 1 SGPIO master interface that supports up to 80 pins. In the current driver design, the max number of sgpio pins is hardcoded in macro MAX_NR_HW_SGPIO and the value is 80. For supporting sgpio master interfaces of AST2600 SoC, the patch series contains the following enhancement: - Convert txt dt-bindings to yaml. - Update aspeed-g6 dtsi to support the enhanced sgpio. - Support muiltiple SGPIO master interfaces. - Support up to 128 pins by dts ngpios property. - Pair input/output GPIOs instead of using 0 as GPIO input pin base and MAX_NR_HW_SGPIO as GPIO output pin base. - Support wdt reset tolerance. - Fix irq_chip issues which causes multiple sgpio devices use the same irq_chip data. - Replace all of_*() APIs with device_*(). Changes from v5: * Squash v5 patch-05 and patch-06 to one patch. * Remove MAX_NR_HW_SGPIO and corresponding design to make the gpio input/output pin base are determined by ngpios. For example, if MAX_NR_HW_SGPIO is 80 and ngpios is 10, the original pin order is as follows: Input: 0 1 2 3 ... 9 Output: 80 81 82 ... 89 With the new design, pin order is changed as follows: Input: 0 2 4 6 ... 18(ngpios * 2 - 2) Output: 1 3 5 7 ... 19(ngpios * 2 - 1) * Replace ast2600-sgpiom-128 and ast2600-sgpiom-80 compatibles by ast2600-sgpiom. * Fix coding style issues. Changes from v4: * Remove ngpios from dtsi * Add ast2400 and ast2500 platform data. * Remove unused macros. * Add ngpios check in a separate patch. * Fix coding style issues. Changes from v3: * Split dt-bindings patch to 2 patches * Rename ast2600-sgpiom1 compatible with ast2600-sgiom-128 * Rename ast2600-sgpiom2 compatible with ast2600-sgiom-80 * Correct the typo in commit messages. * Fix coding style issues. * Replace all of_*() APIs with device_*(). Changes from v2: * Remove maximum/minimum of ngpios from bindings. * Remove max-ngpios from bindings and dtsi. * Remove ast2400-sgpiom and ast2500-sgpiom compatibles from dts and driver. * Add ast2600-sgpiom1 and ast2600-sgpiom2 compatibles as their max number of available gpio pins are different. * Modify functions to pass aspeed_sgpio struct instead of passing max_ngpios. * Split sgpio driver patch to 3 patches Changes from v1: * Fix yaml format issues. * Fix issues reported by kernel test robot. Please help to review. Thanks, Steven Steven Lee (9): dt-bindings: aspeed-sgpio: Convert txt bindings to yaml. dt-bindings: aspeed-sgpio: Add ast2600 sgpio ARM: dts: aspeed-g6: Add SGPIO node. ARM: dts: aspeed-g5: Remove ngpios from sgpio node. gpio: gpio-aspeed-sgpio: Add AST2600 sgpio support gpio: gpio-aspeed-sgpio: Add set_config function gpio: gpio-aspeed-sgpio: Move irq_chip to aspeed-sgpio struct gpio: gpio-aspeed-sgpio: Use generic device property APIs gpio: gpio-aspeed-sgpio: Return error if ngpios is not multiple of 8. .../bindings/gpio/aspeed,sgpio.yaml | 77 ++++++++ .../devicetree/bindings/gpio/sgpio-aspeed.txt | 46 ----- arch/arm/boot/dts/aspeed-g5.dtsi | 1 - arch/arm/boot/dts/aspeed-g6.dtsi | 28 +++ drivers/gpio/gpio-aspeed-sgpio.c | 178 +++++++++++------- 5 files changed, 215 insertions(+), 115 deletions(-) create mode 100644 Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml delete mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel