All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nds32/setup: remove unused memblock_region variable in setup_memory()
@ 2021-07-12 12:52 Mike Rapoport
  2021-09-08 15:20 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Rapoport @ 2021-07-12 12:52 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Greentime Hu, kernel test robot, Nick Hu, Vincent Chen, linux-mm,
	linux-kernel, Mike Rapoport, kernel test robot

From: Mike Rapoport <rppt@linux.ibm.com>

kernel test robot reports unused variable warning:

cppcheck possible warnings: (new ones prefixed by >>, may not real
problems)

>> arch/nds32/kernel/setup.c:247:26: warning: Unused variable: region
>> [unusedVariable]
    struct memblock_region *region;
                            ^

Remove the unused variable.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
 arch/nds32/kernel/setup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/nds32/kernel/setup.c b/arch/nds32/kernel/setup.c
index 41725eaf8bac..b3d34d646652 100644
--- a/arch/nds32/kernel/setup.c
+++ b/arch/nds32/kernel/setup.c
@@ -244,7 +244,6 @@ static void __init setup_memory(void)
 	unsigned long ram_start_pfn;
 	unsigned long free_ram_start_pfn;
 	phys_addr_t memory_start, memory_end;
-	struct memblock_region *region;
 
 	memory_end = memory_start = 0;
 

base-commit: e73f0f0ee7541171d89f2e2491130c7771ba58d3
-- 
2.28.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] nds32/setup: remove unused memblock_region variable in setup_memory()
  2021-07-12 12:52 [PATCH] nds32/setup: remove unused memblock_region variable in setup_memory() Mike Rapoport
@ 2021-09-08 15:20 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-09-08 15:20 UTC (permalink / raw)
  To: Mike Rapoport
  Cc: Andrew Morton, Greentime Hu, kernel test robot, Nick Hu,
	Vincent Chen, linux-mm, linux-kernel, Mike Rapoport,
	kernel test robot

On Mon, Jul 12, 2021 at 03:52:18PM +0300, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
> 
> kernel test robot reports unused variable warning:
> 
> cppcheck possible warnings: (new ones prefixed by >>, may not real
> problems)
> 
> >> arch/nds32/kernel/setup.c:247:26: warning: Unused variable: region
> >> [unusedVariable]
>     struct memblock_region *region;
>                             ^
> 
> Remove the unused variable.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>

This is now fatal.

arch/nds32/kernel/setup.c: In function 'setup_memory':
arch/nds32/kernel/setup.c:247:26: error: unused variable 'region'

Anyone care to apply it ?

Guenter

> ---
>  arch/nds32/kernel/setup.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/nds32/kernel/setup.c b/arch/nds32/kernel/setup.c
> index 41725eaf8bac..b3d34d646652 100644
> --- a/arch/nds32/kernel/setup.c
> +++ b/arch/nds32/kernel/setup.c
> @@ -244,7 +244,6 @@ static void __init setup_memory(void)
>  	unsigned long ram_start_pfn;
>  	unsigned long free_ram_start_pfn;
>  	phys_addr_t memory_start, memory_end;
> -	struct memblock_region *region;
>  
>  	memory_end = memory_start = 0;
>  
> 
> base-commit: e73f0f0ee7541171d89f2e2491130c7771ba58d3
> -- 
> 2.28.0
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-08 15:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12 12:52 [PATCH] nds32/setup: remove unused memblock_region variable in setup_memory() Mike Rapoport
2021-09-08 15:20 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.