From: Mark Brown <broonie@kernel.org>
To: David Rhodes <drhodes@opensource.cirrus.com>
Cc: robh@kernel.org, brian.austin@cirrus.com,
ckeepax@opensource.cirrus.com, patches@opensource.cirrus.com,
alsa-devel@alsa-project.org, david.rhodes@cirrus.com
Subject: Re: [PATCH v3 1/2] ASoC: cs35l41: CS35L41 Boosted Smart Amplifier
Date: Mon, 12 Jul 2021 16:03:41 +0100 [thread overview]
Message-ID: <20210712150341.GF4435@sirena.org.uk> (raw)
In-Reply-To: <b9627394-4d71-cafa-0944-14dad137ffdd@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Fri, Jul 09, 2021 at 06:11:28PM -0500, David Rhodes wrote:
> On 7/5/21 2:20 PM, Mark Brown wrote:
> > > + case SND_SOC_DAPM_POST_PMD:
> > > + regmap_read(cs35l41->regmap, CS35L41_PWR_CTRL1, &val);
> > > + if (val & CS35L41_GLOBAL_EN_MASK) {
> > > + regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL1,
> > > + CS35L41_GLOBAL_EN_MASK, 0);
> > I can't see any references to GLOBAL_EN outside this function, why might
> > it not be set?
> This check prevents an incorrect 'PDN Failed' message if DAPM initializes
> and turns the widget off at boot (with no prior power-up).
In what way does it prevent this message and why is this a good approach
to the issue?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-12 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 20:51 [PATCH v3 0/2] Cirrus Logic CS35L41 Amplifier David Rhodes
2021-07-02 20:51 ` [PATCH v3 1/2] ASoC: cs35l41: CS35L41 Boosted Smart Amplifier David Rhodes
2021-07-05 19:20 ` Mark Brown
2021-07-09 23:11 ` David Rhodes
2021-07-12 15:03 ` Mark Brown [this message]
2021-07-20 22:18 ` David Rhodes
2021-07-21 9:01 ` Charles Keepax
2021-07-21 12:03 ` Mark Brown
2021-07-22 16:07 ` David Rhodes
2021-07-22 16:11 ` Mark Brown
2021-07-02 20:51 ` [PATCH v3 2/2] ASoC: cs35l41: Add bindings for CS35L41 David Rhodes
2021-07-05 19:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712150341.GF4435@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=drhodes@opensource.cirrus.com \
--cc=patches@opensource.cirrus.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.