From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01EBDC07E99 for ; Mon, 12 Jul 2021 22:07:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF5F461245 for ; Mon, 12 Jul 2021 22:07:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231868AbhGLWKl (ORCPT ); Mon, 12 Jul 2021 18:10:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:45416 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231252AbhGLWKh (ORCPT ); Mon, 12 Jul 2021 18:10:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626127667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rC1yUGWBvIID360PWaPb4pUccgpGiNBVKC/0HCxB0ds=; b=MjQO2+Jp8Ah08jSRxzsQgdN0aSxDN2DpMYdUxFiDNgf60VKQjMIhnZgNaKRKirfj+kNuQV 34FV8/ZM7TeS33oiA3Rw1XIQM243bKiatbJE8t9TIinZMjzjoHxxl7A9wdRufPlPrZwqXu mYtfEA71iE9qbIVpr/5IBluOPmMbcRg= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-sjmKSQbZPkOXeO8_Cmhfzw-1; Mon, 12 Jul 2021 18:07:46 -0400 X-MC-Unique: sjmKSQbZPkOXeO8_Cmhfzw-1 Received: by mail-oi1-f199.google.com with SMTP id l189-20020acabbc60000b02901f566a77bb8so14016287oif.7 for ; Mon, 12 Jul 2021 15:07:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rC1yUGWBvIID360PWaPb4pUccgpGiNBVKC/0HCxB0ds=; b=PYCgjaIyU5WwLZcAgOBdKF+8svCzV5Pf6OflxEGky/mMctQhwbHXaaJnV9Sz59MVM+ 1GNep6BXCHucqufo8lB6+uY35wPMtzqDDodNPg4O9DYmJpor3VP3LS6KBj4xnVNZa4dC y3m74vkBBExB5doNDPQWG0DJ94wLFwqQBReHtgnLPMclB2pfMMLADmeww0gVlsGXQhvX kkIvUbHTk6/8ZRy5/zdA3DGLJimBsXp84Wkckk2CbYZRLqnRZW9yKx/igSx6ncyN31S+ BF7oxnqN9yguYA3KU8E3xANGHNhr6DG4+gWIaQAt0QTzTXCu8XEkVXjIf0wzDH9MoUqa XtAg== X-Gm-Message-State: AOAM533cZ7IEa8ZazL1ncKbnVsZStZGXbgXj4IHU/Y9nX6dW/XNweBcJ 8fCcy4pKuBznblB73Tm8YFjx6nk9irHTOCaUPnEY9hHkPxYsBllA+t05kTqyQeCKLpfmCcY/DIj /D5YTTSTY6jchbKDkSRW7irpM X-Received: by 2002:a05:6808:2024:: with SMTP id q36mr713306oiw.130.1626127665778; Mon, 12 Jul 2021 15:07:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwom3gaAzIAzvPzYLLUu/UBp7QXOHYRTrnaYNmrGEcq8p2L2vUeBMc2AmGqe/dErID5t0VTsw== X-Received: by 2002:a05:6808:2024:: with SMTP id q36mr713289oiw.130.1626127665590; Mon, 12 Jul 2021 15:07:45 -0700 (PDT) Received: from redhat.com ([198.99.80.109]) by smtp.gmail.com with ESMTPSA id o63sm3483664oih.32.2021.07.12.15.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 15:07:45 -0700 (PDT) Date: Mon, 12 Jul 2021 16:07:44 -0600 From: Alex Williamson To: Amey Narkhede Cc: Bjorn Helgaas , Raphael Norwitz , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kw@linux.com, Shanker Donthineni , Sinan Kaya , Len Brown , "Rafael J . Wysocki" Subject: Re: [PATCH v10 1/8] PCI: Add pcie_reset_flr to follow calling convention of other reset methods Message-ID: <20210712160744.0a651364.alex.williamson@redhat.com> In-Reply-To: <20210709123813.8700-2-ameynarkhede03@gmail.com> References: <20210709123813.8700-1-ameynarkhede03@gmail.com> <20210709123813.8700-2-ameynarkhede03@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Jul 2021 18:08:06 +0530 Amey Narkhede wrote: > Add has_pcie_flr bitfield in struct pci_dev to indicate support for PCIe > FLR to avoid reading PCI_EXP_DEVCAP multiple times. > > Currently there is separate function pcie_has_flr() to probe if PCIe FLR > is supported by the device which does not match the calling convention > followed by reset methods which use second function argument to decide > whether to probe or not. Add new function pcie_reset_flr() that follows > the calling convention of reset methods. > > Signed-off-by: Amey Narkhede > --- > drivers/crypto/cavium/nitrox/nitrox_main.c | 4 +- > drivers/pci/pci.c | 59 +++++++++++----------- > drivers/pci/pcie/aer.c | 12 ++--- > drivers/pci/probe.c | 6 ++- > drivers/pci/quirks.c | 9 ++-- > include/linux/pci.h | 3 +- > 6 files changed, 45 insertions(+), 48 deletions(-) Looks good to me, Reviewed-by: Alex Williamson