From: Alan Stern <stern@rowland.harvard.edu>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Johan Hovold <johan@kernel.org>,
syzbot <syzbot+72af3105289dcb4c055b@syzkaller.appspotmail.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, mathias.nyman@linux.intel.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] WARNING in do_proc_control/usb_submit_urb
Date: Mon, 12 Jul 2021 14:48:04 -0400 [thread overview]
Message-ID: <20210712184804.GA326369@rowland.harvard.edu> (raw)
In-Reply-To: <CACT4Y+biD8AdKncmvqmaz3dytV-zoeo==rdkTSJvaZ9=RUs=UA@mail.gmail.com>
On Mon, Jul 12, 2021 at 06:24:43PM +0200, Dmitry Vyukov wrote:
> On Mon, 12 Jul 2021 at 18:14, Alan Stern <stern@rowland.harvard.edu> wrote:
> > > It looks like the second patch you submitted was hand-edited and still
> > > quoted.
> > >
> > > And looking at the dashboard it seems like no patch was applied for your
> > > second test attempt:
> > >
> > > https://syzkaller.appspot.com/bug?extid=72af3105289dcb4c055b
> >
> > Yes, that explains it. Funny how easy it is to miss those "> "
> > markings -- you just get too used to them.
> >
> > > I've been bitten by something like this before when erroneously thinking
> > > that a test command could be submitted as a reply to a patch.
> > >
> > > Perhaps the report mail could include the patch tested or something so
> > > we don't spend time investigating syzbot interface failures.
> >
> > Good idea.
>
> The email always include the patch tested (as syzbot parsed it), see
> e.g. earlier reply in this thread:
> https://lore.kernel.org/lkml/00000000000074f06705c6ccd2a4@google.com/
The email doesn't include the patch; it includes a _link_ to the patch.
And the email does not contain any indication when no patch was parsed,
other than the missing "patch:" link -- which is not particularly
obvious if you aren't looking for it specifically:
https://marc.info/?l=linux-usb&m=162602190812912&w=2
> > Anyway, here's the patch again, this time properly formatted. Hopefully
> > now it will work.
>
> syzbot parsed this patch successfully:
> https://syzkaller.appspot.com/bug?extid=72af3105289dcb4c055b
Yes, and it worked. Time to submit it.
Alan Stern
next prev parent reply other threads:[~2021-07-12 18:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 11:11 [syzbot] WARNING in do_proc_control/usb_submit_urb syzbot
2021-07-10 14:50 ` Alan Stern
2021-07-10 22:58 ` syzbot
2021-07-11 0:36 ` Alan Stern
2021-07-11 15:53 ` Alan Stern
2021-07-11 16:07 ` syzbot
2021-07-12 14:00 ` Alan Stern
2021-07-12 15:29 ` Johan Hovold
2021-07-12 15:50 ` Johan Hovold
2021-07-12 16:14 ` Alan Stern
2021-07-12 16:24 ` Dmitry Vyukov
2021-07-12 18:48 ` Alan Stern [this message]
2021-07-15 7:19 ` Dmitry Vyukov
2021-07-12 16:32 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712184804.GA326369@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=syzbot+72af3105289dcb4c055b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.